Re: [PATCH v3 04/17] fix: utils: Fix the extract_list() utility function

[Kiizuha <riskimuhammmad1@gmail.com>]

On 20/12/2022 07.33, Alviro Iskandar Setiawan wrote:
> On Tue, Dec 20, 2022 at 6:57 AM Muhammad Rizki <kiizuha@gnuweeb.org> wrote:
>> +def extract_list(key: str, thread: Message):
>> +       try:
>> +               people = thread.get(key.lower())
>> +               if not people:
>> +                       return []
>> +       except:
>>                  return []
>>          return __extract_list(people)
> 
> Why does this have to be a "try and except"?
> And not something like:
> 
>          k = key.lower()
>          if k in thread:
>                  return __extract_list(people)
>          return []


It supposed to be just like this:

	people = thread.get(key.lower())
	if not people:
		return []
	return __extract_list(people)



But, the library is throwing an error if an email is not adding a To 
recipients.

Logs:

Traceback (most recent call last):
   File 
"D:\Riski\Coding\Github\rushkii\lore-daemon\daemon\atom\utils.py", line 
90, in extract_list
     people = thread.get(key.lower())
   File "C:\Program Files\Python38\lib\email\message.py", line 471, in get
     return self.policy.header_fetch_parse(k, v)
   File "C:\Program Files\Python38\lib\email\policy.py", line 163, in 
header_fetch_parse
     return self.header_factory(name, value)
   File "C:\Program Files\Python38\lib\email\headerregistry.py", line 
602, in __call__
     return self[name](name, value)
   File "C:\Program Files\Python38\lib\email\headerregistry.py", line 
197, in __new__
     cls.parse(value, kwds)
   File "C:\Program Files\Python38\lib\email\headerregistry.py", line 
344, in parse
     [Address(mb.display_name or '',
   File "C:\Program Files\Python38\lib\email\headerregistry.py", line 
345, in <listcomp>
     mb.local_part or '',
AttributeError: 'Group' object has no attribute 'local_part'



But, I know what causing this error right now. This error is the problem 
from using the email policy to default.

Refer: 
https://github.com/ammarfaizi2/lore-daemon/blob/91e86e6d1004da4526ca5514fa009bc253d5c4a3/daemon/atom/scraper.py#L61


I forget why I'm using `policy=email.policy.default` but I know it has a 
reason! What do you think? Should we just remove 
`policy=email.policy.default` or just keeping it and use the try/except 
in extract_list()?