From: Muhammad Rizki <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: GNU/Weeb Mailing List <[email protected]>
Subject: Re: [PATCH v2 00/18] New feature to handle atom URLs and broadcast
Date: Fri, 29 Jul 2022 08:01:41 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 29/07/2022 07.57, Ammar Faizi wrote:
> Rizki,
>
> On 7/29/22 7:44 AM, Muhammad Rizki wrote:
>> Morning sir,
>>
>> In this series I want to create a new feature to handle the atom URLs
>> and broadcast chats, such as add atom, add chat, del_atom and del_chat,
>> with this feature, we do not manual manage them again, just using
>> the bot commands and it will update in database.
>
> This series doesn't address the previous reviews.
I don't understand, can you explain?
>
>> ## Changelog
>>
>> v1 -> v2
>> - Improve delete_broadcast() source code in scraper/db.py
>> - Fix typehints to int for chat_id param in scraper/db.py
>
> Only these two?
>
>> .gitignore | 4 +
>> daemon/atom_broadcast.sql | 25 +++++
>> daemon/packages/client.py | 4 +-
>> daemon/packages/plugins/callbacks/del_atom.py | 31 +++++
>> daemon/packages/plugins/callbacks/del_chat.py | 36 ++++++
>> .../{admin.py => commands/debugger.py} | 0
>> .../packages/plugins/commands/manage_atom.py | 50 +++++++++
>> .../plugins/commands/manage_broadcast.py | 66 +++++++++++
>> .../packages/plugins/{ => commands}/scrape.py | 0
>> daemon/run.py | 16 +--
>> daemon/scraper/bot.py | 22 +---
>> daemon/scraper/db.py | 106 +++++++++++++++++-
>> daemon/scraper/utils.py | 45 ++++++++
>> 13 files changed, 379 insertions(+), 26 deletions(-)
>> create mode 100644 daemon/atom_broadcast.sql
>> create mode 100644 daemon/packages/plugins/callbacks/del_atom.py
>> create mode 100644 daemon/packages/plugins/callbacks/del_chat.py
>> rename daemon/packages/plugins/{admin.py => commands/debugger.py}
>> (100%)
>> create mode 100644 daemon/packages/plugins/commands/manage_atom.py
>> create mode 100644 daemon/packages/plugins/commands/manage_broadcast.py
>> rename daemon/packages/plugins/{ => commands}/scrape.py (100%)
>
> Just by reading the diffstat, I am not going to take your patches.
> At first sight this is still wrong, you still even have:
>
> daemon/atom_broadcast.sql
>
> while the previous review asked not to create a new database.
>
> Please address those first before sending a new revision, I don't
> want to see the same mistake in v3. Understand?
>
Oh yes I forget again to combine the SQL, sorry my bad.
next prev parent reply other threads:[~2022-07-29 1:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 0:44 [PATCH v2 00/18] New feature to handle atom URLs and broadcast Muhammad Rizki
2022-07-29 0:44 ` [PATCH v2 01/18] Add atom_broadcast.sql Muhammad Rizki
2022-07-29 0:44 ` [PATCH v2 02/18] Add ATOM_URLS and BROADCAST_CHAT methods Muhammad Rizki
2022-07-29 0:44 ` [PATCH v2 03/18] Fix MySQL InternalError: Unread result found Muhammad Rizki
2022-07-29 0:44 ` [PATCH v2 04/18] Create /add_atom command Muhammad Rizki
2022-07-29 0:44 ` [PATCH v2 05/18] Add utility functions for /add_atom Muhammad Rizki
2022-07-29 0:44 ` [PATCH v2 06/18] Refactor database methods Muhammad Rizki
2022-07-29 0:44 ` [PATCH v2 07/18] Add insert_atom() in scraper/db.py Muhammad Rizki
2022-07-29 0:44 ` [PATCH v2 08/18] Rename admin.py to debugger.py Muhammad Rizki
2022-07-29 0:44 ` [PATCH v2 09/18] Add delete_atom() function in scraper/db.py Muhammad Rizki
2022-07-29 0:44 ` [PATCH v2 10/18] Add utility function buton_numbers() Muhammad Rizki
2022-07-29 0:45 ` [PATCH v2 11/18] Move bot commands related files to packages/plugins/commands/ Muhammad Rizki
2022-07-29 0:45 ` [PATCH v2 12/18] Add del_atom callback query Muhammad Rizki
2022-07-29 0:45 ` [PATCH v2 13/18] Add insert_broadcast() in scraper/db.py Muhammad Rizki
2022-07-29 0:45 ` [PATCH v2 14/18] Add delete_broadcast() " Muhammad Rizki
2022-07-29 0:45 ` [PATCH v2 15/18] Create /add_bc bot command Muhammad Rizki
2022-07-29 0:45 ` [PATCH v2 16/18] Add create_chat_link() function Muhammad Rizki
2022-07-29 0:45 ` [PATCH v2 17/18] Add /del_bc bot command Muhammad Rizki
2022-07-29 0:45 ` [PATCH v2 18/18] Add del_chat callback query Muhammad Rizki
2022-07-29 0:57 ` [PATCH v2 00/18] New feature to handle atom URLs and broadcast Ammar Faizi
2022-07-29 1:01 ` Muhammad Rizki [this message]
2022-07-29 1:06 ` Ammar Faizi
-- strict thread matches above, loose matches on Subject: below --
2022-07-29 0:40 [PATCH v1 " Muhammad Rizki
2022-07-29 0:40 ` [PATCH v2 " Muhammad Rizki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox