From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from [192.168.1.2] (unknown [101.128.125.94]) by gnuweeb.org (Postfix) with ESMTPSA id C69737E328; Fri, 29 Jul 2022 01:01:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1659056506; bh=f6kZuzIcYw7DorT0oixznYHSrTq9KdCJGNFRUSjK/EU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=O8zzoybTyqNr7213zwpsnPrL8VeQoEbMj/haxE0yZ4EvXFR90aDV21VGJ3Lea7X/Y 4xCooJdXeruBeL1f/X0UFuBO9VSHl/9vh5h+EbfSr0bOgFcce0ni0evJTBdk7U29eH w6VA8nOubD/CPNiJNNkfemtv6jztPwiFi1EBANgSmUC7lvffmzjjTBxZQiwLvskKQp am1NkDwkDzyXdUQ0xq/1V5IGSZxOoTzxVL0utQN7XEsCeoKvA6dVlKaMEvYUMF/vA7 kOcNC+nnpI8Tr7mBaEYdYrHSsnXQmZspZD7C5AIMzWa9ir6fiYHDA3U2pjpV9MLdRf M8W7OqRC+FE4g== Message-ID: <0075cdba-8b4d-6983-d2ae-eda902edc65a@gnuweeb.org> Date: Fri, 29 Jul 2022 08:01:41 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH v2 00/18] New feature to handle atom URLs and broadcast To: Ammar Faizi Cc: GNU/Weeb Mailing List References: <20220729004507.1668-1-kiizuha@gnuweeb.org> Content-Language: en-US From: Muhammad Rizki In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: On 29/07/2022 07.57, Ammar Faizi wrote: > Rizki, > > On 7/29/22 7:44 AM, Muhammad Rizki wrote: >> Morning sir, >> >> In this series I want to create a new feature to handle the atom URLs >> and broadcast chats, such as add atom, add chat, del_atom and del_chat, >> with this feature, we do not manual manage them again, just using >> the bot commands and it will update in database. > > This series doesn't address the previous reviews. I don't understand, can you explain? > >> ## Changelog >> >> v1 -> v2 >> - Improve delete_broadcast() source code in scraper/db.py >> - Fix typehints to int for chat_id param in scraper/db.py > > Only these two? > >>   .gitignore                                    |   4 + >>   daemon/atom_broadcast.sql                     |  25 +++++ >>   daemon/packages/client.py                     |   4 +- >>   daemon/packages/plugins/callbacks/del_atom.py |  31 +++++ >>   daemon/packages/plugins/callbacks/del_chat.py |  36 ++++++ >>   .../{admin.py => commands/debugger.py}        |   0 >>   .../packages/plugins/commands/manage_atom.py  |  50 +++++++++ >>   .../plugins/commands/manage_broadcast.py      |  66 +++++++++++ >>   .../packages/plugins/{ => commands}/scrape.py |   0 >>   daemon/run.py                                 |  16 +-- >>   daemon/scraper/bot.py                         |  22 +--- >>   daemon/scraper/db.py                          | 106 +++++++++++++++++- >>   daemon/scraper/utils.py                       |  45 ++++++++ >>   13 files changed, 379 insertions(+), 26 deletions(-) >>   create mode 100644 daemon/atom_broadcast.sql >>   create mode 100644 daemon/packages/plugins/callbacks/del_atom.py >>   create mode 100644 daemon/packages/plugins/callbacks/del_chat.py >>   rename daemon/packages/plugins/{admin.py => commands/debugger.py} >> (100%) >>   create mode 100644 daemon/packages/plugins/commands/manage_atom.py >>   create mode 100644 daemon/packages/plugins/commands/manage_broadcast.py >>   rename daemon/packages/plugins/{ => commands}/scrape.py (100%) > > Just by reading the diffstat, I am not going to take your patches. > At first sight this is still wrong, you still even have: > >    daemon/atom_broadcast.sql > > while the previous review asked not to create a new database. > > Please address those first before sending a new revision, I don't > want to see the same mistake in v3. Understand? > Oh yes I forget again to combine the SQL, sorry my bad.