From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,RCVD_IN_ZEN_BLOCKED_OPENDNS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Authentication-Results: server-vie001.gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=ns0NhRQE; dkim-atps=neutral Received: by server-vie001.gnuweeb.org (Postfix, from userid 1000) id C993F3204B4D; Fri, 13 Feb 2026 21:10:50 +0000 (UTC) Authentication-Results: server-vie001.gnuweeb.org; dmarc=none (p=none dis=none) header.from=kernel.dk Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.210.49; helo=mail-ot1-f49.google.com; envelope-from=axboe@kernel.dk; receiver= Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) by server-vie001.gnuweeb.org (Postfix) with ESMTPS id 5A90B3204B4D for ; Fri, 13 Feb 2026 21:10:50 +0000 (UTC) Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-7d4c65d744cso493389a34.3 for ; Fri, 13 Feb 2026 13:10:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1771017049; x=1771621849; darn=vger.gnuweeb.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=pGkCwWWp/FPqK28ijtGke74sI3QcTgk3m1OKgHdqNm4=; b=ns0NhRQErtDTsMPsnDv79Nkes+UvAgT7+79clsoO8/8FuoSknTduMASoUFnJvjgBaA Yn9s4Nm8Dgis+lI8r78VAr0v2MGZSxNhtOlLLVJ6WnBtKA2Vq95kWsfzycncboHqDeU2 NYsRKkyAID6EG0ew5J2aHFQEf8a15H6vtdvt7+VkD4w/T/eQW8/ITTj8enO+0wBFmgXR I/4T9YiV/38X2Vqd2jsGwQaQKFCKhgL9ExceIJqL2DMULU78l6/HNunkfrIPW/8FJmMn MpZnNiUCiKdGYJpVwOWpmwkjuv5OvX2E59b3Hm8WF90yJE1YoDHsDEpa11Pn0rME8qHc cSeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771017049; x=1771621849; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pGkCwWWp/FPqK28ijtGke74sI3QcTgk3m1OKgHdqNm4=; b=A2MdjTqdgFYEfpBC8fwTzx9SiWgkZgnKywmnrqo636gYwBgHorra6/N81CJqP3y6h8 ywF39DU6f/itXtcJ+UnUZXgbJOD5HOeQApoFEXx9wFqtBtdF4NEW2jOSOjACD/LjlKVE +bupfVMobXaLIDgDfmTAZEdWa16vtjZ65VUVbO8b1iPuWfDPNJJHmDc3B19CqT+wqvNt KNKuiZN4IDZyvR3iDXhTZiobsKShj3LLviArwdN8h0w0FsxGCyvEfVz7o1Xcgkp/bPdw nI6nwl9wdzXi9s/y/TKvEWGv4rIfJbmORrRzQdrX/wEWX8ZZ6R2r1E/nJsKsam8B4Slj tlpQ== X-Forwarded-Encrypted: i=1; AJvYcCUfeJ5ZiMTME/xdcbRTcIkKcl6ELJtlE5cnX48aY0YxuIo3y6jvCT40HSsDML0f3WbU26Bf@vger.gnuweeb.org X-Gm-Message-State: AOJu0Yz21xQ9zNuirqWPnKUZLTkIPK0+i6x+9IZzZOHW0BN3x2JNHS84 xCvRhKWMKYHqnXgelCwude9jkLMqITb1Zi4Y41HX2jtCiMQzG9Lz1HKHR2zW0cjhxbw= X-Gm-Gg: AZuq6aLLOhOWadkpH0ND4kReyM/oXWUPxGEe8Galrj0ynAG5iLVf+vU+X79BUc5MqiW ppHEXBBCVFWPqS4UKLz8ntEoY9SbkqUFRCMjB4WWxHPwCqdpFMcIrBMq0NQQ59KtJzs99ejB7sg bzIRzpscXhxzVHkwdOtf2ovPbTpC0mh3zADwM+ZUEyyNNVx9EYRPUi9AhnYA+5yKqOcFRFjBv3e xMklDpaGvD652EQ1ZwRu8Ih4DkCgVno4JBKFcUmV9bgga8Nk4LMLrDfJ358Vjr0hgDCKd430ij8 tI0OwPO4XBP1401zPOyzzOXBZw9JsGUPiZn8pLfkKMtc6H2AciGXhifPcHekLYQzc3D36L9/2Yf vAn8oHHQ/IqvIjj896nWlggxOBVMM7hvLqxyHiVnxSb+AeD0VMQ2qTgWmYU56Fo7zkEp1YNhucz I1EtiA3He6ovvyI8HwgYJISKwBxwVvQDI9yi/Sr34gzOaTHVd4ZhrqmfCTUD+dAjf3ZSEEzrEWI ltQ9ACo X-Received: by 2002:a05:6830:3152:b0:7d4:4d52:efcc with SMTP id 46e09a7af769-7d4c4a62bf8mr2142190a34.14.1771017048759; Fri, 13 Feb 2026 13:10:48 -0800 (PST) Received: from [192.168.1.102] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d4a76f9483sm7346026a34.20.2026.02.13.13.10.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Feb 2026 13:10:48 -0800 (PST) Message-ID: <00bc96d8-c304-412c-b176-1b30ff0847af@kernel.dk> Date: Fri, 13 Feb 2026 14:10:47 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH liburing] src/Makefile: Fix missing bpf_filter.h installation From: Jens Axboe To: Ammar Faizi Cc: io-uring Mailing List , GNU/Weeb Mailing List References: <20260213210548.851503-1-ammarfaizi2@gnuweeb.org> <177101682427.298850.12069195780298295812.b4-ty@kernel.dk> Content-Language: en-US In-Reply-To: <177101682427.298850.12069195780298295812.b4-ty@kernel.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: On 2/13/26 2:07 PM, Jens Axboe wrote: > > On Sat, 14 Feb 2026 04:05:48 +0700, Ammar Faizi wrote: >> After a "make install" command, liburing.h fails to compile because >> bpf_filter.h is not copied to the destination include directory: >> >> In file included from .github/workflows/test_build.c:1: >> /usr/include/liburing.h:21:10: fatal error: liburing/io_uring/bpf_filter.h: No such file or directory >> 21 | #include "liburing/io_uring/bpf_filter.h" >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> compilation terminated. >> >> [...] > > Applied, thanks! > > [1/1] src/Makefile: Fix missing bpf_filter.h installation > commit: 364a7b561fa13cffdd7771978dc5509ec4d9d7f9 Thanks, I missed that! BTW, for the future, for: Fixes: 46b5c4d66232dcadd0f46c875e6fabce3b3dea85 ("src/include/liburing.h: add bpf_filter.h header") shorten the sha to 12 chars, we don't need the full sha. For your ~/.gitconfig: [core] abbrev = 12 [pretty] fixes = Fixes: %h (\"%s\") [alias] fixes = log -1 --format=fixes and then you can just do: axboe@m2max ~/gi/liburing (master)> git fixes 46b5c4d66232dcadd0f46c875e6fabce3b3dea85 Fixes: 46b5c4d66232 ("src/include/liburing.h: add bpf_filter.h header") and it gives you the right format. -- Jens Axboe