From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [10.7.7.2] (unknown [182.253.183.90])
	by gnuweeb.org (Postfix) with ESMTPSA id 41AA8804D1;
	Fri, 28 Oct 2022 19:33:42 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1666985624;
	bh=kR01e+OGhuybEcckqrWxPpFEfug9xBf0yxAXqiR7eJM=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=fpBNtrVJfuTyAwGB9Wb0PwE/Vs5WPyylXd4ezsap/YLKlJ/zeLqy0ssb+NoQlJKWa
	 BQdgqH4fDqLAXOwCebAkmNpS7V+K6RxPWnDUUA3ki8GUbHzn/abE0vXIW1bmbHYXz5
	 HqsDCmOl67oqW3HaUExx9bXYgKY+DDFKsKcgDBdQ6dxF29yxlp+65e5uYpbheQRcd8
	 nYGDzRowRFJLj6zlLTGdWzJjW0Xq0uzUXFJDvCbwsirPvPs2ZSNk3wOB8aGDRYhnGL
	 jPn/XeEuNDNBY2R5uExtsU9r/qomLuCLBs+H/zqURhf+p70xP6aWQTqP2bEWDGoo/E
	 HBNovw7x87aKA==
Message-ID: <086b02fa-05ba-f546-311a-8f1a06b3dece@gnuweeb.org>
Date: Sat, 29 Oct 2022 02:33:40 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v1 2/2] daemon: telegram: Handle MySQL error
Content-Language: en-US
To: Muhammad Rizki <kiizuha@gnuweeb.org>,
 Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Cc: GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20221027150823.601914-1-ammarfaizi2@gnuweeb.org>
 <20221027150823.601914-3-ammarfaizi2@gnuweeb.org>
 <CAOG64qN9BZcnz1px8tAj9_Y96FhU1nVMOA58rfs-4nRY6GhWAg@mail.gmail.com>
 <1d500d37-b11b-75fd-38e5-d7f8e0a9b1d4@gnuweeb.org>
 <CAOG64qO8c4gE=HmL-1QQkqenD+T4ezsU=+FCGsth59=CFjyKpw@mail.gmail.com>
 <3a79a587-ddee-9e25-2ac5-b573938b44a9@gnuweeb.org>
 <043f55c3-67d8-9130-aca4-73c59926d2af@gnuweeb.org>
 <CAOG64qNSS6S0geOHHi50Z_sW5ymW4Cb5=JYt5VO3=4-jjh2KhQ@mail.gmail.com>
 <63aa1b63-f7e2-8da3-b16d-0c7e1045d697@gnuweeb.org>
 <CAOG64qOoL3knPRTVcX+jOopt+24vE0C39Y0Jf1-YAnbGhG7LFQ@mail.gmail.com>
 <9ecfe8ab-fa5a-d01a-0b68-bc639f14888f@gnuweeb.org>
 <59d21a5e-8ade-f9fe-b2e5-1bea79b07921@gnuweeb.org>
 <c1f89dfd-0478-d7d2-b072-90da9223b77a@gnuweeb.org>
 <71de4c1b-7482-5f7f-4c4f-4dbff7ee32ad@gnuweeb.org>
 <b4201ae4-f2c0-2cd8-9fb8-c7269c7534a3@gnuweeb.org>
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
In-Reply-To: <b4201ae4-f2c0-2cd8-9fb8-c7269c7534a3@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
List-Id: <gwml.vger.gnuweeb.org>

On 10/29/22 2:22 AM, Muhammad Rizki wrote:
> I create that statement because:
[...]
>          try:
>              text, files, is_patch = utils.create_template(mail, Platform.TELEGRAM)
>          except:
> 
>              # ensure the created tmp dir is removed
>              utils.remove_patch()
> 
>              exc_str = utils.catch_err()
>              self.client.logger.warning(exc_str)
>              await self.client.send_log_file(url)
> 
>              # return, to avoid local variable error
>              return

This is ugly, will you do the:

     exc_str = utils.catch_err()
     self.client.logger.warning(exc_str)
     await self.client.send_log_file(url)

all over the place when error may happen?

-- 
Ammar Faizi