From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM
	autolearn=ham autolearn_force=no version=3.4.6
Received: from [10.7.7.5] (unknown [182.253.183.184])
	by gnuweeb.org (Postfix) with ESMTPSA id DFBD87E443;
	Tue,  3 Jan 2023 22:20:16 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1672784418;
	bh=eLYNLU9xks53ABWa0sv7Bg52JHWtzXc56nFCbSh9YXk=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=p4JVumv5DssJLXvaSB1cNelURV58pKa5A5g6W9w/vBuCv7ArJW3SgvAlz16U6XhKw
	 ZM+iXoMyCMFbkKhk3hrgBc202mkv0RG4zMOhfjkcldwdnWZHJynu86w2Kv3vNM50lM
	 mQxDSxP/rlbPrbg6nGQpMCEkaoEPEi03vOMh9eBi3m/oPMdYo/ZpABEPnlp/ZOWlnu
	 YDNLAea86T/FmqxsllyKRpfjfy9rCoPDxlMIQirX92v+w4CQ/Zj/K7ncGyBXCTHOLf
	 qYIGHlGmKWJl78zIWZYNdTP6swPt4HpnQaRz7zWVWNLUJlwE6/+7TiB0wjkpRTeqQz
	 /Fq3XNa3EOCOA==
Message-ID: <0a41da94-dae1-2285-4438-de6f026dc059@gnuweeb.org>
Date: Wed, 4 Jan 2023 05:20:14 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v1 08/13] feat(discord): Implement the report_err()
Content-Language: en-US
To: Muhammad Rizki <kiizuha@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
 GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20230103063641.1680-1-kiizuha@gnuweeb.org>
 <20230103063641.1680-9-kiizuha@gnuweeb.org>
 <f3daa336-00c2-ad69-cadc-50012a8a7d9b@gnuweeb.org>
 <b12ad506-877b-bebb-9e5f-997caa0e8e15@gnuweeb.org>
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
In-Reply-To: <b12ad506-877b-bebb-9e5f-997caa0e8e15@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 1/3/23 7:20 PM, Muhammad Rizki wrote:
> I already added the same custom exception, DaemonException() is
> reusable error class for both Telegram and Discord. The location is
> in the exceptions.py in the daemon directory.

[ Sending this again because it seems you didn't care with my next reply ]

OK, just took a look at patch #12, and you implemented it there.
But why should we implement the broken report_err() first, then
the fixed report_err() with DaemonException?

I think implementing the old broken exception handling design is
not needed, just go with the DaemonException pattern we agree on.

-- 
Ammar Faizi