From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from [192.168.1.5] (unknown [101.128.125.100]) by gnuweeb.org (Postfix) with ESMTPSA id D8E95804D1; Sat, 3 Sep 2022 03:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1662174553; bh=0jLOotwjW2bVXQ7TsUe1ZObS9eLBOCGZoK3owY/AY50=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mq4wYqyWqgoVJClWdlIYqun6tmwMhWFdJ4n7gug0krw7B8zDeG9u/OD4Xwe0NxX85 Gce4YdBzXi+49E7D81TBNQoOY+DUdgtyCx8qFGp3AlzKImddCxihcVFS8mDf5JDJNR n722lc4n1rSqoi7vYkz7MTwIliPrNNa/5fqEY6wQY3ADm80ekfNKpJKfpphrim+Omp m52cMs6H0Upz50VkSEVf5X/qhJ+O1LKgpXBQcqY53tQFsYT8hxmRRlcn7f1tpMDyHC hhMKYKignORrNJXUTGJgRX6hpx+hy+1cb0RIaOWxiVqfHbtO4CY2W+PsZnRSbRP7fn qBgKvabrlALXg== Message-ID: <0b32c3f0-f826-7c83-b90d-0ad04d5a8dcf@gnuweeb.org> Date: Sat, 3 Sep 2022 10:09:07 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2 0/3] New Discord bot and full refactor scripts Content-Language: en-US To: Ammar Faizi Cc: GNU/Weeb Mailing List , Alviro Iskandar Setiawan References: <20220827030236.1094-1-kiizuha@gnuweeb.org> From: Muhammad Rizki In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: On 03/09/2022 08.28, Ammar Faizi wrote: > On 8/27/22 10:02 AM, Muhammad Rizki wrote: >> Muhammad Rizki (3): >>    Move the Telegram bot source code >>    First release Discord bot >>    Full refactor bot scripts > > Please split these into smaller manageable-reviewable pieces. > I simply can't review it. Each patch should only do one thing. > This it too big to review. > > For example, something like this: > >   Patch #1: daemon: telegram: Move telegram bot source code >   Patch #2: daemon: discord: Initial Discord bot MySQL table >   Patch #3: daemon: telegram: Adjust table naming with Discord >   Patch #4: daemon: discord: Initial Discord bot core (python) >   Patch #5: daemon: discord: Add feature AAAAAA >   Patch #6: daemon: discord: Add feature BBBBBB >   Patch #7: daemon: discord: Add feature CCCCCC >   ... and so on > > I want something like that or whatever reviewable. Not this huge > diff doing everything in a single patch. This series is crazy and > can't be reviewed. > Alright..