GNU/Weeb Mailing List <[email protected]>
 help / color / mirror / Atom feed
From: Ammar Faizi <[email protected]>
To: Jens Axboe <[email protected]>, Dylan Yudaken <[email protected]>
Cc: Pavel Begunkov <[email protected]>,
	GNU/Weeb Mailing List <[email protected]>,
	io-uring Mailing List <[email protected]>,
	Facebook Kernel Team <[email protected]>,
	Dylan Yudaken <[email protected]>
Subject: Re: [PATCH liburing v1 1/3] liburing: Clean up `-Wshorten-64-to-32` warnings from clang
Date: Thu, 20 Oct 2022 19:12:05 +0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 10/20/22 6:52 PM, Ammar Faizi wrote:
> From: Dylan Yudaken<[email protected]>
> 
> liburing has a couple of int shortening issues found by clang. Clean
> them all. This cleanup is particularly useful for build systems that
> include these files and run with that error enabled.
> 
> Link:https://lore.kernel.org/io-uring/[email protected]
> Signed-off-by: Dylan Yudaken<[email protected]>
> Co-authored-by: Ammar Faizi<[email protected]>
> Signed-off-by: Ammar Faizi<[email protected]>

BTW, before it's too late. I think we should be consistent on the cast
style:

    (type) a

or

    (type)a

What do you think?

-- 
Ammar Faizi


  reply	other threads:[~2022-10-20 12:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20 11:52 [PATCH liburing v1 0/3] Clean up clang `-Wshorten-64-to-32` warnings Ammar Faizi
2022-10-20 11:52 ` [PATCH liburing v1 1/3] liburing: Clean up `-Wshorten-64-to-32` warnings from clang Ammar Faizi
2022-10-20 12:12   ` Ammar Faizi [this message]
2022-10-20 12:52     ` Jens Axboe
2022-10-20 11:52 ` [PATCH liburing v1 2/3] Makefile: Introduce `LIBURING_CFLAGS` variable Ammar Faizi
2022-10-20 11:52 ` [PATCH liburing v1 3/3] github: Append `-Wshorten-64-to-32` flag for clang build Ammar Faizi
2022-10-20 12:53 ` [PATCH liburing v1 0/3] Clean up clang `-Wshorten-64-to-32` warnings Dylan Yudaken
2022-10-20 12:57   ` Ammar Faizi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox