From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,URIBL_DBL_BLOCKED_OPENDNS autolearn=no autolearn_force=no version=3.4.6 Authentication-Results: gnuweeb.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=LxMjuzgJ; dkim-atps=neutral Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.167.47; helo=mail-lf1-f47.google.com; envelope-from=mustafa.eskieksi@gmail.com; receiver= Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by gnuweeb.org (Postfix) with ESMTPS id 02C8B24AADF for ; Mon, 8 Apr 2024 22:23:21 +0700 (WIB) Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-516dbc36918so2555169e87.0 for ; Mon, 08 Apr 2024 08:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712589799; x=1713194599; darn=vger.gnuweeb.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5aJBY+lZMBOzeDlvQBcDc5wZfXjkZJi9SVA77e0QYTY=; b=LxMjuzgJZOJTmV4wnrE1zYnzP8I0/ZjlMau3h5lEby50uh/U5ZxeoBiwHFUSHznbUk u7kwxndYSiP8qeVkYIFb23/wA9KhXr0ypypFUbuCCL1KGb7xxO4iO/vUtPSirhUp+GB5 JwPLx6u4vJR8VULENj2uDU+VRc9ielBHGtF9X33oE8H9IO2LJUQlOrsVraJ0tURl9+y/ na47fOCb0ISbTQIT2Qqfux98c/qYrz/pUhGqrhI5kNHralILI4sWtHktLNxdte8i9jzj lW4+0pgp0/qzWQ2hLR4gnEL9fJuHYH5/GrA6OAfXjzxgvaUMqKJUtTaKrxzc04TMhODW nHaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712589799; x=1713194599; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5aJBY+lZMBOzeDlvQBcDc5wZfXjkZJi9SVA77e0QYTY=; b=OYU5F/2mBF+0p64DnkTMD+Qs5OtfdRYAglbqrrwb8WEeAAxoCivL8ghjh4rXS9xH0w sXR6/TlMjY7xf42Q/6DCTNYHZ49Mm10WXVp9OhOoTVVs+lAPRHILRkspGb62HJg2zR4b XZ9pQ8osjJzbSBdtJrPfxatmQrsSQl5nKTLoFF9Roan5TACGMVQsZFSOOuNJm0+ps6eK yyoiIqb5fMxEy20Lp7Mt1IR801EThGzRMLSy2oyX+G73Vz2E3P869izorOPC/MSTeD1g stXCJ/nx6uP27Ndo2fcAtU8JAzJF1sNzHsOoeqD0R90dXfbc61bsDMADQC5EDlytpMeL KUBg== X-Forwarded-Encrypted: i=1; AJvYcCXvcsj5fbXbgrvfeY5w81YWXBRV9ti0JF88eIl/n1UYhneh4UmM7TpmHsN3TXWKaPNtUfxANgdi/yLB0+I+ECRcsj3DBHU= X-Gm-Message-State: AOJu0YyMtd0L7sA87hIBF5u+FFwuulWHasUcDF1ekrcJyo4ImGd/erCF QxBftuboo881GEbD0hknesysE1Afsc7Kbj5hzai1WllD+aNtODWw X-Google-Smtp-Source: AGHT+IH4FQk+olUPye5/qT5UhgYxtR0ctIYPXKb7ahlfpoh73KZ4aTrWe59dHaOVw+Ua31BF9351Lw== X-Received: by 2002:a19:914b:0:b0:516:be09:4b5e with SMTP id y11-20020a19914b000000b00516be094b5emr5477888lfj.46.1712589796719; Mon, 08 Apr 2024 08:23:16 -0700 (PDT) Received: from [192.168.1.105] ([94.120.83.72]) by smtp.gmail.com with ESMTPSA id a23-20020a1709062b1700b00a51dd26f6dcsm922980ejg.51.2024.04.08.08.23.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 08:23:16 -0700 (PDT) Message-ID: <15fdc072-9329-4675-8d9e-189862d88351@gmail.com> Date: Mon, 8 Apr 2024 18:23:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/1] platform/x86: Add wmi driver for Casper Excalibur laptops To: Stella Bloom Cc: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, jdelvare@suse.com, lee@kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux@roeck-us.net, pavel@ucw.cz, platform-driver-x86@vger.kernel.org, Alviro Iskandar Setiawan , Ammar Faizi , GNU/Weeb Mailing List , Stella Bloom , Bedirhan KURT References: <20240324181201.87882-1-mustafa.eskieksi@gmail.com> <20240407005746.412603-1-windowz414@gnuweeb.org> Content-Language: en-US From: =?UTF-8?Q?Mustafa_Ek=C5=9Fi?= In-Reply-To: <20240407005746.412603-1-windowz414@gnuweeb.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit List-Id: On 7.04.2024 03:57, Stella Bloom wrote: >> From: Mustafa Ekşi >> >> Hi, >> I want to note that moving mutex_init to the bottom of the function >> crashes the driver when mutex_lock is called. I didn't investigate it >> further but I wanted to say that since Ai Chao also did it like that. >> >> Driver sets all leds to white on start. Before that, when a led's >> brightness is changed, that led's color gets set to white but others >> keep their old colors which creates a bad user experience (at least for >> me). Please inform me if this is a bad approach. >> Also, this driver still lacks support for changing modes and I seek >> advise for that. >> >> Mustafa Ekşi (1): >> platform/x86: Add wmi driver for Casper Excalibur laptops >> >> MAINTAINERS | 6 + >> drivers/platform/x86/Kconfig | 14 + >> drivers/platform/x86/Makefile | 1 + >> drivers/platform/x86/casper-wmi.c | 641 ++++++++++++++++++++++++++++++ >> 4 files changed, 662 insertions(+) >> create mode 100644 drivers/platform/x86/casper-wmi.c >> > Hi there, > > I just wanted to pitch in by testing the driver on the kernel I use > on my Arch install on an Excalibur G770.1245, namely xdevs23's > linux-nitrous (https://gitlab.com/xdevs23/linux-nitrous), but trying to > compile the driver using LLVM, which is the default compilation behavior > in this kernel's AUR package, spits out the following error; > ``` > drivers/platform/x86/casper-wmi.c:633:3: error: field designator 'no_singleton' does not refer to any field in type 'struct wmi_driver' > 633 | .no_singleton = true, > | ~^~~~~~~~~~~~~~~~~~~ > 1 error generated. > make[5]: *** [scripts/Makefile.build:243: drivers/platform/x86/casper-wmi.o] Error 1 > make[4]: *** [scripts/Makefile.build:481: drivers/platform/x86] Error 2 > make[3]: *** [scripts/Makefile.build:481: drivers/platform] Error 2 > make[2]: *** [scripts/Makefile.build:481: drivers] Error 2 > make[1]: *** [/home/stella/.cache/yay/linux-nitrous/src/linux-nitrous/Makefile:1919: .] Error 2 > make: *** [Makefile:240: __sub-make] Error 2 > ``` > > I want to help debug this somehow, but I'm more of an Android custom > ROM developer than a Linux kernel maintainer, so my knowledge on the > programming and build system languages other than Java, Makefile, Bash, > etc is pretty much limited if not outright non-existent. Hi, This is because of a newly merged patch from Armin Wolf: https://lore.kernel.org/platform-driver-x86/20240226193557.2888-2-W_Armin@gmx.de/ You can comment that line or apply that patch to your tree to make it compile. Also, you'll probablyneed to change the call to wmidev_block_set in casper_query function with wmi_set_block (which is now deprecated). > I would *love* to see this driver actually hit mainline repos, and > eventually the upcoming kernel releases, given how much I need to use > this laptop of mine as a computer engineering student. > > Asking just for the case I manage to get this driver up and going on > my end somehow: Is there a tool made for controlling the LED colors yet? > I can still use CLI tools much like on ASUS ROG series laptops, but it > would be much easier and more appreciated to have a GUI provided > Excalibur series laptops' LED lights can virtually take any color in > the RGB space - At least that's how I interpreted with the > configurations I used to do on mine using Excalibur Control Center > on Windows 10/11. No, there isn't a tool yet but controlling leds via sysfs ispretty easy. For example, if you wanted to change the left led zone's color to red: ``` # echo 0xff0000 > /sys/class/leds/casper\:\:kbd_zoned_backlight-left/multi_intensity ``` And don't forget that all leds' initial brightnesses are 0. Also, I'm planning to add support for this API in OpenRGB. > And as for the profiles, let me make sure we're talking about the same > thing in this term: You're talking about the "Office", "Gaming" and > "High Performance" modes as seen in Excalibur Control Center, right? For laptops with 11th gen processors or newer: yes. For laptops with 10th gen processors or older: no, there are 4 power profiles for these laptops (High Performance, Gaming, Text Mode andPower save). > If so, can this be somehow integrated into `power-profiles-daemon` > SystemD service for easier controlling with GNOME and other DEs that > use it? It's fine if it can't be, this was just a thought struck on my > mind for whatever reason. Yes, power-profiles-daemon is already integrated with platform_profile. > Please do CC me and the people I've added to the CC list with this email > of mine on the upcoming revisions, if any. We would love to keep track > of this driver and I personally would love to contribute into testing > as a power user. > > Cc: Alviro Iskandar Setiawan > Cc: Ammar Faizi > Cc: GNU/Weeb Mailing List > > Also adding my organizational and school email addresses to the CC list > so I can still be notified while I stay offline on this email address. > GNOME Evolution doesn't run in the background and periodically check > for emails sadly, and I switch ROMs every now and then on my phone as a > source maintainer of 3 different custom ROMs. :/ > > Cc: Stella Bloom > Cc: Bedirhan KURT > > -- > Stella Bloom Thanks for your interest, Mustafa Ekşi