From: Jens Axboe <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: io-uring Mailing List <[email protected]>,
GNU/Weeb Mailing List <[email protected]>,
Tea Inside Mailing List <[email protected]>,
Alviro Iskandar Setiawan <[email protected]>,
Nugra <[email protected]>
Subject: Re: [PATCH liburing v2] queue, liburing.h: Avoid `io_uring_get_sqe()` code duplication
Date: Fri, 25 Feb 2022 07:16:43 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Fri, 25 Feb 2022 07:58:14 +0700, Ammar Faizi wrote:
> Since commit 8be8af4afcb4909104c ("queue: provide io_uring_get_sqe()
> symbol again"), we have the same definition of `io_uring_get_sqe()` in
> queue.c and liburing.h.
>
> Make it simpler, maintain it in a single place, create a new static
> inline function wrapper with name `_io_uring_get_sqe()`. Then tail
> call both `io_uring_get_sqe()` functions to `_io_uring_get_sqe()`.
>
> [...]
Applied, thanks!
[1/1] queue, liburing.h: Avoid `io_uring_get_sqe()` code duplication
commit: 15c01fcd1b0d37a12d945ab8dcdf96b3e055a4fd
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-02-25 14:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 0:58 [PATCH liburing v2] queue, liburing.h: Avoid `io_uring_get_sqe()` code duplication Ammar Faizi
2022-02-25 14:16 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164579860316.5714.11586792942122127124.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox