From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by gnuweeb.org (Postfix) with ESMTPS id 02E0F7E29A for ; Fri, 25 Feb 2022 14:16:44 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20210112.gappssmtp.com header.i=@kernel-dk.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=mZFiO8V9; dkim-atps=neutral Received: by mail-pf1-f175.google.com with SMTP id y11so4802727pfa.6 for ; Fri, 25 Feb 2022 06:16:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=4HKJXFsqbCU8ZlJrUHK2ZfxHsjnNJeIKGbdPC5wBnjw=; b=mZFiO8V9kniKYq13DoQl3dADEHw8FSbWEhVRDjG9QTd6vqn73DZEEfe45rZmQ4snlS LHo4nGO5tZVwaUu//jsUwcSRifvgzCrxRDHXys+SfjoQ2TsBS4IS3j460wht37d4EA9J 9iyyK9Md+jjCp0xmUc4lziltSfy3z3ACrbOe8RLBmuL+dVDmgQUL9E1ycMMJHpWIM4Pu 6VQWRhi8FYFE3i7IV6u3HlEMYOyjgeckCc4GEZdAR6mTDtpDbtInB4lklcQ10PwSbGo0 Sw7xUFDMCVz1e/9Oz43gUBf/aCYaYtBql1kiFQ+tl98FLEjOzCtHoZRz6kqqUa6hSrmm gPfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=4HKJXFsqbCU8ZlJrUHK2ZfxHsjnNJeIKGbdPC5wBnjw=; b=YVk5FdT057PAYLkYQdBVy0D2fx+T5z0a2FQ0YyIuoQ840zsW7njo/kBrzfR4h67Ryz ETIXi1kk1qylZ6pp0kSTVM9zHjwo+RUgIiCwee1K7ce5dUhsuIdzzPECl8yLrXiYLhgq /AC/8ohNifZbLls4CLJXVLoQqTO8ZRrJkuXVYBVDLk0VLsCARz5yN5RNn+W11p+yt6U6 1YmgYesSBWeufX6TJnagyohG3ZkPQ4gcjtBod4AoZ5lGh2irswtfv7maT/G0o/wvlf5X 7SYSc1g1IhMdFdwz7c7e/qYkGeQIuXuoAg4fhMrHVIXdhwUAX3qhe9Jj9Qaily4tmK6+ eSrA== X-Gm-Message-State: AOAM5330TTjy7CiBrDi+CpObNKm+8t992fwkFwXii0u02aOg4fcLC5T9 3V6ye0OdlaU0B4S8IhK6LVMqMw== X-Google-Smtp-Source: ABdhPJyjAU5MM8RYlzaVTzTp+k531UMo32vBtLZfrHF2F/Fa/86qHD2IEB/lqZdRvJWEI7taNPieGQ== X-Received: by 2002:a63:5004:0:b0:373:e921:c0ca with SMTP id e4-20020a635004000000b00373e921c0camr6311293pgb.154.1645798604161; Fri, 25 Feb 2022 06:16:44 -0800 (PST) Received: from [127.0.1.1] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id e7-20020aa78c47000000b004de8f900716sm3255717pfd.127.2022.02.25.06.16.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 06:16:43 -0800 (PST) From: Jens Axboe To: Ammar Faizi Cc: io-uring Mailing List , GNU/Weeb Mailing List , Tea Inside Mailing List , Alviro Iskandar Setiawan , Nugra In-Reply-To: <20220225005814.146492-1-ammarfaizi2@gnuweeb.org> References: <20220225005814.146492-1-ammarfaizi2@gnuweeb.org> Subject: Re: [PATCH liburing v2] queue, liburing.h: Avoid `io_uring_get_sqe()` code duplication Message-Id: <164579860316.5714.11586792942122127124.b4-ty@kernel.dk> Date: Fri, 25 Feb 2022 07:16:43 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit List-Id: On Fri, 25 Feb 2022 07:58:14 +0700, Ammar Faizi wrote: > Since commit 8be8af4afcb4909104c ("queue: provide io_uring_get_sqe() > symbol again"), we have the same definition of `io_uring_get_sqe()` in > queue.c and liburing.h. > > Make it simpler, maintain it in a single place, create a new static > inline function wrapper with name `_io_uring_get_sqe()`. Then tail > call both `io_uring_get_sqe()` functions to `_io_uring_get_sqe()`. > > [...] Applied, thanks! [1/1] queue, liburing.h: Avoid `io_uring_get_sqe()` code duplication commit: 15c01fcd1b0d37a12d945ab8dcdf96b3e055a4fd Best regards, -- Jens Axboe