* [PATCH liburing] test/helpers: Use a proper cast for `(struct sockaddr *)` argument
@ 2022-07-03 6:44 Ammar Faizi
2022-07-03 13:00 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Ammar Faizi @ 2022-07-03 6:44 UTC (permalink / raw)
To: Jens Axboe
Cc: Ammar Faizi, Dylan Yudaken, Facebook Kernel Team,
GNU/Weeb Mailing List, io-uring Mailing List
From: Ammar Faizi <[email protected]>
Sometimes the compiler accepts (struct sockaddr_in *) to be passed in
to (struct sockaddr *) without a cast. But not all compilers agree with
that. Building with clang 13.0.1 yields the following error:
error: incompatible pointer types passing 'struct sockaddr_in *' to \
parameter of type 'struct sockaddr *' [-Werror,-Wincompatible-pointer-types]
Explicitly cast the pointer to (struct sockaddr *) to avoid this error.
Cc: [email protected]
Cc: Dylan Yudaken <[email protected]>
Fixes: 9167905ca187064ba1d9ac4c8bb8484157bef86b ("add t_create_socket_pair")
Signed-off-by: Ammar Faizi <[email protected]>
---
test/helpers.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/test/helpers.c b/test/helpers.c
index 3660cc0..0146533 100644
--- a/test/helpers.c
+++ b/test/helpers.c
@@ -190,26 +190,28 @@ int t_create_socket_pair(int fd[2], bool stream)
goto errno_cleanup;
}
- if (getsockname(fd[0], &serv_addr, (socklen_t *)&paddrlen)) {
+ if (getsockname(fd[0], (struct sockaddr *)&serv_addr,
+ (socklen_t *)&paddrlen)) {
fprintf(stderr, "getsockname failed\n");
goto errno_cleanup;
}
inet_pton(AF_INET, "127.0.0.1", &serv_addr.sin_addr);
- if (connect(fd[1], &serv_addr, paddrlen)) {
+ if (connect(fd[1], (struct sockaddr *)&serv_addr, paddrlen)) {
fprintf(stderr, "connect failed\n");
goto errno_cleanup;
}
if (!stream) {
/* connect the other udp side */
- if (getsockname(fd[1], &serv_addr, (socklen_t *)&paddrlen)) {
+ if (getsockname(fd[1], (struct sockaddr *)&serv_addr,
+ (socklen_t *)&paddrlen)) {
fprintf(stderr, "getsockname failed\n");
goto errno_cleanup;
}
inet_pton(AF_INET, "127.0.0.1", &serv_addr.sin_addr);
- if (connect(fd[0], &serv_addr, paddrlen)) {
+ if (connect(fd[0], (struct sockaddr *)&serv_addr, paddrlen)) {
fprintf(stderr, "connect failed\n");
goto errno_cleanup;
}
base-commit: 98c14a04e2c0dcdfbb71372a1a209ed889fb3e4d
--
Ammar Faizi
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH liburing] test/helpers: Use a proper cast for `(struct sockaddr *)` argument
2022-07-03 6:44 [PATCH liburing] test/helpers: Use a proper cast for `(struct sockaddr *)` argument Ammar Faizi
@ 2022-07-03 13:00 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2022-07-03 13:00 UTC (permalink / raw)
To: ammarfaizi2; +Cc: io-uring, kernel-team, gwml, dylany
On Sun, 3 Jul 2022 13:44:05 +0700, Ammar Faizi wrote:
> From: Ammar Faizi <[email protected]>
>
> Sometimes the compiler accepts (struct sockaddr_in *) to be passed in
> to (struct sockaddr *) without a cast. But not all compilers agree with
> that. Building with clang 13.0.1 yields the following error:
>
> error: incompatible pointer types passing 'struct sockaddr_in *' to \
> parameter of type 'struct sockaddr *' [-Werror,-Wincompatible-pointer-types]
>
> [...]
Applied, thanks!
[1/1] test/helpers: Use a proper cast for `(struct sockaddr *)` argument
commit: 752c325dcde43be8d87f83b16d346beac5e1de2a
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-03 13:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-03 6:44 [PATCH liburing] test/helpers: Use a proper cast for `(struct sockaddr *)` argument Ammar Faizi
2022-07-03 13:00 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox