From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by gnuweeb.org (Postfix) with ESMTPS id C841C801E6 for ; Sun, 3 Jul 2022 13:00:21 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20210112.gappssmtp.com header.i=@kernel-dk.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=M/RsmaYL; dkim-atps=neutral Received: by mail-pl1-f174.google.com with SMTP id d5so6306043plo.12 for ; Sun, 03 Jul 2022 06:00:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=w30BfF1i/+5huQNwQxVcjTGXkb36F3GQzrctPfmsQZw=; b=M/RsmaYLDHnO3mfXtnw8JVNWRiaSCT7KzY5Te90lWaJ2LK40E3DrjgykYOPr3hFkHk sib1Yu54nc4H5vSTLa5Vxx/vTTK1vyxY6f5n5THu4f57PBdkcUyRcm3IkEqHA9mOdNEq vl6iaRRfwd5lfLgHyjK30E0bsVsRWLD8ELfLjf75SPGy1W5qCcGLNofCravOp864I/er E+ee4gtP36Ue2+kWuvzlO/01ArjRg3dDLDIdZfHI0AnJkNfaYW48i5GRcshPRmEi0nB2 kZSkcGg55SHnHplglgVVDr3l3AlsJTJ0MLkQLSD2NoI9Gr/bHgxSvvr50qIPQZo6oncK Zjdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=w30BfF1i/+5huQNwQxVcjTGXkb36F3GQzrctPfmsQZw=; b=kYYzft/g+I+Sx7hIb7cGisbHESWi0NsdF3wjJfAbYEkDM0mLZyJfgwSf0BWV0rQeIV plRUe3nYAPCdQVLVL2UVsufsMWXEjTlcJCEmjDzOXCHx6R0Gahh3OU7uD4L0MNflCE5d 45NRxc6RrI+BSE6gwxPppbOQ5xAbTpanrQtrZyqpfjxL7ZVTPGPuAZA14sZxwiREzRxB v2g4hXQCUcHF8Fllu3CJ9rPJnVJQoyJXU3ldsrkmlEGRgw36E70FnllyLbmuRjaCiNf4 J4nfijWZgSshV94+spoSwh95Tuxv98S9Q7Xeq3zpZpET1g5aGXFF3HFosfcTJL7La6Lm Ze/Q== X-Gm-Message-State: AJIora8ZmGewKjf2Td3UvdUy54FPBglQTfmWoZkEhsVhsUwNGg2VNV/l w9rsuHU3HqqfQ2pU0Qrge1t+Pw== X-Google-Smtp-Source: AGRyM1uyQxUCeczkw0ZBSA0rMLCewB01vsbGZrsEAtvatUkwjFVHm5235huT4dcFibd2iorGVhh9Ug== X-Received: by 2002:a17:902:e5c3:b0:16a:67e7:d999 with SMTP id u3-20020a170902e5c300b0016a67e7d999mr28954861plf.32.1656853221259; Sun, 03 Jul 2022 06:00:21 -0700 (PDT) Received: from [127.0.1.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id s26-20020a65645a000000b0040c755b7651sm18720654pgv.41.2022.07.03.06.00.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Jul 2022 06:00:20 -0700 (PDT) From: Jens Axboe To: ammarfaizi2@gnuweeb.org Cc: io-uring@vger.kernel.org, kernel-team@fb.com, gwml@vger.gnuweeb.org, dylany@fb.com In-Reply-To: <20220703063755.189175-1-ammar.faizi@intel.com> References: <20220703063755.189175-1-ammar.faizi@intel.com> Subject: Re: [PATCH liburing] test/helpers: Use a proper cast for `(struct sockaddr *)` argument Message-Id: <165685322035.1103909.10554403221181770675.b4-ty@kernel.dk> Date: Sun, 03 Jul 2022 07:00:20 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit List-Id: On Sun, 3 Jul 2022 13:44:05 +0700, Ammar Faizi wrote: > From: Ammar Faizi > > Sometimes the compiler accepts (struct sockaddr_in *) to be passed in > to (struct sockaddr *) without a cast. But not all compilers agree with > that. Building with clang 13.0.1 yields the following error: > > error: incompatible pointer types passing 'struct sockaddr_in *' to \ > parameter of type 'struct sockaddr *' [-Werror,-Wincompatible-pointer-types] > > [...] Applied, thanks! [1/1] test/helpers: Use a proper cast for `(struct sockaddr *)` argument commit: 752c325dcde43be8d87f83b16d346beac5e1de2a Best regards, -- Jens Axboe