From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by gnuweeb.org (Postfix) with ESMTPS id 6A38981593 for ; Mon, 28 Nov 2022 14:15:46 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20210112.gappssmtp.com header.i=@kernel-dk.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=bMPU2L8v; dkim-atps=neutral Received: by mail-pj1-f52.google.com with SMTP id k5so9595769pjo.5 for ; Mon, 28 Nov 2022 06:15:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HfUJYq7G47MzzTuau0KWiEvHR/P0v0C3Vt90Nu0s9w4=; b=bMPU2L8vsLHfGnSnuq+zbeiIr0GzsIaKO9dg1OTewlDKA50QM1ylIalbtux+MTiwvD kOHSKE/gHxEV1Mk0fxREwOJeDE0YRm9D7XgpYv7vezAup7ngX08A4uhuYRbcaYa/oOxx 1dqT1+dA7+PbjqUHUC2nH3PD1uLabsWVw92EjwsZ5Wx6NSaWVtIlGuEB0No36TbVx+m7 OCsrvehTR9mYfTZfIjGRbly2SMKC6mqRhgaj9j/dQt1rQKnXVsNOXS0pxTZNo5V07Rc2 RW2KemvFyAMermOywlDEgl/3M7Itt6Qfp0yQdgRfb+kN0JcIc/PfI2yNAsugyIsrlKRY YBUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HfUJYq7G47MzzTuau0KWiEvHR/P0v0C3Vt90Nu0s9w4=; b=um4xiC+PD1o39VJUmddNEkmI923MvzhmqsRcwPzJd+/w/j1qi884rmhjccUxe89RHt xMDpNxq9fkB4CaDy0HKWs6sFtzk+9UDp2qRV/HO3DGiex5LmC4nZYS4Vscq5/+WbXhGJ fiy0YbjyrgBOzKcwiq8ZuxIacEUXddvQ2LhVNE3EMdG3cZK67y7n4hHNAjUWhRusLQHo qBlc3TcE8XTGRxBReBj4rwJJcRY0hg6aFPe6X6Xp7eYt5PJzanSPPkaa1zLEvueg9SWw VBqPsdj0+vAyX5NS0hpSu7XVFuDfRuFAIf8z36F3RFEfqrKu7G3SWcyLb3z+PFie3Xes LsRA== X-Gm-Message-State: ANoB5pnASd+JXOUgomWONyRzxFdvhfzCewcau4B9ULn/7lHRq6Kb4043 wPX5Zs7xX/FOfKgHau5jjZhtag== X-Google-Smtp-Source: AA0mqf4RlfduB70qFQfkFKxWY27m/b1gGNmiA1/yu87ZLAAWgKKUfcAaK/s4FdnIWc3vhomHL7d34w== X-Received: by 2002:a17:902:e886:b0:185:4ec3:c703 with SMTP id w6-20020a170902e88600b001854ec3c703mr33291278plg.165.1669644945553; Mon, 28 Nov 2022 06:15:45 -0800 (PST) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id v2-20020a626102000000b005609d3d3008sm8331640pfb.171.2022.11.28.06.15.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 06:15:44 -0800 (PST) From: Jens Axboe To: Ammar Faizi Cc: Gilang Fachrezy , Pavel Begunkov , io-uring Mailing List , VNLX Kernel Department , Dylan Yudaken , GNU/Weeb Mailing List , Muhammad Rizki , Alviro Iskandar Setiawan In-Reply-To: <20221124162633.3856761-1-ammar.faizi@intel.com> References: <20221124162633.3856761-1-ammar.faizi@intel.com> Subject: Re: [PATCH liburing v2 0/8] Ensure we mark non-exported functions and variables as static Message-Id: <166964494429.5513.5606852896761842745.b4-ty@kernel.dk> Date: Mon, 28 Nov 2022 07:15:44 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.11.0-dev-28747 List-Id: On Thu, 24 Nov 2022 23:28:53 +0700, Ammar Faizi wrote: > From: Ammar Faizi > > Hi Jens, > > This is a v2 revision. > > This series is a -Wmissing-prototypes enforcement. -Wmissing-prototypes > is a clang C compiler flag that warns us if we have functions or > variables that are not used outisde the translation unit, but not marked > as static. > > [...] Applied, thanks! [1/8] queue: Fix typo "entererd" -> "entered" (no commit info) [2/8] queue: Mark `__io_uring_flush_sq()` as static (no commit info) [3/8] test/io_uring_setup: Remove unused functions (no commit info) [4/8] ucontext-cp: Remove an unused function (no commit info) [5/8] tests: Mark non-exported functions as static (no commit info) [6/8] ucontext-cp: Mark a non-exported function as static (no commit info) [7/8] test/Makefile: Omit `-Wmissing-prototypes` from the C++ compiler flags (no commit info) [8/8] github: Add `-Wmissing-prototypes` for GitHub CI bot (no commit info) Best regards, -- Jens Axboe