GNU/Weeb Mailing List <[email protected]>
 help / color / mirror / Atom feed
* [PATCH gwspamd v2 1/2] gwspamd: web: Add direct link for activity log
@ 2023-04-27 11:55 Memet Zx
  2023-04-27 11:55 ` [PATCH gwspamd v2 2/2] gwspamd: web: Add *.patch and *.diff to .gitignore Memet Zx
  2023-04-27 11:57 ` [PATCH gwspamd v2 1/2] gwspamd: web: Add direct link for activity log Ammar Faizi
  0 siblings, 2 replies; 4+ messages in thread
From: Memet Zx @ 2023-04-27 11:55 UTC (permalink / raw)
  To: Ammar Faizi; +Cc: Memet Zx, GNU/Weeb Mailing List, Memet Zx

Add a direct link from the log section on home to audit_log

Signed-off-by: Memet Zx <[email protected]>
---

v2:
	- Add a newline at end of file.
	- using verb 1 to describe the change.
---
 web/views/pages/audit_log.php | 4 ++--
 web/views/pages/home.php      | 3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/web/views/pages/audit_log.php b/web/views/pages/audit_log.php
index a330d45..b346969 100644
--- a/web/views/pages/audit_log.php
+++ b/web/views/pages/audit_log.php
@@ -42,9 +42,9 @@ $paginator = ob_get_clean();
 	</style>
 	<ol class="activity-feed">
 		<?php foreach ($st->fetchAll() as $row) : ?>
-			<li class="feed-item">
+			<li id="log-<?= e($row["id"]); ?>" class="feed-item">
 				<time class="date" datetime="<?= e($row["created_at"]); ?>"><?= e($row["created_at"]); ?></time>
-				<span class="text"><?= e($row["action"]); ?></span>
+				<span class="text">[<?= e($row["id"]); ?>] <?= e($row["action"]); ?></span>
 				<br>
 				<span class="text">
 					<?= build_extra_data($row["action"], $row["extra"]); ?>
diff --git a/web/views/pages/home.php b/web/views/pages/home.php
index b0d9824..2d0b671 100644
--- a/web/views/pages/home.php
+++ b/web/views/pages/home.php
@@ -129,9 +129,8 @@ ob_start();
                 <table class="table">
                     <?php foreach ($st->fetchAll() as $row) : ?>
                         <tr>
-                            <td><?= e($row["id"]); ?></td>
+                            <td><a href="audit_log.php#log-<?= e($row["id"]); ?>">#<?= e($row["id"]); ?></a></td>
                             <td><?= e($row["action"]); ?></td>
-                            <!-- <td align="left"><?= build_extra_data($row["action"], $row["extra"]); ?></td> -->
                             <td><?= e($row["created_at"]); ?></td>
                         </tr>
                     <?php endforeach; ?>

base-commit: 0039077f1e350a267a5c313d46b94a8545502f9b
-- 
Memet Zx


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH gwspamd v2 2/2] gwspamd: web: Add *.patch and *.diff to .gitignore
  2023-04-27 11:55 [PATCH gwspamd v2 1/2] gwspamd: web: Add direct link for activity log Memet Zx
@ 2023-04-27 11:55 ` Memet Zx
  2023-04-27 11:57 ` [PATCH gwspamd v2 1/2] gwspamd: web: Add direct link for activity log Ammar Faizi
  1 sibling, 0 replies; 4+ messages in thread
From: Memet Zx @ 2023-04-27 11:55 UTC (permalink / raw)
  To: Ammar Faizi; +Cc: Memet Zx, GNU/Weeb Mailing List, Memet Zx

Avoid patch and diff file being committed.

Signed-off-by: Memet Zx <[email protected]>
---
 web/.gitignore | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/web/.gitignore b/web/.gitignore
index 233aef8..6531cf5 100644
--- a/web/.gitignore
+++ b/web/.gitignore
@@ -1,2 +1,4 @@
 /config.php
 /gwspamd.sql.gz
+*.patch
+*.diff
-- 
Memet Zx


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH gwspamd v2 1/2] gwspamd: web: Add direct link for activity log
  2023-04-27 11:55 [PATCH gwspamd v2 1/2] gwspamd: web: Add direct link for activity log Memet Zx
  2023-04-27 11:55 ` [PATCH gwspamd v2 2/2] gwspamd: web: Add *.patch and *.diff to .gitignore Memet Zx
@ 2023-04-27 11:57 ` Ammar Faizi
  2023-04-27 11:58   ` Ammar Faizi
  1 sibling, 1 reply; 4+ messages in thread
From: Ammar Faizi @ 2023-04-27 11:57 UTC (permalink / raw)
  To: Memet Zx; +Cc: Ammar Faizi, Memet Zx, GNU/Weeb Mailing List

On Thu, 27 Apr 2023 18:55:25 +0700, Memet Zx wrote:
> Add a direct link from the log section on home to audit_log

Please use cover letter if you more than 1 patch next time.

Applied, thanks!

[1/2] gwspamd: web: Add direct link for activity log
      commit: 71f2002f76cacd20b3c9454bf293bde7df97a3a1
[2/2] gwspamd: web: Add *.patch and *.diff to .gitignore
      commit: 961deae39a099913ca8566e7fec8f3d3f9c4b5f2

Best regards,
-- 
Ammar Faizi


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH gwspamd v2 1/2] gwspamd: web: Add direct link for activity log
  2023-04-27 11:57 ` [PATCH gwspamd v2 1/2] gwspamd: web: Add direct link for activity log Ammar Faizi
@ 2023-04-27 11:58   ` Ammar Faizi
  0 siblings, 0 replies; 4+ messages in thread
From: Ammar Faizi @ 2023-04-27 11:58 UTC (permalink / raw)
  To: Memet Zx; +Cc: Memet Zx, GNU/Weeb Mailing List

On 4/27/23 6:57 PM, Ammar Faizi wrote:
> On Thu, 27 Apr 2023 18:55:25 +0700, Memet Zx wrote:
>> Add a direct link from the log section on home to audit_log
> 
> Please use cover letter if you more than 1 patch next time.

Please use a cover letter if you send more than 1 patch next time.

-- 
Ammar Faizi


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-04-27 11:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-27 11:55 [PATCH gwspamd v2 1/2] gwspamd: web: Add direct link for activity log Memet Zx
2023-04-27 11:55 ` [PATCH gwspamd v2 2/2] gwspamd: web: Add *.patch and *.diff to .gitignore Memet Zx
2023-04-27 11:57 ` [PATCH gwspamd v2 1/2] gwspamd: web: Add direct link for activity log Ammar Faizi
2023-04-27 11:58   ` Ammar Faizi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox