From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Subject: Re: [PATCH gwproxy v0] net: Fix convert_str_to_ssaddr
Date: Sat, 16 Aug 2025 22:28:18 +0700 [thread overview]
Message-ID: <175535807287.144427.2175292267911971357@gnuweeb.org> (raw)
In-Reply-To: <20250816103807.27781-1-reyuki@gnuweeb.org>
On Sat, 16 Aug 2025 17:38:02 +0700, Ahmad Gani wrote:
> The function returns EINVAL if the string contains both an address and a port,
> but also specifies a non-zero default port. This behavior is incorrect—
> if the string already includes a port, the default port should be ignored.
> The default port should only serve as a fallback when no port is specified
> in the string.
>
> And add header guard in net.h
>
> [...]
Applied, thanks!
[1/1] net: Fix convert_str_to_ssaddr
commit: 6c892ff947d8aba9c44055bfc605cc03087c3cee
Best regards,
--
Ammar Faizi
prev parent reply other threads:[~2025-08-16 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-16 10:38 [PATCH gwproxy v0] net: Fix convert_str_to_ssaddr Ahmad Gani
2025-08-16 15:28 ` Ammar Faizi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175535807287.144427.2175292267911971357@gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=alviro.iskandar@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
--cc=reyuki@gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox