From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_ZEN_BLOCKED_OPENDNS
	autolearn=ham autolearn_force=no version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1755358103;
	bh=C3U6Pl5Rfu4lhTTWdBD67hOOQoiemVgl0yS1OfI7B7w=;
	h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:
	 MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID:
	 Date:From:Reply-To:Subject:To:Cc:In-Reply-To:References:
	 Resent-Date:Resent-From:Resent-To:Resent-Cc:User-Agent:
	 Content-Type:Content-Transfer-Encoding;
	b=ifMAujiO6YZILrhFiY5ABgjUxPfcgjeSjGXUX5ljActw8KOpY3LwnaffwvrBIsOPK
	 lA8pm8+BooQrZ1mLnq9UO4eraLpl4hCFyHhKRcy+s34EsauFHR4+NqKpNQHSLbB2mW
	 /AdiBr4Yb2058EwKOrL8bKyLuDFpA8N6xwT7AY/wjprkILkmvQalBEU0uF8SFXTMe6
	 XVZ2ZSDce5OOOUuEHbTJ8ZdvU1HKYTcYdTus11YTAQTsqAD4ApYbO+/syhwhb/rJL/
	 e1zQl6irVYekeDMA1M7H6vIYIIrB5grAmGVLI4abHMKJOZl9z7edocVDToESg5w9aG
	 Wyr/XHe3BydNg==
Received: from integral2.. (unknown [103.216.223.55])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 173C731280CE;
	Sat, 16 Aug 2025 15:28:21 +0000 (UTC)
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
	Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Subject: Re: [PATCH gwproxy v0] net: Fix convert_str_to_ssaddr
Date: Sat, 16 Aug 2025 22:28:18 +0700
Message-Id: <175535807287.144427.2175292267911971357@gnuweeb.org>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20250816103807.27781-1-reyuki@gnuweeb.org>
References: <20250816103807.27781-1-reyuki@gnuweeb.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
List-Id: <gwml.vger.gnuweeb.org>

On Sat, 16 Aug 2025 17:38:02 +0700, Ahmad Gani wrote:
> The function returns EINVAL if the string contains both an address and a port,
> but also specifies a non-zero default port. This behavior is incorrect—
> if the string already includes a port, the default port should be ignored.
> The default port should only serve as a fallback when no port is specified
> in the string.
> 
> And add header guard in net.h
> 
> [...]

Applied, thanks!

[1/1] net: Fix convert_str_to_ssaddr
      commit: 6c892ff947d8aba9c44055bfc605cc03087c3cee

Best regards,
-- 
Ammar Faizi