[PATCH liburing] src/Makefile: Fix missing bpf_filter.h installation

[PATCH liburing] src/Makefile: Fix missing bpf_filter.h installation

[Ammar Faizi]

After a "make install" command, liburing.h fails to compile because
bpf_filter.h is not copied to the destination include directory:

    In file included from .github/workflows/test_build.c:1:
    /usr/include/liburing.h:21:10: fatal error: liburing/io_uring/bpf_filter.h: No such file or directory
    21 | #include "liburing/io_uring/bpf_filter.h"
        |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    compilation terminated.

Add the header to the Makefile's install list to satisfy the dependency.

Fixes: 46b5c4d66232dcadd0f46c875e6fabce3b3dea85 ("src/include/liburing.h: add bpf_filter.h header")
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---
 src/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/Makefile b/src/Makefile
index 7febcf3c223b..9f45e1999b09 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -108,6 +108,7 @@ install: $(all_targets)
 	install -D -m 644 include/liburing/barrier.h $(includedir)/liburing/barrier.h
 	install -D -m 644 include/liburing/io_uring_version.h $(includedir)/liburing/io_uring_version.h
 	install -D -m 644 include/liburing/io_uring/query.h $(includedir)/liburing/io_uring/query.h
+	install -D -m 644 include/liburing/io_uring/bpf_filter.h $(includedir)/liburing/io_uring/bpf_filter.h
 	install -D -m 644 liburing.a $(libdevdir)/liburing.a
 	install -D -m 644 liburing-ffi.a $(libdevdir)/liburing-ffi.a
 ifeq ($(ENABLE_SHARED),1)

base-commit: 9b7c673fecf8f6043dbc132cadbf5570769efd65
-- 
Ammar Faizi

Re: [PATCH liburing] src/Makefile: Fix missing bpf_filter.h installation

[Jens Axboe]

On Sat, 14 Feb 2026 04:05:48 +0700, Ammar Faizi wrote:
> After a "make install" command, liburing.h fails to compile because
> bpf_filter.h is not copied to the destination include directory:
> 
>     In file included from .github/workflows/test_build.c:1:
>     /usr/include/liburing.h:21:10: fatal error: liburing/io_uring/bpf_filter.h: No such file or directory
>     21 | #include "liburing/io_uring/bpf_filter.h"
>         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     compilation terminated.
> 
> [...]

Applied, thanks!

[1/1] src/Makefile: Fix missing bpf_filter.h installation
      commit: 364a7b561fa13cffdd7771978dc5509ec4d9d7f9

Best regards,
-- 
Jens Axboe

Re: [PATCH liburing] src/Makefile: Fix missing bpf_filter.h installation

[Jens Axboe]

On 2/13/26 2:07 PM, Jens Axboe wrote:
> 
> On Sat, 14 Feb 2026 04:05:48 +0700, Ammar Faizi wrote:
>> After a "make install" command, liburing.h fails to compile because
>> bpf_filter.h is not copied to the destination include directory:
>>
>>     In file included from .github/workflows/test_build.c:1:
>>     /usr/include/liburing.h:21:10: fatal error: liburing/io_uring/bpf_filter.h: No such file or directory
>>     21 | #include "liburing/io_uring/bpf_filter.h"
>>         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>     compilation terminated.
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] src/Makefile: Fix missing bpf_filter.h installation
>       commit: 364a7b561fa13cffdd7771978dc5509ec4d9d7f9

Thanks, I missed that!

BTW, for the future, for:

Fixes: 46b5c4d66232dcadd0f46c875e6fabce3b3dea85 ("src/include/liburing.h: add bpf_filter.h header")

shorten the sha to 12 chars, we don't need the full sha.

For your ~/.gitconfig:

[core]
	abbrev = 12
[pretty]
	fixes = Fixes: %h (\"%s\")
[alias]
	fixes = log -1 --format=fixes

and then you can just do:

axboe@m2max ~/gi/liburing (master)> git fixes 46b5c4d66232dcadd0f46c875e6fabce3b3dea85
Fixes: 46b5c4d66232 ("src/include/liburing.h: add bpf_filter.h header")

and it gives you the right format.

-- 
Jens Axboe

Re: [PATCH liburing] src/Makefile: Fix missing bpf_filter.h installation

[Ammar Faizi]

On Sat, Feb 14, 2026 at 4:10 AM Jens Axboe wrote:
> BTW, for the future, for:
>
> Fixes: 46b5c4d66232dcadd0f46c875e6fabce3b3dea85 ("src/include/liburing.h: add bpf_filter.h header")
>
> shorten the sha to 12 chars, we don't need the full sha.

I see, well noted, thanks for the reminder. Greg told me the same
thing, but I clearly let it slip through the cracks.

I've updated my .gitconfig now.

-- 
Ammar Faizi