Re: [PATCH] generic scraper: add chat scraper

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

Hi Alviro,

Thank you for your contribution to GNU/Weeb project, here is my code
review for your patch. Please address my request and I will merge your
patch to the main repo. I only see one problem with your patch.

> -static void run_scraper(Scraper *s, Main *main, DB *db)
> +void Scraper::runScrapers(void)
>  {
> -	auto st = db->prepare("SELECT eeee;");
> -	st->execute();
> -	if (auto row = st->fetch()) {
> -		int ft;
> -		char buffer[64];
> -		auto stmt = st->getStmt();
> -		size_t len = sizeof(buffer);
> -
> -		ft = mysqlx_get_bytes(row, 0, 0, buffer, &len);
> -		mysql_fetch_chk(ft, stmt);
> -		pr_notice("buf = %s (len = %zu)", buffer, len);
> -	}
> -	sleep(1);
> +	// auto st = db->prepare("SELECT eeee;");
> +	// st->execute();
> +	// if (auto row = st->fetch()) {
> +	// 	int ft;
> +	// 	char buffer[64];
> +	// 	auto stmt = st->getStmt();
> +	// 	size_t len = sizeof(buffer);
> +
> +	// 	ft = mysqlx_get_bytes(row, 0, 0, buffer, &len);
> +	// 	mysql_fetch_chk(ft, stmt);
> +	// 	pr_notice("buf = %s (len = %zu)", buffer, len);
> +	// }
> +	// sleep(1);
> +
> +	chatScraper_ = new tgvisd::Scrapers::ChatScraper(this);
> +
> +	std::thread chatScraper([this]{
> +		this->chatScraper_->run();
> +	});
> +	chatScraper.join();
>  }

Don't plug runScrapers() inside the class Scraper, this can be inlined
inside Scraper::run(). So please use static function without class.

Just that, the rest is fine to me.

Regards,
Ammar
-- 
GWML mailing list
GWML@gnuweeb.org
https://gwml.gnuweeb.org/listinfo/gwml