public inbox for gwml@vger.gnuweeb.org
 help / color / mirror / Atom feed
From: Ammar Faizi <ammarfaizi2@gmail.com>
To: GNU/Weeb Mailing List <gwml@gnuweeb.org>
Cc: Bayu Satiyo <itsyuukunz@gmail.com>, Ammar Faizi <ammarfaizi2@gmail.com>
Subject: [PATCH www.gnuweeb.org] bin/build: Fix broken production build script
Date: Thu, 23 Sep 2021 18:11:21 +0700	[thread overview]
Message-ID: <20210923111121.390965-2-ammarfaizi2@gmail.com> (raw)
In-Reply-To: <20210923111121.390965-1-ammarfaizi2@gmail.com>

Note that "dp:" means the `-p` option requires an argument. This does
not make any sense, because the production build script doesn't take
any argument at all.

Fix this by changing the "dp:" to "dp".

Extra fixes:
```
JEKYLL_ENV=production bundle exec jekyll build --config.yml
```
is a wrong command and won't run, the correct one should be:
```
JEKYLL_ENV=production bundle exec jekyll build --config _config.yml
```

Fixes: https://github.com/GNUWeeb/www.gnuweeb.org/pull/17
Fixes: 57c4aa9f53524ef13dbf124cb6694fd64d4b13d3 ("Completing basic configuration")
Cc: Bayu Satiyo <itsyuukunz@gmail.com>
Signed-off-by: Ammar Faizi <ammarfaizi2@gmail.com>
---
 bin/build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bin/build b/bin/build
index e64cc1e..8c420f5 100755
--- a/bin/build
+++ b/bin/build
@@ -27,13 +27,13 @@ DevBuild() {
 # Production Build function
 ProBuild() {
   echo "Building deployment ready site..."
-  JEKYLL_ENV=production bundle exec jekyll build --config.yml
+  JEKYLL_ENV=production bundle exec jekyll build --config _config.yml
   echo "Done. Now copy the contents of ./docs to your server."
   echo "If you're going to deploy it to GitHub Pages, simply pull this repo, set GitHub Pages at Settings tab > Pages and source to ./docs in Settings tab."
 }
 
 # Handling Options
-while getopts dp: options; do
+while getopts dp options; do
   case $options in
     d) # Invoke DevBuild
       DevBuild
-- 
2.30.2

-- 
GWML mailing list
GWML@gnuweeb.org
https://gwml.gnuweeb.org/listinfo/gwml

      reply	other threads:[~2021-09-23 11:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23 11:11 [PATCH www.gnuweeb.org] _config.yml: Fix build destination Ammar Faizi
2021-09-23 11:11 ` Ammar Faizi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210923111121.390965-2-ammarfaizi2@gmail.com \
    --to=ammarfaizi2@gmail.com \
    --cc=gwml@gnuweeb.org \
    --cc=itsyuukunz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox