* [ammarfaizi2-block:google/android/kernel/common/android12-5.4 4032/9999] drivers/dma-buf/heaps/system_heap.c:312:5-8: Unneeded variable: "ret". Return "0" on line 321
@ 2022-02-22 18:14 kernel test robot
2022-02-22 18:04 ` [PATCH] ANDROID: dma-buf: system_heap: fix returnvar.cocci warnings kernel test robot
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2022-02-22 18:14 UTC (permalink / raw)
To: John Stultz; +Cc: kbuild-all, GNU/Weeb Mailing List, linux-kernel
tree: https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android12-5.4
head: 0d36c5d6308623c56e2e94aff13e820cdd676bbf
commit: 44008f99d9ca0793e2562967e1da01fa74ee4a41 [4032/9999] ANDROID: dma-buf: system_heap: Add pagepool support to system heap
config: x86_64-randconfig-c022-20220221 (https://download.01.org/0day-ci/archive/20220223/[email protected]/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
cocci warnings: (new ones prefixed by >>)
>> drivers/dma-buf/heaps/system_heap.c:312:5-8: Unneeded variable: "ret". Return "0" on line 321
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] ANDROID: dma-buf: system_heap: fix returnvar.cocci warnings
2022-02-22 18:14 [ammarfaizi2-block:google/android/kernel/common/android12-5.4 4032/9999] drivers/dma-buf/heaps/system_heap.c:312:5-8: Unneeded variable: "ret". Return "0" on line 321 kernel test robot
@ 2022-02-22 18:04 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-02-22 18:04 UTC (permalink / raw)
To: John Stultz; +Cc: kbuild-all, GNU/Weeb Mailing List, linux-kernel
From: kernel test robot <[email protected]>
drivers/dma-buf/heaps/system_heap.c:312:5-8: Unneeded variable: "ret". Return "0" on line 321
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Reported-by: kernel test robot <[email protected]>
Signed-off-by: kernel test robot <[email protected]>
---
tree: https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android12-5.4
head: 0d36c5d6308623c56e2e94aff13e820cdd676bbf
commit: 44008f99d9ca0793e2562967e1da01fa74ee4a41 [4032/9999] ANDROID: dma-buf: system_heap: Add pagepool support to system heap
:::::: branch date: 6 hours ago
:::::: commit date: 1 year ago
drivers/dma-buf/heaps/system_heap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/dma-buf/heaps/system_heap.c
+++ b/drivers/dma-buf/heaps/system_heap.c
@@ -309,7 +309,6 @@ static int system_heap_zero_buffer(struc
struct sg_page_iter piter;
struct page *p;
void *vaddr;
- int ret = 0;
for_each_sgtable_page(sgt, &piter, 0) {
p = sg_page_iter_page(&piter);
@@ -318,7 +317,7 @@ static int system_heap_zero_buffer(struc
kunmap_atomic(vaddr);
}
- return ret;
+ return 0;
}
static void system_heap_dma_buf_release(struct dma_buf *dmabuf)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-22 18:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-22 18:14 [ammarfaizi2-block:google/android/kernel/common/android12-5.4 4032/9999] drivers/dma-buf/heaps/system_heap.c:312:5-8: Unneeded variable: "ret". Return "0" on line 321 kernel test robot
2022-02-22 18:04 ` [PATCH] ANDROID: dma-buf: system_heap: fix returnvar.cocci warnings kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox