public inbox for [email protected]
 help / color / mirror / Atom feed
From: Alviro Iskandar Setiawan <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Alviro Iskandar Setiawan <[email protected]>,
	Pavel Begunkov <[email protected]>,
	Ammar Faizi <[email protected]>,
	Alviro Iskandar Setiawan <[email protected]>,
	io-uring <[email protected]>, gwml <[email protected]>
Subject: [PATCH liburing v3 0/4] Changes for Makefile
Date: Thu, 10 Mar 2022 11:12:27 +0000	[thread overview]
Message-ID: <[email protected]> (raw)

Hello sir,

This patchset (v3) changes Makefile. 4 patches here:

1. Remove -fomit-frame-pointer flag, because it's already covered
   by the -O2 optimization flag.

2. When the header files are modified, the compiled objects are
   not going to be recompiled because the header files are not
   marked as a dependency for the objects.

  - Instruct the compiler to generate dependency files.

  - Include those files from src/Makefile. Ensure if any changes are
    made, files that depend on the changes are recompiled.

3. The test binaries statically link liburing using liburing.a file.
   When liburing.a is recompiled, make sure the tests are also
   recompiled to ensure changes are applied to the test binary. It
   makes "make clean" command optional when making changes.

4. Same as no. 3, but for examples.

please review,
thx

link v2: https://lore.kernel.org/io-uring/[email protected]/
v2 -> v3: 
  - Add dependency files to .gitignore.
  - Remove dependency files when running "make clean".

link v1: https://lore.kernel.org/io-uring/[email protected]/
v1 -> v2:
  - Instruct the compiler to generate dependency files instead
    of hard code it in the Makefile.
  - Add liburing.a to dependency for test (patch 3).
  - Add liburing.a to dependency for examples (patch 4).

Signed-off-by: Alviro Iskandar Setiawan <[email protected]>
---

Alviro Iskandar Setiawan (4):
  src/Makefile: Remove `-fomit-frame-pointer` from default build
  src/Makefile: Add header files as dependency
  test/Makefile: Add liburing.a as a dependency
  examples/Makefile: Add liburing.a as a dependency

 .gitignore        |  1 +
 examples/Makefile |  2 +-
 src/Makefile      | 15 +++++++--------
 test/Makefile     |  4 ++--
 4 files changed, 11 insertions(+), 11 deletions(-)


base-commit: 6231f56da7881bde6fb011e1b54d672f8fe5a224
-- 
2.25.1


             reply	other threads:[~2022-03-10 11:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 11:12 Alviro Iskandar Setiawan [this message]
2022-03-10 11:12 ` [PATCH liburing v3 1/4] src/Makefile: Remove `-fomit-frame-pointer` from default build Alviro Iskandar Setiawan
2022-03-10 11:12 ` [PATCH liburing v3 2/4] src/Makefile: Add header files as dependency Alviro Iskandar Setiawan
2022-03-10 11:12 ` [PATCH liburing v3 3/4] test/Makefile: Add liburing.a as a dependency Alviro Iskandar Setiawan
2022-03-10 11:12 ` [PATCH liburing v3 4/4] examples/Makefile: " Alviro Iskandar Setiawan
2022-03-10 11:40 ` [PATCH liburing v3 0/4] Changes for Makefile Ammar Faizi
2022-03-10 12:14 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220310111231.1713588-1-alviro.iskandar@gnuweeb.org \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox