From: Alviro Iskandar Setiawan <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Alviro Iskandar Setiawan <[email protected]>,
Pavel Begunkov <[email protected]>,
Ammar Faizi <[email protected]>,
Alviro Iskandar Setiawan <[email protected]>,
io-uring <[email protected]>, gwml <[email protected]>
Subject: [PATCH liburing v3 2/4] src/Makefile: Add header files as dependency
Date: Thu, 10 Mar 2022 11:12:29 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
When the header files are modified, the compiled objects are not going
to be recompiled because the header files are not marked as a dependency
for the objects.
- Instruct the compiler to generate dependency files.
- Include those files from src/Makefile. Ensure if any changes are
made, files that depend on the changes are recompiled.
Suggested-by: Ammar Faizi <[email protected]>
Signed-off-by: Alviro Iskandar Setiawan <[email protected]>
---
v2 -> v3:
- Add dependency files to .gitignore.
- Remove dependency files when running "make clean".
.gitignore | 1 +
src/Makefile | 13 ++++++-------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/.gitignore b/.gitignore
index c9dc77f..9b74880 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,6 +3,7 @@
*~
/*.patch
+*.d
*.o
*.o[ls]
diff --git a/src/Makefile b/src/Makefile
index f19d45e..0e04986 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -43,19 +43,20 @@ else
liburing_srcs += syscall.c
endif
+override CPPFLAGS += -MT "$@" -MMD -MP -MF "[email protected]"
liburing_objs := $(patsubst %.c,%.ol,$(liburing_srcs))
liburing_sobjs := $(patsubst %.c,%.os,$(liburing_srcs))
-$(liburing_srcs): syscall.h lib.h
-
-$(liburing_objs) $(liburing_sobjs): include/liburing/io_uring.h
-
%.os: %.c
$(QUIET_CC)$(CC) $(CPPFLAGS) $(SO_CFLAGS) -c -o $@ $<
%.ol: %.c
$(QUIET_CC)$(CC) $(CPPFLAGS) $(L_CFLAGS) -c -o $@ $<
+# Include compiler generated dependency files.
+-include $(liburing_objs:%=%.d)
+-include $(liburing_sobjs:%=%.d)
+
AR ?= ar
RANLIB ?= ranlib
liburing.a: $(liburing_objs)
@@ -78,11 +79,9 @@ ifeq ($(ENABLE_SHARED),1)
ln -sf $(relativelibdir)$(libname) $(libdevdir)/liburing.so
endif
-$(liburing_objs): include/liburing.h
-
clean:
@rm -f $(all_targets) $(liburing_objs) $(liburing_sobjs) $(soname).new
- @rm -f *.so* *.a *.o
+ @rm -f *.so* *.a *.o *.d
@rm -f include/liburing/compat.h
@# When cleaning, we don't include ../config-host.mak,
--
2.25.1
next prev parent reply other threads:[~2022-03-10 11:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 11:12 [PATCH liburing v3 0/4] Changes for Makefile Alviro Iskandar Setiawan
2022-03-10 11:12 ` [PATCH liburing v3 1/4] src/Makefile: Remove `-fomit-frame-pointer` from default build Alviro Iskandar Setiawan
2022-03-10 11:12 ` Alviro Iskandar Setiawan [this message]
2022-03-10 11:12 ` [PATCH liburing v3 3/4] test/Makefile: Add liburing.a as a dependency Alviro Iskandar Setiawan
2022-03-10 11:12 ` [PATCH liburing v3 4/4] examples/Makefile: " Alviro Iskandar Setiawan
2022-03-10 11:40 ` [PATCH liburing v3 0/4] Changes for Makefile Ammar Faizi
2022-03-10 12:14 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310111231.1713588-3-alviro.iskandar@gnuweeb.org \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox