From: Serge Semin <[email protected]>
To: Miaoqian Lin <[email protected]>
Cc: Serge Semin <[email protected]>,
Thomas Bogendoerfer <[email protected]>,
[email protected], [email protected]
Subject: Re: [PATCH] mips: cdmm: Fix refcount leak in mips_cdmm_phys_base
Date: Fri, 11 Mar 2022 17:29:26 +0300 [thread overview]
Message-ID: <20220311142926.czypl55ni6wpqpjm@mobilestation> (raw)
In-Reply-To: <[email protected]>
On Wed, Mar 09, 2022 at 09:17:10AM +0000, Miaoqian Lin wrote:
> The of_find_compatible_node() function returns a node pointer with
> refcount incremented, We should use of_node_put() on it when done
> Add the missing of_node_put() to release the refcount.
>
> Fixes: 2121aa3e2312 ("mips: cdmm: Add mti,mips-cdmm dtb node support")
Nice catch. Thanks.
Acked-by: Serge Semin <[email protected]>
> Signed-off-by: Miaoqian Lin <[email protected]>
> ---
> drivers/bus/mips_cdmm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/mips_cdmm.c b/drivers/bus/mips_cdmm.c
> index 626dedd110cb..fca0d0669aa9 100644
> --- a/drivers/bus/mips_cdmm.c
> +++ b/drivers/bus/mips_cdmm.c
> @@ -351,6 +351,7 @@ phys_addr_t __weak mips_cdmm_phys_base(void)
> np = of_find_compatible_node(NULL, NULL, "mti,mips-cdmm");
> if (np) {
> err = of_address_to_resource(np, 0, &res);
> + of_node_put(np);
> if (!err)
> return res.start;
> }
> --
> 2.17.1
>
prev parent reply other threads:[~2022-03-11 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 9:17 [PATCH] mips: cdmm: Fix refcount leak in mips_cdmm_phys_base Miaoqian Lin
2022-03-11 14:29 ` Serge Semin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220311142926.czypl55ni6wpqpjm@mobilestation \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox