From: Alviro Iskandar Setiawan <[email protected]>
To: Mark Brown <[email protected]>
Cc: Alviro Iskandar Setiawan <[email protected]>,
Alviro Iskandar Setiawan <[email protected]>,
Codrin Ciubotariu <[email protected]>,
GNU/Weeb Mailing List <[email protected]>,
[email protected], kernel test robot <[email protected]>,
Linux Kernel Mailing List <[email protected]>,
[email protected], Nugraha <[email protected]>,
Nathan Chancellor <[email protected]>
Subject: [PATCH for-5.18 v2] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning
Date: Tue, 15 Mar 2022 00:18:48 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
In function mchp_pdmc_af_put(), Intel's kernel test robot reports the
following warning:
sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array \
'uvalue->value.integer.value' will always evaluate to 'true' \
[-Wpointer-bool-conversion]
This is because we are using `uvalue->value.integer.value` which its
type is `long value[128];` for conditional expression and that array
will always decay to a non-NULL pointer. Using a non-NULL pointer for
conditional expression will always evaluate to true.
Fix this by changing it to `uvalue->value.integer.value[0]` as that's
what the mchp_pdmc_af_get() function sets.
Cc: Nugraha <[email protected]>
Reported-by: kernel test robot <[email protected]>
Link: https://lore.kernel.org/lkml/[email protected]
Fixes: 50291652af52 ("ASoC: atmel: mchp-pdmc: add PDMC driver")
Link: https://lore.gnuweeb.org/gwml/[email protected] # v1
Reviewed-by: Codrin Ciubotariu <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Signed-off-by: Alviro Iskandar Setiawan <[email protected]>
---
v1 -> v2:
- Remove mailing list from the CC tags.
- Append reviewed by tags from Nathan and Codrin.
sound/soc/atmel/mchp-pdmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c
index c44636f6207d..7b87f75c284c 100644
--- a/sound/soc/atmel/mchp-pdmc.c
+++ b/sound/soc/atmel/mchp-pdmc.c
@@ -183,7 +183,7 @@ static int mchp_pdmc_af_put(struct snd_kcontrol *kcontrol,
{
struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
struct mchp_pdmc *dd = snd_soc_component_get_drvdata(component);
- bool af = uvalue->value.integer.value ? true : false;
+ bool af = uvalue->value.integer.value[0] ? true : false;
if (dd->audio_filter_en == af)
return 0;
base-commit: 50291652af5269813baa6024eb0e81b5f0bbb451
--
2.27.0
next reply other threads:[~2022-03-15 0:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 0:18 Alviro Iskandar Setiawan [this message]
2022-03-15 13:40 ` [PATCH for-5.18 v2] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220315001848.3763534-1-alviro.iskandar@gnuweeb.org \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox