From: Ammar Faizi <[email protected]>
To: Willy Tarreau <[email protected]>
Cc: "Paul E. McKenney" <[email protected]>,
Alviro Iskandar Setiawan <[email protected]>,
Nugraha <[email protected]>,
Linux Kernel Mailing List <[email protected]>,
GNU/Weeb Mailing List <[email protected]>,
Ammar Faizi <[email protected]>,
[email protected]
Subject: [RFC PATCH v1 2/6] tools/nolibc: Make the entry point not weak for clang
Date: Sun, 20 Mar 2022 16:37:46 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
Budilig with clang yields the following error:
```
<inline asm>:3:1: error: _start changed binding to STB_GLOBAL
.global _start
^
1 error generated.
```
Don't make the entry point weak if we're compiling with clang.
Cc: [email protected]
Signed-off-by: Ammar Faizi <[email protected]>
---
tools/include/nolibc/arch-aarch64.h | 2 ++
tools/include/nolibc/arch-arm.h | 2 ++
tools/include/nolibc/arch-i386.h | 2 ++
tools/include/nolibc/arch-mips.h | 2 ++
tools/include/nolibc/arch-riscv.h | 2 ++
tools/include/nolibc/arch-x86_64.h | 2 ++
6 files changed, 12 insertions(+)
diff --git a/tools/include/nolibc/arch-aarch64.h b/tools/include/nolibc/arch-aarch64.h
index 87d9e434820c..5084cd58b429 100644
--- a/tools/include/nolibc/arch-aarch64.h
+++ b/tools/include/nolibc/arch-aarch64.h
@@ -183,7 +183,9 @@ struct sys_stat_struct {
/* startup code */
asm(".section .text\n"
+#if !defined(__clang__)
".weak _start\n"
+#endif
".global _start\n"
"_start:\n"
"ldr x0, [sp]\n" // argc (x0) was in the stack
diff --git a/tools/include/nolibc/arch-arm.h b/tools/include/nolibc/arch-arm.h
index 001a3c8c9ad5..b3f135a615a6 100644
--- a/tools/include/nolibc/arch-arm.h
+++ b/tools/include/nolibc/arch-arm.h
@@ -176,7 +176,9 @@ struct sys_stat_struct {
/* startup code */
asm(".section .text\n"
+#if !defined(__clang__)
".weak _start\n"
+#endif
".global _start\n"
"_start:\n"
#if defined(__THUMBEB__) || defined(__THUMBEL__)
diff --git a/tools/include/nolibc/arch-i386.h b/tools/include/nolibc/arch-i386.h
index d7e4d53325a3..82bf797849ae 100644
--- a/tools/include/nolibc/arch-i386.h
+++ b/tools/include/nolibc/arch-i386.h
@@ -175,7 +175,9 @@ struct sys_stat_struct {
*
*/
asm(".section .text\n"
+#if !defined(__clang__)
".weak _start\n"
+#endif
".global _start\n"
"_start:\n"
"pop %eax\n" // argc (first arg, %eax)
diff --git a/tools/include/nolibc/arch-mips.h b/tools/include/nolibc/arch-mips.h
index c9a6aac87c6d..719d3808614d 100644
--- a/tools/include/nolibc/arch-mips.h
+++ b/tools/include/nolibc/arch-mips.h
@@ -190,7 +190,9 @@ struct sys_stat_struct {
/* startup code, note that it's called __start on MIPS */
asm(".section .text\n"
+#if !defined(__clang__)
".weak __start\n"
+#endif
".set nomips16\n"
".global __start\n"
".set noreorder\n"
diff --git a/tools/include/nolibc/arch-riscv.h b/tools/include/nolibc/arch-riscv.h
index bc10b7b5706d..a9704affd7de 100644
--- a/tools/include/nolibc/arch-riscv.h
+++ b/tools/include/nolibc/arch-riscv.h
@@ -184,7 +184,9 @@ struct sys_stat_struct {
/* startup code */
asm(".section .text\n"
+#if !defined(__clang__)
".weak _start\n"
+#endif
".global _start\n"
"_start:\n"
".option push\n"
diff --git a/tools/include/nolibc/arch-x86_64.h b/tools/include/nolibc/arch-x86_64.h
index a7b70ea51b68..f453f1a05a48 100644
--- a/tools/include/nolibc/arch-x86_64.h
+++ b/tools/include/nolibc/arch-x86_64.h
@@ -198,7 +198,9 @@ struct sys_stat_struct {
*
*/
asm(".section .text\n"
+#if !defined(__clang__)
".weak _start\n"
+#endif
".global _start\n"
"_start:\n"
"pop %rdi\n" // argc (first arg, %rdi)
--
Ammar Faizi
next prev parent reply other threads:[~2022-03-20 9:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 9:37 [RFC PATCH v1 0/6] Add dynamic memory allocator support for nolibc Ammar Faizi
2022-03-20 9:37 ` [RFC PATCH v1 1/6] tools/nolibc: x86-64: Update System V ABI document link Ammar Faizi
2022-03-20 9:37 ` Ammar Faizi [this message]
2022-03-20 19:16 ` [RFC PATCH v1 2/6] tools/nolibc: Make the entry point not weak for clang Willy Tarreau
2022-03-21 11:38 ` Ammar Faizi
2022-03-21 17:27 ` Nick Desaulniers
2022-03-20 9:37 ` [RFC PATCH v1 3/6] tools/nolibc: i386: Implement syscall with 6 arguments Ammar Faizi
2022-03-20 10:33 ` Alviro Iskandar Setiawan
2022-03-20 10:42 ` Alviro Iskandar Setiawan
2022-03-20 15:09 ` Ammar Faizi
2022-03-20 13:10 ` David Laight
2022-03-20 14:01 ` Willy Tarreau
2022-03-20 15:04 ` Ammar Faizi
2022-03-20 18:22 ` David Laight
2022-03-20 9:37 ` [RFC PATCH v1 4/6] tools/nolibc/sys: Implement `mmap()` and `munmap()` Ammar Faizi
2022-03-20 9:37 ` [RFC PATCH v1 5/6] tools/nolibc/stdlib: Implement `malloc()`, `calloc()`, `realloc()` and `free()` Ammar Faizi
2022-03-20 15:50 ` Alviro Iskandar Setiawan
2022-03-20 16:10 ` Ammar Faizi
2022-03-20 16:16 ` Willy Tarreau
2022-03-20 16:36 ` Ammar Faizi
2022-03-20 16:46 ` Willy Tarreau
2022-03-20 9:37 ` [RFC PATCH v1 6/6] tools/include/string: Implement `strdup()` and `strndup()` Ammar Faizi
2022-03-20 15:55 ` Alviro Iskandar Setiawan
2022-03-20 16:10 ` Ammar Faizi
2022-03-21 7:53 ` Willy Tarreau
2022-03-21 8:16 ` Alviro Iskandar Setiawan
2022-03-21 8:51 ` Willy Tarreau
2022-03-21 11:36 ` Ammar Faizi
2022-03-21 11:43 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox