From: Ammar Faizi <[email protected]>
To: Willy Tarreau <[email protected]>
Cc: "Paul E. McKenney" <[email protected]>,
Alviro Iskandar Setiawan <[email protected]>,
Nugraha <[email protected]>,
Linux Kernel Mailing List <[email protected]>,
GNU/Weeb Mailing List <[email protected]>,
Ammar Faizi <[email protected]>,
[email protected], [email protected]
Subject: [RFC PATCH v1 3/6] tools/nolibc: i386: Implement syscall with 6 arguments
Date: Sun, 20 Mar 2022 16:37:47 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
In i386, the 6th argument of syscall goes in %ebp. However, both Clang
and GCC cannot use %ebp in the clobber list and in the "r" constraint
without using -fomit-frame-pointer. To make it always available for any
kind of compilation, the below workaround is implemented.
For clang (the Assembly statement can't clobber %ebp):
1) Save the %ebp value to the redzone area -4(%esp).
2) Load the 6-th argument from memory to %ebp.
3) Subtract the %esp by 4.
4) Do the syscall (int $0x80).
5) Pop %ebp.
For GCC, fortunately it has a #pragma that can force a specific function
to be compiled with -fomit-frame-pointer, so it can always use "r"(var)
where `var` is a variable bound to %ebp.
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Ammar Faizi <[email protected]>
---
tools/include/nolibc/arch-i386.h | 64 ++++++++++++++++++++++++++++++++
1 file changed, 64 insertions(+)
diff --git a/tools/include/nolibc/arch-i386.h b/tools/include/nolibc/arch-i386.h
index 82bf797849ae..10de54d4b4d6 100644
--- a/tools/include/nolibc/arch-i386.h
+++ b/tools/include/nolibc/arch-i386.h
@@ -167,6 +167,70 @@ struct sys_stat_struct {
_ret; \
})
+
+/*
+ * Both Clang and GCC cannot use %ebp in the clobber list and in the "r"
+ * constraint without using -fomit-frame-pointer. To make it always
+ * available for any kind of compilation, the below workaround is
+ * implemented.
+ *
+ * For clang (the Assembly statement can't clobber %ebp):
+ * 1) Save the %ebp value to the redzone area -4(%esp).
+ * 2) Load the 6-th argument from memory to %ebp.
+ * 3) Subtract the %esp by 4.
+ * 4) Do the syscall (int $0x80).
+ * 5) Pop %ebp.
+ *
+ * For GCC, fortunately it has a #pragma that can force a specific function
+ * to be compiled with -fomit-frame-pointer, so it can use "r"(var) where
+ * var is a variable bound to %ebp.
+ *
+ */
+#if defined(__clang__)
+static inline long ____do_syscall6(long eax, long ebx, long ecx, long edx,
+ long esi, long edi, long ebp)
+{
+ __asm__ volatile (
+ "movl %%ebp, -4(%%esp)\n\t"
+ "movl %[arg6], %%ebp\n\t"
+ "subl $4, %%esp\n\t"
+ "int $0x80\n\t"
+ "popl %%ebp\n\t"
+ : "=a"(eax)
+ : "a"(eax), "b"(ebx), "c"(ecx), "d"(edx), "S"(esi), "D"(edi),
+ [arg6]"m"(ebp)
+ : "memory", "cc"
+ );
+ return eax;
+}
+
+#else /* #if defined(__clang__) */
+#pragma GCC push_options
+#pragma GCC optimize "-fomit-frame-pointer"
+static inline long ____do_syscall6(long eax, long ebx, long ecx, long edx,
+ long esi, long edi, long ebp)
+{
+ register long __ebp __asm__("ebp") = ebp;
+ __asm__ volatile (
+ "int $0x80"
+ : "=a"(eax)
+ : "a"(eax), "b"(ebx), "c"(ecx), "d"(edx), "S"(esi), "D"(edi),
+ "r"(__ebp)
+ : "memory", "cc"
+ );
+ return eax;
+}
+#pragma GCC pop_options
+#endif /* #if defined(__clang__) */
+
+#define my_syscall6(num, arg1, arg2, arg3, arg4, arg5, arg6) ( \
+ ____do_syscall6((long)(num), (long)(arg1), \
+ (long)(arg2), (long)(arg3), \
+ (long)(arg4), (long)(arg5), \
+ (long)(arg6)) \
+)
+
+
/* startup code */
/*
* i386 System V ABI mandates:
--
Ammar Faizi
next prev parent reply other threads:[~2022-03-20 9:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 9:37 [RFC PATCH v1 0/6] Add dynamic memory allocator support for nolibc Ammar Faizi
2022-03-20 9:37 ` [RFC PATCH v1 1/6] tools/nolibc: x86-64: Update System V ABI document link Ammar Faizi
2022-03-20 9:37 ` [RFC PATCH v1 2/6] tools/nolibc: Make the entry point not weak for clang Ammar Faizi
2022-03-20 19:16 ` Willy Tarreau
2022-03-21 11:38 ` Ammar Faizi
2022-03-21 17:27 ` Nick Desaulniers
2022-03-20 9:37 ` Ammar Faizi [this message]
2022-03-20 10:33 ` [RFC PATCH v1 3/6] tools/nolibc: i386: Implement syscall with 6 arguments Alviro Iskandar Setiawan
2022-03-20 10:42 ` Alviro Iskandar Setiawan
2022-03-20 15:09 ` Ammar Faizi
2022-03-20 13:10 ` David Laight
2022-03-20 14:01 ` Willy Tarreau
2022-03-20 15:04 ` Ammar Faizi
2022-03-20 18:22 ` David Laight
2022-03-20 9:37 ` [RFC PATCH v1 4/6] tools/nolibc/sys: Implement `mmap()` and `munmap()` Ammar Faizi
2022-03-20 9:37 ` [RFC PATCH v1 5/6] tools/nolibc/stdlib: Implement `malloc()`, `calloc()`, `realloc()` and `free()` Ammar Faizi
2022-03-20 15:50 ` Alviro Iskandar Setiawan
2022-03-20 16:10 ` Ammar Faizi
2022-03-20 16:16 ` Willy Tarreau
2022-03-20 16:36 ` Ammar Faizi
2022-03-20 16:46 ` Willy Tarreau
2022-03-20 9:37 ` [RFC PATCH v1 6/6] tools/include/string: Implement `strdup()` and `strndup()` Ammar Faizi
2022-03-20 15:55 ` Alviro Iskandar Setiawan
2022-03-20 16:10 ` Ammar Faizi
2022-03-21 7:53 ` Willy Tarreau
2022-03-21 8:16 ` Alviro Iskandar Setiawan
2022-03-21 8:51 ` Willy Tarreau
2022-03-21 11:36 ` Ammar Faizi
2022-03-21 11:43 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox