From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from integral2.. (unknown [182.2.69.158]) by gnuweeb.org (Postfix) with ESMTPSA id EF33E7E343; Tue, 22 Mar 2022 10:22:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1647944523; bh=vWuQhpoAXiBJj3wfUX35L7A8raKBOQqVL60x1T1gmI8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cpwcf9F07dn3br1s8e47fpUodg+PtsS/O7sdpWg5xam/tebk5YqqseF4WV9nLvrLx R0f/cjcT6EqBf5GPINaxgDQ9GE+xhkinW9uEsebfZBKILuMtZB0nHnQrLrmm0l9GQS EZtTy9oxqFrpZrJT9NF9LEfShN1WJ8ljl8Iuwa62dQDP3TszQm5Q9DkcC4CiTXY2dN FjdvNr+FsnUlWPJDnOnxWUisClxdqu+PB89BpDiAO8UfcfN+ZzLUgC6eDr3W1mJfUV Xg+2LqxbmcNrxI1+Rk9bWUZk9om8jBNWbzTz6enf9EGZgaVIp89NxTMcV08rclNRoI TrWTRN2LMdHzA== From: Ammar Faizi To: Willy Tarreau Cc: "Paul E. McKenney" , Alviro Iskandar Setiawan , Nugraha , Linux Kernel Mailing List , GNU/Weeb Mailing List , Ammar Faizi Subject: [RFC PATCH v2 8/8] tools/include/string: Implement `strdup()` and `strndup()` Date: Tue, 22 Mar 2022 17:21:15 +0700 Message-Id: <20220322102115.186179-9-ammarfaizi2@gnuweeb.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220322102115.186179-1-ammarfaizi2@gnuweeb.org> References: <20220322102115.186179-1-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: These functions are currently only available on architectures that have my_syscall6() macro implemented. Since these functions use malloc(), malloc() uses mmap(), mmap() depends on my_syscall6() macro. On architectures that don't support my_syscall6(), these function will always return NULL with errno set to ENOSYS. Signed-off-by: Ammar Faizi --- @@ Changelog: Link RFC v1: https://lore.kernel.org/lkml/20220320093750.159991-7-ammarfaizi2@gnuweeb.org/ RFC v1 -> RFC v2: - Update strdup and strndup implementation, use strlen and strnlen to get the string length first (comment from Willy and Alviro). - Fix the subject line prefix, it was "tools/include/string: ", it should be "tools/nolibc/string: ". - Update the commit message. --- tools/include/nolibc/string.h | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/tools/include/nolibc/string.h b/tools/include/nolibc/string.h index 1426eefc1ef2..bcc76f89199e 100644 --- a/tools/include/nolibc/string.h +++ b/tools/include/nolibc/string.h @@ -9,6 +9,8 @@ #include "std.h" +static void *malloc(size_t len); + /* * As much as possible, please keep functions alphabetically sorted. */ @@ -147,6 +149,36 @@ size_t strnlen(const char *str, size_t maxlen) return len; } +static __attribute__((unused)) +char *strdup(const char *str) +{ + size_t len; + char *ret; + + len = strlen(str); + ret = malloc(len + 1); + if (__builtin_expect(ret != NULL, 1)) + memcpy(ret, str, len + 1); + + return ret; +} + +static __attribute__((unused)) +char *strndup(const char *str, size_t maxlen) +{ + size_t len; + char *ret; + + len = strnlen(str, maxlen); + ret = malloc(len + 1); + if (__builtin_expect(ret != NULL, 1)) { + memcpy(ret, str, len); + ret[len] = '\0'; + } + + return ret; +} + static __attribute__((unused)) size_t strlcat(char *dst, const char *src, size_t size) { -- Ammar Faizi