From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gnuweeb.org (Postfix) with ESMTPS id C41BB7E347 for ; Wed, 23 Mar 2022 01:36:39 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=IlRw23pq; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647999399; x=1679535399; h=date:from:to:cc:subject:message-id:mime-version; bh=cQpekluwhCWc9KzNGMvCnwOeeeIoAMB+K1ml90maMxo=; b=IlRw23pquAiePn6yC4oiogxh8RAXrTEya6gthqtkpR8YWm6x8C7+2E+i V4n+4fatuY38euiMhyrXwBlld96+26LuC6i8vKBzPthyMAMDv6B2qchZY tw0x4RwEORkUIEqZGKvgBgvJVLor39JttM6LsAsE8WLdvSaedQpf8PYRj X+QOBhhAW050b9JgDoMi6hoa7iNVps4EpsTV0hDIi05u8vX+u99HQrw+D pAXzkywQPZ7klJfCtxGUvyBXY2QXCQlht2yf9nychOPIdKorbvzSWFhou sKwiqodIW/hUK7q373WKWUJZsNUN/7aknndSjhnJTEWYv3xL2pQNwCnSM A==; X-IronPort-AV: E=McAfee;i="6200,9189,10294"; a="240158293" X-IronPort-AV: E=Sophos;i="5.90,203,1643702400"; d="scan'208";a="240158293" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2022 18:36:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,203,1643702400"; d="scan'208";a="519159730" Received: from lkp-server02.sh.intel.com (HELO 89b41b6ae01c) ([10.239.97.151]) by orsmga006.jf.intel.com with ESMTP; 22 Mar 2022 18:36:37 -0700 Received: from kbuild by 89b41b6ae01c with local (Exim 4.92) (envelope-from ) id 1nWpvQ-000JV8-NJ; Wed, 23 Mar 2022 01:36:36 +0000 Date: Wed, 23 Mar 2022 09:35:52 +0800 From: kernel test robot To: Colin Downs-Razouk Cc: kbuild-all@lists.01.org, GNU/Weeb Mailing List , linux-kernel@vger.kernel.org, Chris Morin Subject: [ammarfaizi2-block:google/android/kernel/common/android12-kiwi-5.10 9930/9999] drivers/virtio/virtio_pvclock.c:49:6: warning: no previous prototype for 'update_suspend_time' Message-ID: <202203230942.D777cOW6-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: Hi Colin, FYI, the error/warning still remains. tree: https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android12-kiwi-5.10 head: 37d518ce65952e985a207fcb558e16e3288cd139 commit: 029865ac9555743665dd106b4bbefb2f371849e9 [9930/9999] ANDROID: virtio: virtio_pvclock: initial driver impl config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220323/202203230942.D777cOW6-lkp@intel.com/config) compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0 reproduce (this is a W=1 build): # https://github.com/ammarfaizi2/linux-block/commit/029865ac9555743665dd106b4bbefb2f371849e9 git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block git fetch --no-tags ammarfaizi2-block google/android/kernel/common/android12-kiwi-5.10 git checkout 029865ac9555743665dd106b4bbefb2f371849e9 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/virtio/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/virtio/virtio_pvclock.c:49:6: warning: no previous prototype for 'update_suspend_time' [-Wmissing-prototypes] 49 | void update_suspend_time(struct work_struct *work) | ^~~~~~~~~~~~~~~~~~~ drivers/virtio/virtio_pvclock.c: In function 'virtpvclock_validate': >> drivers/virtio/virtio_pvclock.c:295:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 295 | uint32_t rating = | ^~~~~~~~ vim +/update_suspend_time +49 drivers/virtio/virtio_pvclock.c 48 > 49 void update_suspend_time(struct work_struct *work) 50 { 51 u64 suspend_ns, suspend_time_delta = 0; 52 struct timespec64 inject_time; 53 struct virtio_pvclock *vp; 54 55 vp = container_of(work, struct virtio_pvclock, 56 update_suspend_time_work); 57 58 virtio_cread(vp->vdev, struct virtio_pvclock_config, suspend_time_ns, 59 &suspend_ns); 60 61 mutex_lock(&vp->inject_suspend_lock); 62 if (suspend_ns > vp->injected_suspend_ns) { 63 suspend_time_delta = suspend_ns - vp->injected_suspend_ns; 64 vp->injected_suspend_ns = suspend_ns; 65 } 66 mutex_unlock(&vp->inject_suspend_lock); 67 68 if (suspend_time_delta == 0) { 69 dev_err(&vp->vdev->dev, 70 "%s: suspend_time_ns is less than injected_suspend_ns\n", 71 __func__); 72 return; 73 } 74 75 inject_time = ns_to_timespec64(suspend_time_delta); 76 77 timekeeping_inject_sleeptime64(&inject_time); 78 79 dev_info(&vp->vdev->dev, "injected sleeptime: %llu ns\n", 80 suspend_time_delta); 81 } 82 -- 0-DAY CI Kernel Test Service https://01.org/lkp