From: kernel test robot <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], [email protected],
GNU/Weeb Mailing List <[email protected]>,
[email protected]
Subject: [ammarfaizi2-block:axboe/linux-block/sock-nolock 6/6] fs/io_uring.c:8999:2: error: implicit declaration of function 'io_sock_nolock_clear' is invalid in C99
Date: Tue, 29 Mar 2022 07:42:51 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
tree: https://github.com/ammarfaizi2/linux-block axboe/linux-block/sock-nolock
head: 90b2144118aabeddabb82f22e07b87da068c54cd
commit: 90b2144118aabeddabb82f22e07b87da068c54cd [6/6] io_uring: mark accept direct socket as no-lock
config: hexagon-randconfig-r041-20220328 (https://download.01.org/0day-ci/archive/20220329/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0f6d9501cf49ce02937099350d08f20c4af86f3d)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/ammarfaizi2/linux-block/commit/90b2144118aabeddabb82f22e07b87da068c54cd
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block axboe/linux-block/sock-nolock
git checkout 90b2144118aabeddabb82f22e07b87da068c54cd
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
>> fs/io_uring.c:8999:2: error: implicit declaration of function 'io_sock_nolock_clear' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
io_sock_nolock_clear(file);
^
1 error generated.
vim +/io_sock_nolock_clear +8999 fs/io_uring.c
8938
8939 static void io_rsrc_file_put(struct io_ring_ctx *ctx, struct io_rsrc_put *prsrc)
8940 {
8941 struct file *file = prsrc->file;
8942 #if defined(CONFIG_UNIX)
8943 struct sock *sock = ctx->ring_sock->sk;
8944 struct sk_buff_head list, *head = &sock->sk_receive_queue;
8945 struct sk_buff *skb;
8946 int i;
8947
8948 __skb_queue_head_init(&list);
8949
8950 /*
8951 * Find the skb that holds this file in its SCM_RIGHTS. When found,
8952 * remove this entry and rearrange the file array.
8953 */
8954 skb = skb_dequeue(head);
8955 while (skb) {
8956 struct scm_fp_list *fp;
8957
8958 fp = UNIXCB(skb).fp;
8959 for (i = 0; i < fp->count; i++) {
8960 int left;
8961
8962 if (fp->fp[i] != file)
8963 continue;
8964
8965 unix_notinflight(fp->user, fp->fp[i]);
8966 left = fp->count - 1 - i;
8967 if (left) {
8968 memmove(&fp->fp[i], &fp->fp[i + 1],
8969 left * sizeof(struct file *));
8970 }
8971 fp->count--;
8972 if (!fp->count) {
8973 kfree_skb(skb);
8974 skb = NULL;
8975 } else {
8976 __skb_queue_tail(&list, skb);
8977 }
8978 io_sock_nolock_clear(file);
8979 fput(file);
8980 file = NULL;
8981 break;
8982 }
8983
8984 if (!file)
8985 break;
8986
8987 __skb_queue_tail(&list, skb);
8988
8989 skb = skb_dequeue(head);
8990 }
8991
8992 if (skb_peek(&list)) {
8993 spin_lock_irq(&head->lock);
8994 while ((skb = __skb_dequeue(&list)) != NULL)
8995 __skb_queue_tail(head, skb);
8996 spin_unlock_irq(&head->lock);
8997 }
8998 #else
> 8999 io_sock_nolock_clear(file);
9000 fput(file);
9001 #endif
9002 }
9003
--
0-DAY CI Kernel Test Service
https://01.org/lkp
reply other threads:[~2022-03-28 23:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox