* [ammarfaizi2-block:google/android/kernel/common/android12-trusty-5.10 5839/5872] kernel/sched/psi.c:538:3: error: implicit declaration of function 'trace_android_vh_psi_event'
@ 2022-03-30 0:54 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-03-30 0:54 UTC (permalink / raw)
To: Georgi Djakov; +Cc: kbuild-all, GNU/Weeb Mailing List, linux-kernel
Hi Georgi,
FYI, the error/warning still remains.
tree: https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android12-trusty-5.10
head: b60d55f33484d855a546f7cfc59a28a5771e8bee
commit: b79d1815c400c3929bb78a209b6e51a38d6ffcb2 [5839/5872] ANDROID: psi: Add vendor hooks for PSI tracing
config: i386-randconfig-s001-20220328 (https://download.01.org/0day-ci/archive/20220330/[email protected]/config)
compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/ammarfaizi2/linux-block/commit/b79d1815c400c3929bb78a209b6e51a38d6ffcb2
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block google/android/kernel/common/android12-trusty-5.10
git checkout b79d1815c400c3929bb78a209b6e51a38d6ffcb2
# save the config file to linux build tree
mkdir build_dir
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
kernel/sched/psi.c: In function 'update_triggers':
>> kernel/sched/psi.c:538:3: error: implicit declaration of function 'trace_android_vh_psi_event' [-Werror=implicit-function-declaration]
538 | trace_android_vh_psi_event(t);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/sched/psi.c:546:2: error: implicit declaration of function 'trace_android_vh_psi_group' [-Werror=implicit-function-declaration]
546 | trace_android_vh_psi_group(group);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/trace_android_vh_psi_event +538 kernel/sched/psi.c
503
504 static u64 update_triggers(struct psi_group *group, u64 now)
505 {
506 struct psi_trigger *t;
507 bool new_stall = false;
508 u64 *total = group->total[PSI_POLL];
509
510 /*
511 * On subsequent updates, calculate growth deltas and let
512 * watchers know when their specified thresholds are exceeded.
513 */
514 list_for_each_entry(t, &group->triggers, node) {
515 u64 growth;
516
517 /* Check for stall activity */
518 if (group->polling_total[t->state] == total[t->state])
519 continue;
520
521 /*
522 * Multiple triggers might be looking at the same state,
523 * remember to update group->polling_total[] once we've
524 * been through all of them. Also remember to extend the
525 * polling time if we see new stall activity.
526 */
527 new_stall = true;
528
529 /* Calculate growth since last update */
530 growth = window_update(&t->win, now, total[t->state]);
531 if (growth < t->threshold)
532 continue;
533
534 /* Limit event signaling to once per window */
535 if (now < t->last_event_time + t->win.size)
536 continue;
537
> 538 trace_android_vh_psi_event(t);
539
540 /* Generate an event */
541 if (cmpxchg(&t->event, 0, 1) == 0)
542 wake_up_interruptible(&t->event_wait);
543 t->last_event_time = now;
544 }
545
> 546 trace_android_vh_psi_group(group);
547
548 if (new_stall)
549 memcpy(group->polling_total, total,
550 sizeof(group->polling_total));
551
552 return now + group->poll_min_period;
553 }
554
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 2+ messages in thread
* [ammarfaizi2-block:google/android/kernel/common/android12-trusty-5.10 5839/5872] kernel/sched/psi.c:538:3: error: implicit declaration of function 'trace_android_vh_psi_event'
@ 2022-03-30 2:16 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-03-30 2:16 UTC (permalink / raw)
To: Georgi Djakov; +Cc: llvm, kbuild-all, GNU/Weeb Mailing List, linux-kernel
Hi Georgi,
FYI, the error/warning still remains.
tree: https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android12-trusty-5.10
head: 07055bfd3d810d41a38354693dfaa55a6f8c0025
commit: b79d1815c400c3929bb78a209b6e51a38d6ffcb2 [5839/5872] ANDROID: psi: Add vendor hooks for PSI tracing
config: i386-randconfig-a006 (https://download.01.org/0day-ci/archive/20220330/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0f6d9501cf49ce02937099350d08f20c4af86f3d)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/ammarfaizi2/linux-block/commit/b79d1815c400c3929bb78a209b6e51a38d6ffcb2
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block google/android/kernel/common/android12-trusty-5.10
git checkout b79d1815c400c3929bb78a209b6e51a38d6ffcb2
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
>> kernel/sched/psi.c:538:3: error: implicit declaration of function 'trace_android_vh_psi_event' [-Werror,-Wimplicit-function-declaration]
trace_android_vh_psi_event(t);
^
>> kernel/sched/psi.c:546:2: error: implicit declaration of function 'trace_android_vh_psi_group' [-Werror,-Wimplicit-function-declaration]
trace_android_vh_psi_group(group);
^
2 errors generated.
vim +/trace_android_vh_psi_event +538 kernel/sched/psi.c
503
504 static u64 update_triggers(struct psi_group *group, u64 now)
505 {
506 struct psi_trigger *t;
507 bool new_stall = false;
508 u64 *total = group->total[PSI_POLL];
509
510 /*
511 * On subsequent updates, calculate growth deltas and let
512 * watchers know when their specified thresholds are exceeded.
513 */
514 list_for_each_entry(t, &group->triggers, node) {
515 u64 growth;
516
517 /* Check for stall activity */
518 if (group->polling_total[t->state] == total[t->state])
519 continue;
520
521 /*
522 * Multiple triggers might be looking at the same state,
523 * remember to update group->polling_total[] once we've
524 * been through all of them. Also remember to extend the
525 * polling time if we see new stall activity.
526 */
527 new_stall = true;
528
529 /* Calculate growth since last update */
530 growth = window_update(&t->win, now, total[t->state]);
531 if (growth < t->threshold)
532 continue;
533
534 /* Limit event signaling to once per window */
535 if (now < t->last_event_time + t->win.size)
536 continue;
537
> 538 trace_android_vh_psi_event(t);
539
540 /* Generate an event */
541 if (cmpxchg(&t->event, 0, 1) == 0)
542 wake_up_interruptible(&t->event_wait);
543 t->last_event_time = now;
544 }
545
> 546 trace_android_vh_psi_group(group);
547
548 if (new_stall)
549 memcpy(group->polling_total, total,
550 sizeof(group->polling_total));
551
552 return now + group->poll_min_period;
553 }
554
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-30 2:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-30 2:16 [ammarfaizi2-block:google/android/kernel/common/android12-trusty-5.10 5839/5872] kernel/sched/psi.c:538:3: error: implicit declaration of function 'trace_android_vh_psi_event' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-03-30 0:54 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox