From: kernel test robot <[email protected]>
To: David Howells <[email protected]>
Cc: [email protected], [email protected],
GNU/Weeb Mailing List <[email protected]>,
[email protected]
Subject: [ammarfaizi2-block:dhowells/linux-fs/netfs-maple 2/40] fs/netfs/objects.c:48:2: error: implicit declaration of function 'netfs_proc_add_writeback' is invalid in C99
Date: Tue, 5 Apr 2022 17:54:44 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
tree: https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/netfs-maple
head: 674eea41fc70a740ff83ec590f9833f805852464
commit: 9bff5b05142d47cc6a64f5e023fd01d9bf8bee9e [2/40] netfs: Add a procfile to list in-progress requests
config: hexagon-randconfig-r021-20220405 (https://download.01.org/0day-ci/archive/20220405/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c4a1b07d0979e7ff20d7d541af666d822d66b566)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/ammarfaizi2/linux-block/commit/9bff5b05142d47cc6a64f5e023fd01d9bf8bee9e
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block dhowells/linux-fs/netfs-maple
git checkout 9bff5b05142d47cc6a64f5e023fd01d9bf8bee9e
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/netfs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
>> fs/netfs/objects.c:48:2: error: implicit declaration of function 'netfs_proc_add_writeback' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
netfs_proc_add_writeback(rreq);
^
fs/netfs/objects.c:48:2: note: did you mean 'netfs_proc_add_rreq'?
fs/netfs/internal.h:51:20: note: 'netfs_proc_add_rreq' declared here
static inline void netfs_proc_add_rreq(struct netfs_io_request *rreq) {}
^
>> fs/netfs/objects.c:80:2: error: implicit declaration of function 'netfs_proc_del_writeback' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
netfs_proc_del_writeback(rreq);
^
fs/netfs/objects.c:80:2: note: did you mean 'netfs_proc_del_rreq'?
fs/netfs/internal.h:52:20: note: 'netfs_proc_del_rreq' declared here
static inline void netfs_proc_del_rreq(struct netfs_io_request *rreq) {}
^
2 errors generated.
vim +/netfs_proc_add_writeback +48 fs/netfs/objects.c
10
11 /*
12 * Allocate an I/O request and initialise it.
13 */
14 struct netfs_io_request *netfs_alloc_request(struct address_space *mapping,
15 struct file *file,
16 loff_t start, size_t len,
17 enum netfs_io_origin origin)
18 {
19 static atomic_t debug_ids;
20 struct inode *inode = file ? file_inode(file) : mapping->host;
21 struct netfs_i_context *ctx = netfs_i_context(inode);
22 struct netfs_io_request *rreq;
23 int ret;
24
25 rreq = kzalloc(sizeof(struct netfs_io_request), GFP_KERNEL);
26 if (!rreq)
27 return ERR_PTR(-ENOMEM);
28
29 rreq->start = start;
30 rreq->len = len;
31 rreq->origin = origin;
32 rreq->netfs_ops = ctx->ops;
33 rreq->mapping = mapping;
34 rreq->inode = inode;
35 rreq->i_size = i_size_read(inode);
36 rreq->debug_id = atomic_inc_return(&debug_ids);
37 INIT_LIST_HEAD(&rreq->subrequests);
38 refcount_set(&rreq->ref, 1);
39 __set_bit(NETFS_RREQ_IN_PROGRESS, &rreq->flags);
40 if (rreq->netfs_ops->init_request) {
41 ret = rreq->netfs_ops->init_request(rreq, file);
42 if (ret < 0) {
43 kfree(rreq);
44 return ERR_PTR(ret);
45 }
46 }
47
> 48 netfs_proc_add_writeback(rreq);
49 netfs_stat(&netfs_n_rh_rreq);
50 return rreq;
51 }
52
53 void netfs_get_request(struct netfs_io_request *rreq, enum netfs_rreq_ref_trace what)
54 {
55 int r;
56
57 __refcount_inc(&rreq->ref, &r);
58 trace_netfs_rreq_ref(rreq->debug_id, r + 1, what);
59 }
60
61 void netfs_clear_subrequests(struct netfs_io_request *rreq, bool was_async)
62 {
63 struct netfs_io_subrequest *subreq;
64
65 while (!list_empty(&rreq->subrequests)) {
66 subreq = list_first_entry(&rreq->subrequests,
67 struct netfs_io_subrequest, rreq_link);
68 list_del(&subreq->rreq_link);
69 netfs_put_subrequest(subreq, was_async,
70 netfs_sreq_trace_put_clear);
71 }
72 }
73
74 static void netfs_free_request(struct work_struct *work)
75 {
76 struct netfs_io_request *rreq =
77 container_of(work, struct netfs_io_request, work);
78
79 trace_netfs_rreq(rreq, netfs_rreq_trace_free);
> 80 netfs_proc_del_writeback(rreq);
81 netfs_clear_subrequests(rreq, false);
82 if (rreq->netfs_ops->free_request)
83 rreq->netfs_ops->free_request(rreq);
84 if (rreq->cache_resources.ops)
85 rreq->cache_resources.ops->end_operation(&rreq->cache_resources);
86 kfree_rcu(rreq, rcu);
87 netfs_stat_d(&netfs_n_rh_rreq);
88 }
89
--
0-DAY CI Kernel Test Service
https://01.org/lkp
reply other threads:[~2022-04-05 9:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox