* [ammarfaizi2-block:dhowells/linux-fs/netfs-lib 2/19] fs/netfs/objects.c:48:2: error: implicit declaration of function 'netfs_proc_add_writeback' is invalid in C99
@ 2022-04-13 7:26 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-04-13 7:26 UTC (permalink / raw)
To: David Howells; +Cc: llvm, kbuild-all, GNU/Weeb Mailing List, linux-kernel
tree: https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/netfs-lib
head: 581c77dd1ab4abe122b649ed7118b3581ff1a437
commit: 20239f3d18983c183a267ab537919bc88990b832 [2/19] netfs: Add a procfile to list in-progress requests
config: s390-buildonly-randconfig-r002-20220412 (https://download.01.org/0day-ci/archive/20220413/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project fe2478d44e4f7f191c43fef629ac7a23d0251e72)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install s390 cross compiling tool for clang build
# apt-get install binutils-s390x-linux-gnu
# https://github.com/ammarfaizi2/linux-block/commit/20239f3d18983c183a267ab537919bc88990b832
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block dhowells/linux-fs/netfs-lib
git checkout 20239f3d18983c183a267ab537919bc88990b832
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
>> fs/netfs/objects.c:48:2: error: implicit declaration of function 'netfs_proc_add_writeback' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
netfs_proc_add_writeback(rreq);
^
fs/netfs/objects.c:48:2: note: did you mean 'netfs_proc_add_rreq'?
fs/netfs/internal.h:51:20: note: 'netfs_proc_add_rreq' declared here
static inline void netfs_proc_add_rreq(struct netfs_io_request *rreq) {}
^
>> fs/netfs/objects.c:80:2: error: implicit declaration of function 'netfs_proc_del_writeback' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
netfs_proc_del_writeback(rreq);
^
fs/netfs/objects.c:80:2: note: did you mean 'netfs_proc_del_rreq'?
fs/netfs/internal.h:52:20: note: 'netfs_proc_del_rreq' declared here
static inline void netfs_proc_del_rreq(struct netfs_io_request *rreq) {}
^
2 errors generated.
vim +/netfs_proc_add_writeback +48 fs/netfs/objects.c
10
11 /*
12 * Allocate an I/O request and initialise it.
13 */
14 struct netfs_io_request *netfs_alloc_request(struct address_space *mapping,
15 struct file *file,
16 loff_t start, size_t len,
17 enum netfs_io_origin origin)
18 {
19 static atomic_t debug_ids;
20 struct inode *inode = file ? file_inode(file) : mapping->host;
21 struct netfs_i_context *ctx = netfs_i_context(inode);
22 struct netfs_io_request *rreq;
23 int ret;
24
25 rreq = kzalloc(sizeof(struct netfs_io_request), GFP_KERNEL);
26 if (!rreq)
27 return ERR_PTR(-ENOMEM);
28
29 rreq->start = start;
30 rreq->len = len;
31 rreq->origin = origin;
32 rreq->netfs_ops = ctx->ops;
33 rreq->mapping = mapping;
34 rreq->inode = inode;
35 rreq->i_size = i_size_read(inode);
36 rreq->debug_id = atomic_inc_return(&debug_ids);
37 INIT_LIST_HEAD(&rreq->subrequests);
38 refcount_set(&rreq->ref, 1);
39 __set_bit(NETFS_RREQ_IN_PROGRESS, &rreq->flags);
40 if (rreq->netfs_ops->init_request) {
41 ret = rreq->netfs_ops->init_request(rreq, file);
42 if (ret < 0) {
43 kfree(rreq);
44 return ERR_PTR(ret);
45 }
46 }
47
> 48 netfs_proc_add_writeback(rreq);
49 netfs_stat(&netfs_n_rh_rreq);
50 return rreq;
51 }
52
53 void netfs_get_request(struct netfs_io_request *rreq, enum netfs_rreq_ref_trace what)
54 {
55 int r;
56
57 __refcount_inc(&rreq->ref, &r);
58 trace_netfs_rreq_ref(rreq->debug_id, r + 1, what);
59 }
60
61 void netfs_clear_subrequests(struct netfs_io_request *rreq, bool was_async)
62 {
63 struct netfs_io_subrequest *subreq;
64
65 while (!list_empty(&rreq->subrequests)) {
66 subreq = list_first_entry(&rreq->subrequests,
67 struct netfs_io_subrequest, rreq_link);
68 list_del(&subreq->rreq_link);
69 netfs_put_subrequest(subreq, was_async,
70 netfs_sreq_trace_put_clear);
71 }
72 }
73
74 static void netfs_free_request(struct work_struct *work)
75 {
76 struct netfs_io_request *rreq =
77 container_of(work, struct netfs_io_request, work);
78
79 trace_netfs_rreq(rreq, netfs_rreq_trace_free);
> 80 netfs_proc_del_writeback(rreq);
81 netfs_clear_subrequests(rreq, false);
82 if (rreq->netfs_ops->free_request)
83 rreq->netfs_ops->free_request(rreq);
84 if (rreq->cache_resources.ops)
85 rreq->cache_resources.ops->end_operation(&rreq->cache_resources);
86 kfree_rcu(rreq, rcu);
87 netfs_stat_d(&netfs_n_rh_rreq);
88 }
89
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-04-13 7:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-13 7:26 [ammarfaizi2-block:dhowells/linux-fs/netfs-lib 2/19] fs/netfs/objects.c:48:2: error: implicit declaration of function 'netfs_proc_add_writeback' is invalid in C99 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox