public inbox for [email protected]
 help / color / mirror / Atom feed
* [RESEND PATCH 0/2] Two tracing patches for trace_events_hist.c
@ 2022-04-17 18:56 Ammar Faizi
  2022-04-17 18:56 ` [RESEND PATCH 1/2] tracing: Return -EINVAL if WARN_ON(!glob) triggered in event_hist_trigger_parse() Ammar Faizi
  2022-04-17 18:56 ` [RESEND PATCH 2/2] tracing: Change `if (strlen(glob))` to `if (glob[0])` Ammar Faizi
  0 siblings, 2 replies; 3+ messages in thread
From: Ammar Faizi @ 2022-04-17 18:56 UTC (permalink / raw)
  To: Steven Rostedt, Ingo Molnar
  Cc: Ammar Faizi, GNU/Weeb Mailing List, Linux Kernel Mailing List,
	Linux Trace Devel Mailing List

[ Sorry, this is a resend, I sent it to the wrong address of trace devel list. ]

Hi,

Two patches here.

## Patch 1
If `WARN_ON(!glob)` is ever triggered, we will still continue executing
the next lines. This will trigger the more serious problem, a NULL
pointer dereference bug. Just return -EINVAL if @glob is NULL.

## Patch 2
Change `if (strlen(glob))` to `if (glob[0])`. No need to traverse to
the end of string. If the first byte is not a NUL char, it's
guaranteed `if (strlen(glob))` is true.


Signed-off-by: Ammar Faizi <[email protected]>
---

Ammar Faizi (2):
  tracing: Return -EINVAL if WARN_ON(!glob) triggered in event_hist_trigger_parse()
  tracing: Change `if (strlen(glob))` to `if (glob[0])`

 kernel/trace/trace_events_hist.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


base-commit: a1901b464e7e3e28956ae7423db2847dbbfb5be8
-- 
Ammar Faizi


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-04-17 18:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-17 18:56 [RESEND PATCH 0/2] Two tracing patches for trace_events_hist.c Ammar Faizi
2022-04-17 18:56 ` [RESEND PATCH 1/2] tracing: Return -EINVAL if WARN_ON(!glob) triggered in event_hist_trigger_parse() Ammar Faizi
2022-04-17 18:56 ` [RESEND PATCH 2/2] tracing: Change `if (strlen(glob))` to `if (glob[0])` Ammar Faizi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox