* [ammarfaizi2-block:dhowells/linux-fs/netfs-maple 28/44] fs/netfs/crypto.c:76:10: warning: comparison of distinct pointer types ('typeof (len) *' (aka 'unsigned int *') and 'typeof (((1UL) << 12) - offset) *' (aka 'unsigned long *'))
@ 2022-04-22 23:22 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-04-22 23:22 UTC (permalink / raw)
To: David Howells; +Cc: llvm, kbuild-all, GNU/Weeb Mailing List, linux-kernel
tree: https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/netfs-maple
head: 931e50676c6598d0eda1954ead465519ff91874d
commit: 777536e6af57becf14b8f4f34007ed3e3a95c911 [28/44] netfs: Perform content encryption
config: i386-randconfig-a002 (https://download.01.org/0day-ci/archive/20220423/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5bd87350a5ae429baf8f373cb226a57b62f87280)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/ammarfaizi2/linux-block/commit/777536e6af57becf14b8f4f34007ed3e3a95c911
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block dhowells/linux-fs/netfs-maple
git checkout 777536e6af57becf14b8f4f34007ed3e3a95c911
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/netfs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All warnings (new ones prefixed by >>):
>> fs/netfs/crypto.c:76:10: warning: comparison of distinct pointer types ('typeof (len) *' (aka 'unsigned int *') and 'typeof (((1UL) << 12) - offset) *' (aka 'unsigned long *')) [-Wcompare-distinct-pointer-types]
seg = min(len, PAGE_SIZE - offset);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:45:19: note: expanded from macro 'min'
#define min(x, y) __careful_cmp(x, y, <)
^~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:36:24: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), \
^~~~~~~~~~~~~~~~
include/linux/minmax.h:26:4: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^~~~~~~~~~~~~~~~~
include/linux/minmax.h:20:28: note: expanded from macro '__typecheck'
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
1 warning generated.
vim +76 fs/netfs/crypto.c
45
46 /*
47 * Populate a scatterlist from folios in an xarray.
48 */
49 static int netfs_xarray_to_sglist(struct xarray *xa, loff_t pos, size_t len,
50 struct scatterlist *sg, unsigned int n_sg)
51 {
52 struct scatterlist *p = sg;
53 struct folio *folio = NULL;
54 size_t seg, offset, skip = 0;
55 loff_t start = pos;
56 pgoff_t index = start >> PAGE_SHIFT;
57 int j;
58
59 XA_STATE(xas, xa, index);
60
61 sg_init_table(sg, n_sg);
62
63 rcu_read_lock();
64
65 xas_for_each(&xas, folio, ULONG_MAX) {
66 if (xas_retry(&xas, folio))
67 continue;
68 if (WARN_ON(xa_is_value(folio)) || WARN_ON(folio_test_hugetlb(folio)))
69 break;
70 for (j = (folio_index(folio) < index) ? index - folio_index(folio) : 0;
71 j < folio_nr_pages(folio); j++
72 ) {
73 struct page *subpage = folio_file_page(folio, j);
74
75 offset = (pos + skip) & ~PAGE_MASK;
> 76 seg = min(len, PAGE_SIZE - offset);
77
78 sg_set_page(p++, subpage, seg, offset);
79
80 len -= seg;
81 skip += seg;
82 if (len == 0)
83 break;
84 }
85 if (len == 0)
86 break;
87 }
88
89 rcu_read_unlock();
90 if (len > 0) {
91 kdebug("*** Insufficient source (%zx)", len);
92 //WARN_ON(len > 0);
93 return -EIO;
94 }
95
96 sg_mark_end(p - 1);
97 return p - sg;
98 }
99
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 2+ messages in thread* [ammarfaizi2-block:dhowells/linux-fs/netfs-maple 28/44] fs/netfs/crypto.c:76:10: warning: comparison of distinct pointer types ('typeof (len) *' (aka 'unsigned int *') and 'typeof (((1UL) << (12)) - offset) *' (aka 'unsigned long *'))
@ 2022-04-22 22:41 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-04-22 22:41 UTC (permalink / raw)
To: David Howells; +Cc: llvm, kbuild-all, GNU/Weeb Mailing List, linux-kernel
tree: https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/netfs-maple
head: 931e50676c6598d0eda1954ead465519ff91874d
commit: 777536e6af57becf14b8f4f34007ed3e3a95c911 [28/44] netfs: Perform content encryption
config: riscv-randconfig-r042-20220422 (https://download.01.org/0day-ci/archive/20220423/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5bd87350a5ae429baf8f373cb226a57b62f87280)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/ammarfaizi2/linux-block/commit/777536e6af57becf14b8f4f34007ed3e3a95c911
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block dhowells/linux-fs/netfs-maple
git checkout 777536e6af57becf14b8f4f34007ed3e3a95c911
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash fs/netfs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All warnings (new ones prefixed by >>):
>> fs/netfs/crypto.c:76:10: warning: comparison of distinct pointer types ('typeof (len) *' (aka 'unsigned int *') and 'typeof (((1UL) << (12)) - offset) *' (aka 'unsigned long *')) [-Wcompare-distinct-pointer-types]
seg = min(len, PAGE_SIZE - offset);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:45:19: note: expanded from macro 'min'
#define min(x, y) __careful_cmp(x, y, <)
^~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:36:24: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), \
^~~~~~~~~~~~~~~~
include/linux/minmax.h:26:4: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^~~~~~~~~~~~~~~~~
include/linux/minmax.h:20:28: note: expanded from macro '__typecheck'
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
1 warning generated.
vim +76 fs/netfs/crypto.c
45
46 /*
47 * Populate a scatterlist from folios in an xarray.
48 */
49 static int netfs_xarray_to_sglist(struct xarray *xa, loff_t pos, size_t len,
50 struct scatterlist *sg, unsigned int n_sg)
51 {
52 struct scatterlist *p = sg;
53 struct folio *folio = NULL;
54 size_t seg, offset, skip = 0;
55 loff_t start = pos;
56 pgoff_t index = start >> PAGE_SHIFT;
57 int j;
58
59 XA_STATE(xas, xa, index);
60
61 sg_init_table(sg, n_sg);
62
63 rcu_read_lock();
64
65 xas_for_each(&xas, folio, ULONG_MAX) {
66 if (xas_retry(&xas, folio))
67 continue;
68 if (WARN_ON(xa_is_value(folio)) || WARN_ON(folio_test_hugetlb(folio)))
69 break;
70 for (j = (folio_index(folio) < index) ? index - folio_index(folio) : 0;
71 j < folio_nr_pages(folio); j++
72 ) {
73 struct page *subpage = folio_file_page(folio, j);
74
75 offset = (pos + skip) & ~PAGE_MASK;
> 76 seg = min(len, PAGE_SIZE - offset);
77
78 sg_set_page(p++, subpage, seg, offset);
79
80 len -= seg;
81 skip += seg;
82 if (len == 0)
83 break;
84 }
85 if (len == 0)
86 break;
87 }
88
89 rcu_read_unlock();
90 if (len > 0) {
91 kdebug("*** Insufficient source (%zx)", len);
92 //WARN_ON(len > 0);
93 return -EIO;
94 }
95
96 sg_mark_end(p - 1);
97 return p - sg;
98 }
99
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-22 23:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-22 23:22 [ammarfaizi2-block:dhowells/linux-fs/netfs-maple 28/44] fs/netfs/crypto.c:76:10: warning: comparison of distinct pointer types ('typeof (len) *' (aka 'unsigned int *') and 'typeof (((1UL) << 12) - offset) *' (aka 'unsigned long *')) kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-04-22 22:41 [ammarfaizi2-block:dhowells/linux-fs/netfs-maple 28/44] fs/netfs/crypto.c:76:10: warning: comparison of distinct pointer types ('typeof (len) *' (aka 'unsigned int *') and 'typeof (((1UL) << (12)) " kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox