From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from integral2.. (unknown [180.246.147.8]) by gnuweeb.org (Postfix) with ESMTPSA id 20C567E78A; Thu, 28 Apr 2022 20:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1651178416; bh=pC15MnaDsC3mIOnzRDiBqcjRGmNPboBoRcOKm4uYY/g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b83RWWk8CgnSYT4VjQkuiYXEmvvUXnbxao5RKsEs1egHefhgl1wXiWBq/cFU5iKWp PpOR6y3ulzOnHoFj7jpplQV70c2ROrkrzOz89Kj6hayjHU8QLjOOHRcKKYPdkLVVG+ eOhJkvNZMXlanMS4lc/SXcWTo8r0/gdUYsHyENH7CwgILpLYxnYfXNvfTgZKap7B7k kIIQimZxc6Er12K+H+rlHYFhsYI2iBE/AdqUOK3C2WxLHr5JJrXPHVxr5tGtEOUxik hAHkzlLx1dX47l1Mn9i9ggQdeiRiP9Ux82stCPkmTvgMDWNQHx8MIAfZUzoLH0BF6d tD8ym2Fy5ee5w== From: Ammar Faizi To: Jens Axboe Cc: Ammar Faizi , Niklas Cassel , fio Mailing List , GNU/Weeb Mailing List Subject: [PATCH v3 2/3] json: Change `if (!strlen(str))` to `if (!str[0])` Date: Fri, 29 Apr 2022 03:39:53 +0700 Message-Id: <20220428203954.222165-3-ammarfaizi2@gnuweeb.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220428203954.222165-1-ammarfaizi2@gnuweeb.org> References: <20220428203954.222165-1-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: From: Ammar Faizi No need to traverse the whole string. Using `!strlen(str)` as a *conditional expression* is effectively the same with `!str[0]`. Signed-off-by: Ammar Faizi --- json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/json.c b/json.c index cd3d5d74..8b650721 100644 --- a/json.c +++ b/json.c @@ -56,7 +56,7 @@ static char *strdup_escape(const char *str) char *p, *ret; int escapes; - if (!strlen(str)) + if (!str[0]) return NULL; escapes = 0; -- Ammar Faizi