From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from integral2.. (unknown [180.246.147.8]) by gnuweeb.org (Postfix) with ESMTPSA id 4F5C87E39D; Thu, 28 Apr 2022 20:40:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1651178418; bh=IhGflcBLskqh6UhmitdEb7GIbwfcQNCnfEH0oYLs7dQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CKxalth96g5d56sBWaU6C96FSPbd7xv3eopEGDGk0tGOw0v59/8K1NyVH20AlA5PM O7LlQ5PwaSrhHWC6EOYl9GnmvoVymVEFJh1jyj81rptMtNwn9BGllyNUtS5gPBCbwz X+i2ak9QI75F4GtZGH6RRlTvMQwBQZPfPp73/k9feoDKAQ8jBnfN2EojYZtdW5xYXx HRh2gu36XhpRkJp1pR4I7mlCYcWaTseGkIQQlWDBjcqf6xV202Tfe0vnwuNvE95Q+V VmY0EhRq3ecaMn0WToMz2l0j6EtpCsxxqSKVefbSLhNbgu16FK8mp040R3bqH61SJ5 s6CGU/NS0kriQ== From: Ammar Faizi To: Jens Axboe Cc: Ammar Faizi , Niklas Cassel , fio Mailing List , GNU/Weeb Mailing List Subject: [PATCH v3 3/3] Makefile: Suppress `-Wimplicit-fallthrough` when compiling `lex.yy` Date: Fri, 29 Apr 2022 03:39:54 +0700 Message-Id: <20220428203954.222165-4-ammarfaizi2@gnuweeb.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220428203954.222165-1-ammarfaizi2@gnuweeb.org> References: <20220428203954.222165-1-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: From: Ammar Faizi lex.yy.c is an auto generated C file. When compiling with clang-15, we got the following warning: ``` CC lex.yy.o lex.yy.c:1444:5: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] case EOB_ACT_END_OF_FILE: ^ lex.yy.c:1444:5: note: insert '__attribute__((fallthrough));' to silence this warning case EOB_ACT_END_OF_FILE: ^ __attribute__((fallthrough)); lex.yy.c:1444:5: note: insert 'break;' to avoid fall-through case EOB_ACT_END_OF_FILE: ^ break; 1 warning generated. ``` There is nothing we can do to fix lex.yy.c since it's an auto generated file. Fix this by appending `-Wno-implicit-fallthrough` when compiling this file if we have `-Wimplicit-fallthrough` flag enabled. Signed-off-by: Ammar Faizi --- Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index e670c1f2..1e15a69e 100644 --- a/Makefile +++ b/Makefile @@ -530,8 +530,12 @@ else $(QUIET_LEX)$(LEX) $< endif +ifneq (,$(findstring -Wimplicit-fallthrough,$(CFLAGS))) +LEX_YY_CFLAGS := -Wno-implicit-fallthrough +endif + lex.yy.o: lex.yy.c y.tab.h - $(QUIET_CC)$(CC) -o $@ $(CFLAGS) $(CPPFLAGS) -c $< + $(QUIET_CC)$(CC) -o $@ $(CFLAGS) $(CPPFLAGS) $(LEX_YY_CFLAGS) -c $< y.tab.o: y.tab.c y.tab.h $(QUIET_CC)$(CC) -o $@ $(CFLAGS) $(CPPFLAGS) -c $< -- Ammar Faizi