[ammarfaizi2-block:kvalo/ath/pending 7/57] drivers/net/wireless/realtek/rtw89/ser.c:319:2: warning: unannotated fall-through between switch labels

public inbox for [email protected]
 help / color / mirror / Atom feed

* [ammarfaizi2-block:kvalo/ath/pending 7/57] drivers/net/wireless/realtek/rtw89/ser.c:319:2: warning: unannotated fall-through between switch labels
@ 2022-04-28 17:47 kernel test robot
  2022-04-29  5:48 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2022-04-28 17:47 UTC (permalink / raw)
  To: Zong-Zhe Yang
  Cc: llvm, kbuild-all, GNU/Weeb Mailing List, linux-kernel, Kalle Valo,
	Ping-Ke Shih

Hi Zong-Zhe,

FYI, the error/warning still remains.

tree:   https://github.com/ammarfaizi2/linux-block kvalo/ath/pending
head:   5c6cf64b40b98e4d4247fda11e4b4c859a24585d
commit: 14f9f4790048f684c2b151c899895feae0b5731a [7/57] rtw89: ser: control hci interrupts on/off by state
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20220429/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c59473aacce38cd7dd77eebceaf3c98c5707ab3b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/ammarfaizi2/linux-block/commit/14f9f4790048f684c2b151c899895feae0b5731a
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block kvalo/ath/pending
        git checkout 14f9f4790048f684c2b151c899895feae0b5731a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/misc/lkdtm/ drivers/net/wireless/realtek/rtw89/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/realtek/rtw89/ser.c:319:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
           default:
           ^
   drivers/net/wireless/realtek/rtw89/ser.c:319:2: note: insert 'break;' to avoid fall-through
           default:
           ^
           break; 
   1 warning generated.


vim +319 drivers/net/wireless/realtek/rtw89/ser.c

e3ec7017f6a20d Ping-Ke Shih  2021-10-11  301  
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  302  /* state handler */
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  303  static void ser_idle_st_hdl(struct rtw89_ser *ser, u8 evt)
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  304  {
14f9f4790048f6 Zong-Zhe Yang 2022-03-14  305  	struct rtw89_dev *rtwdev = container_of(ser, struct rtw89_dev, ser);
14f9f4790048f6 Zong-Zhe Yang 2022-03-14  306  
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  307  	switch (evt) {
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  308  	case SER_EV_STATE_IN:
14f9f4790048f6 Zong-Zhe Yang 2022-03-14  309  		rtw89_hci_recovery_complete(rtwdev);
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  310  		break;
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  311  	case SER_EV_L1_RESET:
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  312  		ser_state_goto(ser, SER_RESET_TRX_ST);
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  313  		break;
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  314  	case SER_EV_L2_RESET:
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  315  		ser_state_goto(ser, SER_L2_RESET_ST);
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  316  		break;
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  317  	case SER_EV_STATE_OUT:
14f9f4790048f6 Zong-Zhe Yang 2022-03-14  318  		rtw89_hci_recovery_start(rtwdev);
e3ec7017f6a20d Ping-Ke Shih  2021-10-11 @319  	default:
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  320  		break;
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  321  	}
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  322  }
e3ec7017f6a20d Ping-Ke Shih  2021-10-11  323  

:::::: The code at line 319 was first introduced by commit
:::::: e3ec7017f6a20d12ddd9fe23d345ebb7b8c104dd rtw89: add Realtek 802.11ax driver

:::::: TO: Ping-Ke Shih <[email protected]>
:::::: CC: Kalle Valo <[email protected]>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [ammarfaizi2-block:kvalo/ath/pending 7/57] drivers/net/wireless/realtek/rtw89/ser.c:319:2: warning: unannotated fall-through between switch labels
  2022-04-28 17:47 [ammarfaizi2-block:kvalo/ath/pending 7/57] drivers/net/wireless/realtek/rtw89/ser.c:319:2: warning: unannotated fall-through between switch labels kernel test robot
@ 2022-04-29  5:48 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-04-29  5:48 UTC (permalink / raw)
  To: kernel test robot
  Cc: Zong-Zhe Yang, llvm, kbuild-all, GNU/Weeb Mailing List,
	linux-kernel, Ping-Ke Shih

kernel test robot <[email protected]> writes:

> Hi Zong-Zhe,
>
> FYI, the error/warning still remains.
>
> tree:   https://github.com/ammarfaizi2/linux-block kvalo/ath/pending
> head:   5c6cf64b40b98e4d4247fda11e4b4c859a24585d
> commit: 14f9f4790048f684c2b151c899895feae0b5731a [7/57] rtw89: ser: control hci interrupts on/off by state
> config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20220429/[email protected]/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c59473aacce38cd7dd77eebceaf3c98c5707ab3b)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install arm64 cross compiling tool for clang build
>         # apt-get install binutils-aarch64-linux-gnu
>         # https://github.com/ammarfaizi2/linux-block/commit/14f9f4790048f684c2b151c899895feae0b5731a
>         git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
>         git fetch --no-tags ammarfaizi2-block kvalo/ath/pending
>         git checkout 14f9f4790048f684c2b151c899895feae0b5731a
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/misc/lkdtm/ drivers/net/wireless/realtek/rtw89/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All warnings (new ones prefixed by >>):
>
>>> drivers/net/wireless/realtek/rtw89/ser.c:319:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
>            default:
>            ^
>    drivers/net/wireless/realtek/rtw89/ser.c:319:2: note: insert 'break;' to avoid fall-through
>            default:
>            ^
>            break; 
>    1 warning generated.

This commit should fix it:

https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git/commit/?id=5ddfffd6da9b94e5f6397843ad1a54d6a211f652

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-29  5:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-28 17:47 [ammarfaizi2-block:kvalo/ath/pending 7/57] drivers/net/wireless/realtek/rtw89/ser.c:319:2: warning: unannotated fall-through between switch labels kernel test robot
2022-04-29  5:48 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox