From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEXHASH_WORD,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gnuweeb.org (Postfix) with ESMTPS id CEC747F610 for ; Wed, 11 May 2022 08:12:36 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=j8Bp7a2I; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652256756; x=1683792756; h=date:from:to:cc:subject:message-id:mime-version; bh=o9CEgqPjU1bG7cHfsxjGE3RYC7cny2rsZd+dhJIFAsE=; b=j8Bp7a2IxYMVb83ZJZ8CZDL8RHhiNWApmIddyinJ+YBxGtN7wOlKW7U/ IWrNFGuOkFz58+dZeObqJTf6t1SUC1bg4RWTUa7XEmxq1H9/cgdVv2kEw jEXw8I4SVdcO9eg1ijBkTKJR5n1ZqjlFJtiK6Xj6Dhw++kbsgzPfn8G79 igGIEuNZllg1oEPV7hwUVuaFgE2T/VixoZ0yHjGaYO69GMZGNQTwhzrb/ A2SnkkENTENTF+JWS/Ja44gSCJLx+glBz54hqGKeisYUzVd2tdMsWM/m/ tiry90PVvo3120Gtx/pWswE7K9/jp4gxqWZIrFKNadGmMK4q8w3Tj/GN1 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10343"; a="268466247" X-IronPort-AV: E=Sophos;i="5.91,216,1647327600"; d="scan'208";a="268466247" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 01:12:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,216,1647327600"; d="scan'208";a="542199984" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by orsmga006.jf.intel.com with ESMTP; 11 May 2022 01:12:34 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1nohST-000IsT-JA; Wed, 11 May 2022 08:12:33 +0000 Date: Wed, 11 May 2022 16:11:59 +0800 From: kernel test robot To: David Howells Cc: kbuild-all@lists.01.org, GNU/Weeb Mailing List , linux-kernel@vger.kernel.org Subject: [ammarfaizi2-block:dhowells/linux-fs/cifs-for-sfrench 5/6] fs/cifs/smb2pdu.c:4059:38: error: 'struct cifs_readdata' has no member named 'nr_pages' Message-ID: <202205111607.rgPALYjN-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline List-Id: tree: https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/cifs-for-sfrench head: 627ce4da99bb612945366770c5604019fb74b653 commit: e4b60df6a12099568c671591d36a9fa16515f6eb [5/6] cifs: Change the I/O paths to use an iterator rather than a page list config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20220511/202205111607.rgPALYjN-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/ammarfaizi2/linux-block/commit/e4b60df6a12099568c671591d36a9fa16515f6eb git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block git fetch --no-tags ammarfaizi2-block dhowells/linux-fs/cifs-for-sfrench git checkout e4b60df6a12099568c671591d36a9fa16515f6eb # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/misc/ fs/cifs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): fs/cifs/smb2pdu.c: In function 'smb2_new_read_req': fs/cifs/smb2pdu.c:4058:57: error: 'struct cifs_readdata' has no member named 'pages' 4058 | server->smbd_conn, rdata->pages, | ^~ >> fs/cifs/smb2pdu.c:4059:38: error: 'struct cifs_readdata' has no member named 'nr_pages' 4059 | rdata->nr_pages, rdata->page_offset, | ^~ >> fs/cifs/smb2pdu.c:4059:55: error: 'struct cifs_readdata' has no member named 'page_offset' 4059 | rdata->nr_pages, rdata->page_offset, | ^~ >> fs/cifs/smb2pdu.c:4060:38: error: 'struct cifs_readdata' has no member named 'tailsz' 4060 | rdata->tailsz, true, need_invalidate); | ^~ fs/cifs/smb2pdu.c: In function 'smb2_async_writev': fs/cifs/smb2pdu.c:4481:57: error: 'struct cifs_writedata' has no member named 'pages' 4481 | server->smbd_conn, wdata->pages, | ^~ fs/cifs/smb2pdu.c:4482:38: error: 'struct cifs_writedata' has no member named 'nr_pages' 4482 | wdata->nr_pages, wdata->page_offset, | ^~ fs/cifs/smb2pdu.c:4482:55: error: 'struct cifs_writedata' has no member named 'page_offset' 4482 | wdata->nr_pages, wdata->page_offset, | ^~ fs/cifs/smb2pdu.c:4483:38: error: 'struct cifs_writedata' has no member named 'tailsz' 4483 | wdata->tailsz, false, need_invalidate); | ^~ fs/cifs/smb2pdu.c:4490:26: error: 'struct cifs_writedata' has no member named 'nr_pages' 4490 | if (wdata->nr_pages > 1) | ^~ In file included from include/linux/swab.h:5, from arch/arm/include/asm/opcodes.h:86, from arch/arm/include/asm/bug.h:7, from include/linux/bug.h:5, from include/linux/thread_info.h:13, from include/asm-generic/preempt.h:5, from ./arch/arm/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from include/linux/spinlock.h:55, from include/linux/wait.h:9, from include/linux/wait_bit.h:8, from include/linux/fs.h:6, from fs/cifs/smb2pdu.c:18: fs/cifs/smb2pdu.c:4493:47: error: 'struct cifs_writedata' has no member named 'nr_pages' 4493 | (wdata->nr_pages - 1) * wdata->pagesz - | ^~ include/uapi/linux/swab.h:115:54: note: in definition of macro '__swab32' 115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x)) | ^ include/linux/byteorder/generic.h:88:21: note: in expansion of macro '__cpu_to_le32' 88 | #define cpu_to_le32 __cpu_to_le32 | ^~~~~~~~~~~~~ fs/cifs/smb2pdu.c:4492:33: note: in expansion of macro 'cpu_to_le32' 4492 | cpu_to_le32( | ^~~~~~~~~~~ fs/cifs/smb2pdu.c:4493:70: error: 'struct cifs_writedata' has no member named 'pagesz' 4493 | (wdata->nr_pages - 1) * wdata->pagesz - | ^~ include/uapi/linux/swab.h:115:54: note: in definition of macro '__swab32' 115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x)) | ^ include/linux/byteorder/generic.h:88:21: note: in expansion of macro '__cpu_to_le32' 88 | #define cpu_to_le32 __cpu_to_le32 | ^~~~~~~~~~~~~ fs/cifs/smb2pdu.c:4492:33: note: in expansion of macro 'cpu_to_le32' 4492 | cpu_to_le32( | ^~~~~~~~~~~ fs/cifs/smb2pdu.c:4494:46: error: 'struct cifs_writedata' has no member named 'page_offset' 4494 | wdata->page_offset + wdata->tailsz | ^~ include/uapi/linux/swab.h:115:54: note: in definition of macro '__swab32' 115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x)) | ^ include/linux/byteorder/generic.h:88:21: note: in expansion of macro '__cpu_to_le32' 88 | #define cpu_to_le32 __cpu_to_le32 | ^~~~~~~~~~~~~ fs/cifs/smb2pdu.c:4492:33: note: in expansion of macro 'cpu_to_le32' 4492 | cpu_to_le32( | ^~~~~~~~~~~ fs/cifs/smb2pdu.c:4494:67: error: 'struct cifs_writedata' has no member named 'tailsz' 4494 | wdata->page_offset + wdata->tailsz | ^~ include/uapi/linux/swab.h:115:54: note: in definition of macro '__swab32' 115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x)) | ^ include/linux/byteorder/generic.h:88:21: note: in expansion of macro '__cpu_to_le32' 88 | #define cpu_to_le32 __cpu_to_le32 | ^~~~~~~~~~~~~ fs/cifs/smb2pdu.c:4492:33: note: in expansion of macro 'cpu_to_le32' 4492 | cpu_to_le32( | ^~~~~~~~~~~ fs/cifs/smb2pdu.c:4497:64: error: 'struct cifs_writedata' has no member named 'tailsz' 4497 | req->RemainingBytes = cpu_to_le32(wdata->tailsz); | ^~ include/uapi/linux/swab.h:115:54: note: in definition of macro '__swab32' 115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x)) | ^ include/linux/byteorder/generic.h:88:21: note: in expansion of macro '__cpu_to_le32' 88 | #define cpu_to_le32 __cpu_to_le32 | ^~~~~~~~~~~~~ fs/cifs/smb2pdu.c:4497:47: note: in expansion of macro 'cpu_to_le32' 4497 | req->RemainingBytes = cpu_to_le32(wdata->tailsz); | ^~~~~~~~~~~ fs/cifs/smb2pdu.c:4520:21: error: 'struct smb_rqst' has no member named 'rq_npages' 4520 | rqst.rq_npages = 0; | ^ vim +4059 fs/cifs/smb2pdu.c 09a4707e763824 Pavel Shilovsky 2012-09-18 4007 09a4707e763824 Pavel Shilovsky 2012-09-18 4008 /* 09a4707e763824 Pavel Shilovsky 2012-09-18 4009 * To form a chain of read requests, any read requests after the first should 09a4707e763824 Pavel Shilovsky 2012-09-18 4010 * have the end_of_chain boolean set to true. 09a4707e763824 Pavel Shilovsky 2012-09-18 4011 */ 09a4707e763824 Pavel Shilovsky 2012-09-18 4012 static int 738f9de5cdb917 Pavel Shilovsky 2016-11-23 4013 smb2_new_read_req(void **buf, unsigned int *total_len, 2dabfd5baba641 Long Li 2017-11-07 4014 struct cifs_io_parms *io_parms, struct cifs_readdata *rdata, 2dabfd5baba641 Long Li 2017-11-07 4015 unsigned int remaining_bytes, int request_type) 09a4707e763824 Pavel Shilovsky 2012-09-18 4016 { 09a4707e763824 Pavel Shilovsky 2012-09-18 4017 int rc = -EACCES; d8d9de532de9fa Ronnie Sahlberg 2021-09-08 4018 struct smb2_read_req *req = NULL; 0d35e382e4e96a Ronnie Sahlberg 2021-11-05 4019 struct smb2_hdr *shdr; 352d96f3acc6e0 Aurelien Aptel 2020-05-31 4020 struct TCP_Server_Info *server = io_parms->server; 09a4707e763824 Pavel Shilovsky 2012-09-18 4021 352d96f3acc6e0 Aurelien Aptel 2020-05-31 4022 rc = smb2_plain_req_init(SMB2_READ, io_parms->tcon, server, 352d96f3acc6e0 Aurelien Aptel 2020-05-31 4023 (void **) &req, total_len); 09a4707e763824 Pavel Shilovsky 2012-09-18 4024 if (rc) 09a4707e763824 Pavel Shilovsky 2012-09-18 4025 return rc; 2dabfd5baba641 Long Li 2017-11-07 4026 2dabfd5baba641 Long Li 2017-11-07 4027 if (server == NULL) 09a4707e763824 Pavel Shilovsky 2012-09-18 4028 return -ECONNABORTED; 09a4707e763824 Pavel Shilovsky 2012-09-18 4029 0d35e382e4e96a Ronnie Sahlberg 2021-11-05 4030 shdr = &req->hdr; 0d35e382e4e96a Ronnie Sahlberg 2021-11-05 4031 shdr->Id.SyncId.ProcessId = cpu_to_le32(io_parms->pid); 09a4707e763824 Pavel Shilovsky 2012-09-18 4032 351a59dace0e0e Paulo Alcantara 2022-03-21 4033 req->PersistentFileId = io_parms->persistent_fid; 351a59dace0e0e Paulo Alcantara 2022-03-21 4034 req->VolatileFileId = io_parms->volatile_fid; 09a4707e763824 Pavel Shilovsky 2012-09-18 4035 req->ReadChannelInfoOffset = 0; /* reserved */ 09a4707e763824 Pavel Shilovsky 2012-09-18 4036 req->ReadChannelInfoLength = 0; /* reserved */ 09a4707e763824 Pavel Shilovsky 2012-09-18 4037 req->Channel = 0; /* reserved */ 09a4707e763824 Pavel Shilovsky 2012-09-18 4038 req->MinimumCount = 0; 09a4707e763824 Pavel Shilovsky 2012-09-18 4039 req->Length = cpu_to_le32(io_parms->length); 09a4707e763824 Pavel Shilovsky 2012-09-18 4040 req->Offset = cpu_to_le64(io_parms->offset); d323c24617527f Steve French 2019-02-25 4041 d323c24617527f Steve French 2019-02-25 4042 trace_smb3_read_enter(0 /* xid */, d323c24617527f Steve French 2019-02-25 4043 io_parms->persistent_fid, d323c24617527f Steve French 2019-02-25 4044 io_parms->tcon->tid, io_parms->tcon->ses->Suid, d323c24617527f Steve French 2019-02-25 4045 io_parms->offset, io_parms->length); bd3dcc6a22a918 Long Li 2017-11-22 4046 #ifdef CONFIG_CIFS_SMB_DIRECT bd3dcc6a22a918 Long Li 2017-11-22 4047 /* bd3dcc6a22a918 Long Li 2017-11-22 4048 * If we want to do a RDMA write, fill in and append bd3dcc6a22a918 Long Li 2017-11-22 4049 * smbd_buffer_descriptor_v1 to the end of read request bd3dcc6a22a918 Long Li 2017-11-22 4050 */ bb4c0419476bd3 Long Li 2018-04-17 4051 if (server->rdma && rdata && !server->sign && bd3dcc6a22a918 Long Li 2017-11-22 4052 rdata->bytes >= server->smbd_conn->rdma_readwrite_threshold) { bd3dcc6a22a918 Long Li 2017-11-22 4053 bd3dcc6a22a918 Long Li 2017-11-22 4054 struct smbd_buffer_descriptor_v1 *v1; 352d96f3acc6e0 Aurelien Aptel 2020-05-31 4055 bool need_invalidate = server->dialect == SMB30_PROT_ID; bd3dcc6a22a918 Long Li 2017-11-22 4056 bd3dcc6a22a918 Long Li 2017-11-22 4057 rdata->mr = smbd_register_mr( bd3dcc6a22a918 Long Li 2017-11-22 4058 server->smbd_conn, rdata->pages, 7cf20bce77581b Long Li 2018-05-30 @4059 rdata->nr_pages, rdata->page_offset, 7cf20bce77581b Long Li 2018-05-30 @4060 rdata->tailsz, true, need_invalidate); bd3dcc6a22a918 Long Li 2017-11-22 4061 if (!rdata->mr) b7972092199f6d Long Li 2019-04-05 4062 return -EAGAIN; bd3dcc6a22a918 Long Li 2017-11-22 4063 bd3dcc6a22a918 Long Li 2017-11-22 4064 req->Channel = SMB2_CHANNEL_RDMA_V1_INVALIDATE; bd3dcc6a22a918 Long Li 2017-11-22 4065 if (need_invalidate) bd3dcc6a22a918 Long Li 2017-11-22 4066 req->Channel = SMB2_CHANNEL_RDMA_V1; bd3dcc6a22a918 Long Li 2017-11-22 4067 req->ReadChannelInfoOffset = d8d9de532de9fa Ronnie Sahlberg 2021-09-08 4068 cpu_to_le16(offsetof(struct smb2_read_req, Buffer)); bd3dcc6a22a918 Long Li 2017-11-22 4069 req->ReadChannelInfoLength = 2026b06e9ce852 Steve French 2018-01-24 4070 cpu_to_le16(sizeof(struct smbd_buffer_descriptor_v1)); bd3dcc6a22a918 Long Li 2017-11-22 4071 v1 = (struct smbd_buffer_descriptor_v1 *) &req->Buffer[0]; 2026b06e9ce852 Steve French 2018-01-24 4072 v1->offset = cpu_to_le64(rdata->mr->mr->iova); 2026b06e9ce852 Steve French 2018-01-24 4073 v1->token = cpu_to_le32(rdata->mr->mr->rkey); 2026b06e9ce852 Steve French 2018-01-24 4074 v1->length = cpu_to_le32(rdata->mr->mr->length); bd3dcc6a22a918 Long Li 2017-11-22 4075 bd3dcc6a22a918 Long Li 2017-11-22 4076 *total_len += sizeof(*v1) - 1; bd3dcc6a22a918 Long Li 2017-11-22 4077 } bd3dcc6a22a918 Long Li 2017-11-22 4078 #endif 09a4707e763824 Pavel Shilovsky 2012-09-18 4079 if (request_type & CHAINED_REQUEST) { 09a4707e763824 Pavel Shilovsky 2012-09-18 4080 if (!(request_type & END_OF_CHAIN)) { b8f57ee8aad414 Pavel Shilovsky 2016-11-23 4081 /* next 8-byte aligned request */ b8f57ee8aad414 Pavel Shilovsky 2016-11-23 4082 *total_len = DIV_ROUND_UP(*total_len, 8) * 8; b8f57ee8aad414 Pavel Shilovsky 2016-11-23 4083 shdr->NextCommand = cpu_to_le32(*total_len); 09a4707e763824 Pavel Shilovsky 2012-09-18 4084 } else /* END_OF_CHAIN */ 31473fc4f9653b Pavel Shilovsky 2016-10-24 4085 shdr->NextCommand = 0; 09a4707e763824 Pavel Shilovsky 2012-09-18 4086 if (request_type & RELATED_REQUEST) { 31473fc4f9653b Pavel Shilovsky 2016-10-24 4087 shdr->Flags |= SMB2_FLAGS_RELATED_OPERATIONS; 09a4707e763824 Pavel Shilovsky 2012-09-18 4088 /* 09a4707e763824 Pavel Shilovsky 2012-09-18 4089 * Related requests use info from previous read request 09a4707e763824 Pavel Shilovsky 2012-09-18 4090 * in chain. 09a4707e763824 Pavel Shilovsky 2012-09-18 4091 */ 0d35e382e4e96a Ronnie Sahlberg 2021-11-05 4092 shdr->SessionId = cpu_to_le64(0xFFFFFFFFFFFFFFFF); 0d35e382e4e96a Ronnie Sahlberg 2021-11-05 4093 shdr->Id.SyncId.TreeId = cpu_to_le32(0xFFFFFFFF); 351a59dace0e0e Paulo Alcantara 2022-03-21 4094 req->PersistentFileId = (u64)-1; 351a59dace0e0e Paulo Alcantara 2022-03-21 4095 req->VolatileFileId = (u64)-1; 09a4707e763824 Pavel Shilovsky 2012-09-18 4096 } 09a4707e763824 Pavel Shilovsky 2012-09-18 4097 } 09a4707e763824 Pavel Shilovsky 2012-09-18 4098 if (remaining_bytes > io_parms->length) 09a4707e763824 Pavel Shilovsky 2012-09-18 4099 req->RemainingBytes = cpu_to_le32(remaining_bytes); 09a4707e763824 Pavel Shilovsky 2012-09-18 4100 else 09a4707e763824 Pavel Shilovsky 2012-09-18 4101 req->RemainingBytes = 0; 09a4707e763824 Pavel Shilovsky 2012-09-18 4102 738f9de5cdb917 Pavel Shilovsky 2016-11-23 4103 *buf = req; 09a4707e763824 Pavel Shilovsky 2012-09-18 4104 return rc; 09a4707e763824 Pavel Shilovsky 2012-09-18 4105 } 09a4707e763824 Pavel Shilovsky 2012-09-18 4106 :::::: The code at line 4059 was first introduced by commit :::::: 7cf20bce77581bb72af72835e73c9a47d4346b70 CIFS: SMBD: Support page offset in memory registration :::::: TO: Long Li :::::: CC: Steve French -- 0-DAY CI Kernel Test Service https://01.org/lkp