public inbox for [email protected]
 help / color / mirror / Atom feed
From: kernel test robot <[email protected]>
To: Ulf Hansson <[email protected]>
Cc: [email protected],
	GNU/Weeb Mailing List <[email protected]>,
	[email protected], Sasha Levin <[email protected]>,
	Florian Fainelli <[email protected]>,
	Greg Kroah-Hartman <[email protected]>
Subject: [ammarfaizi2-block:stable/linux-stable-rc/queue/4.19 12/15] drivers/mmc/core/mmc_ops.c:960:13: warning: variable 'timeout' set but not used
Date: Fri, 20 May 2022 01:23:42 +0800	[thread overview]
Message-ID: <[email protected]> (raw)

tree:   https://github.com/ammarfaizi2/linux-block stable/linux-stable-rc/queue/4.19
head:   735c11789c15fd96455c15316570d55569afada4
commit: 200a3e31fe3e70a6b3c3ab587be7ae82c238ad6a [12/15] mmc: core: Specify timeouts for BKOPS and CACHE_FLUSH for eMMC
config: microblaze-buildonly-randconfig-r001-20220519 (https://download.01.org/0day-ci/archive/20220520/[email protected]/config)
compiler: microblaze-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/200a3e31fe3e70a6b3c3ab587be7ae82c238ad6a
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block stable/linux-stable-rc/queue/4.19
        git checkout 200a3e31fe3e70a6b3c3ab587be7ae82c238ad6a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=microblaze SHELL=/bin/bash drivers/mmc/core/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All warnings (new ones prefixed by >>):

   drivers/mmc/core/mmc_ops.c: In function 'mmc_start_bkops':
>> drivers/mmc/core/mmc_ops.c:960:13: warning: variable 'timeout' set but not used [-Wunused-but-set-variable]
     960 |         int timeout;
         |             ^~~~~~~


vim +/timeout +960 drivers/mmc/core/mmc_ops.c

1cf8f7e5af3910 Ulf Hansson   2017-06-09   946  
1cf8f7e5af3910 Ulf Hansson   2017-06-09   947  /**
1cf8f7e5af3910 Ulf Hansson   2017-06-09   948   *	mmc_start_bkops - start BKOPS for supported cards
1cf8f7e5af3910 Ulf Hansson   2017-06-09   949   *	@card: MMC card to start BKOPS
e5d0e17bb6022d Shawn Lin     2017-07-04   950   *	@from_exception: A flag to indicate if this function was
1cf8f7e5af3910 Ulf Hansson   2017-06-09   951   *			 called due to an exception raised by the card
1cf8f7e5af3910 Ulf Hansson   2017-06-09   952   *
1cf8f7e5af3910 Ulf Hansson   2017-06-09   953   *	Start background operations whenever requested.
1cf8f7e5af3910 Ulf Hansson   2017-06-09   954   *	When the urgent BKOPS bit is set in a R1 command response
1cf8f7e5af3910 Ulf Hansson   2017-06-09   955   *	then background operations should be started immediately.
1cf8f7e5af3910 Ulf Hansson   2017-06-09   956  */
1cf8f7e5af3910 Ulf Hansson   2017-06-09   957  void mmc_start_bkops(struct mmc_card *card, bool from_exception)
1cf8f7e5af3910 Ulf Hansson   2017-06-09   958  {
1cf8f7e5af3910 Ulf Hansson   2017-06-09   959  	int err;
1cf8f7e5af3910 Ulf Hansson   2017-06-09  @960  	int timeout;
1cf8f7e5af3910 Ulf Hansson   2017-06-09   961  	bool use_busy_signal;
1cf8f7e5af3910 Ulf Hansson   2017-06-09   962  
1cf8f7e5af3910 Ulf Hansson   2017-06-09   963  	if (!card->ext_csd.man_bkops_en || mmc_card_doing_bkops(card))
1cf8f7e5af3910 Ulf Hansson   2017-06-09   964  		return;
1cf8f7e5af3910 Ulf Hansson   2017-06-09   965  
1cf8f7e5af3910 Ulf Hansson   2017-06-09   966  	err = mmc_read_bkops_status(card);
1cf8f7e5af3910 Ulf Hansson   2017-06-09   967  	if (err) {
1cf8f7e5af3910 Ulf Hansson   2017-06-09   968  		pr_err("%s: Failed to read bkops status: %d\n",
1cf8f7e5af3910 Ulf Hansson   2017-06-09   969  		       mmc_hostname(card->host), err);
1cf8f7e5af3910 Ulf Hansson   2017-06-09   970  		return;
1cf8f7e5af3910 Ulf Hansson   2017-06-09   971  	}
1cf8f7e5af3910 Ulf Hansson   2017-06-09   972  
1cf8f7e5af3910 Ulf Hansson   2017-06-09   973  	if (!card->ext_csd.raw_bkops_status)
1cf8f7e5af3910 Ulf Hansson   2017-06-09   974  		return;
1cf8f7e5af3910 Ulf Hansson   2017-06-09   975  
1cf8f7e5af3910 Ulf Hansson   2017-06-09   976  	if (card->ext_csd.raw_bkops_status < EXT_CSD_BKOPS_LEVEL_2 &&
1cf8f7e5af3910 Ulf Hansson   2017-06-09   977  	    from_exception)
1cf8f7e5af3910 Ulf Hansson   2017-06-09   978  		return;
1cf8f7e5af3910 Ulf Hansson   2017-06-09   979  
1cf8f7e5af3910 Ulf Hansson   2017-06-09   980  	if (card->ext_csd.raw_bkops_status >= EXT_CSD_BKOPS_LEVEL_2) {
1cf8f7e5af3910 Ulf Hansson   2017-06-09   981  		timeout = MMC_OPS_TIMEOUT_MS;
1cf8f7e5af3910 Ulf Hansson   2017-06-09   982  		use_busy_signal = true;
1cf8f7e5af3910 Ulf Hansson   2017-06-09   983  	} else {
1cf8f7e5af3910 Ulf Hansson   2017-06-09   984  		timeout = 0;
1cf8f7e5af3910 Ulf Hansson   2017-06-09   985  		use_busy_signal = false;
1cf8f7e5af3910 Ulf Hansson   2017-06-09   986  	}
1cf8f7e5af3910 Ulf Hansson   2017-06-09   987  
1cf8f7e5af3910 Ulf Hansson   2017-06-09   988  	mmc_retune_hold(card->host);
1cf8f7e5af3910 Ulf Hansson   2017-06-09   989  
1cf8f7e5af3910 Ulf Hansson   2017-06-09   990  	err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
200a3e31fe3e70 Ulf Hansson   2022-05-17   991  			EXT_CSD_BKOPS_START, 1, MMC_BKOPS_TIMEOUT_MS, 0,
1cf8f7e5af3910 Ulf Hansson   2017-06-09   992  			use_busy_signal, true, false);
1cf8f7e5af3910 Ulf Hansson   2017-06-09   993  	if (err) {
1cf8f7e5af3910 Ulf Hansson   2017-06-09   994  		pr_warn("%s: Error %d starting bkops\n",
1cf8f7e5af3910 Ulf Hansson   2017-06-09   995  			mmc_hostname(card->host), err);
1cf8f7e5af3910 Ulf Hansson   2017-06-09   996  		mmc_retune_release(card->host);
9ca28c5cd967e0 Adrian Hunter 2017-09-22   997  		return;
1cf8f7e5af3910 Ulf Hansson   2017-06-09   998  	}
1cf8f7e5af3910 Ulf Hansson   2017-06-09   999  
1cf8f7e5af3910 Ulf Hansson   2017-06-09  1000  	/*
1cf8f7e5af3910 Ulf Hansson   2017-06-09  1001  	 * For urgent bkops status (LEVEL_2 and more)
1cf8f7e5af3910 Ulf Hansson   2017-06-09  1002  	 * bkops executed synchronously, otherwise
1cf8f7e5af3910 Ulf Hansson   2017-06-09  1003  	 * the operation is in progress
1cf8f7e5af3910 Ulf Hansson   2017-06-09  1004  	 */
1cf8f7e5af3910 Ulf Hansson   2017-06-09  1005  	if (!use_busy_signal)
1cf8f7e5af3910 Ulf Hansson   2017-06-09  1006  		mmc_card_set_doing_bkops(card);
1cf8f7e5af3910 Ulf Hansson   2017-06-09  1007  	else
1cf8f7e5af3910 Ulf Hansson   2017-06-09  1008  		mmc_retune_release(card->host);
1cf8f7e5af3910 Ulf Hansson   2017-06-09  1009  }
cb39f61e9b1e67 Adrian Hunter 2017-09-22  1010  EXPORT_SYMBOL(mmc_start_bkops);
1cf8f7e5af3910 Ulf Hansson   2017-06-09  1011  

:::::: The code at line 960 was first introduced by commit
:::::: 1cf8f7e5af3910781a21b84f13a34851aa228fe3 mmc: core: Move mmc bkops functions from core.c to mmc_ops.c

:::::: TO: Ulf Hansson <[email protected]>
:::::: CC: Ulf Hansson <[email protected]>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

                 reply	other threads:[~2022-05-19 17:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox