From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from 1wt.eu (wtarreau.pck.nerim.net [62.212.114.60]) by gnuweeb.org (Postfix) with ESMTP id 4F05A7E2D2 for ; Fri, 20 May 2022 04:23:53 +0000 (UTC) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 24K4NjtK005145; Fri, 20 May 2022 06:23:45 +0200 Date: Fri, 20 May 2022 06:23:45 +0200 From: Willy Tarreau To: "Paul E. McKenney" Cc: Ammar Faizi , Alviro Iskandar Setiawan , Linux Kernel Mailing List , GNU/Weeb Mailing List , Facebook Kernel Team Subject: Re: [PATCH v1 0/2] nolibc updates for Linux 5.20 Message-ID: <20220520042345.GE5001@1wt.eu> References: <20220519172116.283687-1-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220519172116.283687-1-ammarfaizi2@gnuweeb.org> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: On Fri, May 20, 2022 at 12:21:14AM +0700, Ammar Faizi wrote: > Not much to do this time. Only small nolibc updates here. There are two > patches in this series. > > 1. Address Willy's comment about overflow checking in the multiplication > operation [1]. This patch supports overflow checking for older > compiler versions. Currently, we use `__builtin_mul_overflow()` that > doesn't exist in older compiler versions. Instead of using this > built-in, use a simple division to check for overflow in the `calloc()` > function. > > 2. The compiler can warn us about wrong `printf` arguments. This patch > enables the warnings. Currently, only two functions use this attribute: > `printf` and `fprintf`. Paul, in summary I'm perfectly fine with the whole series, you can take it. Thanks! Willy