From: Willy Tarreau <[email protected]>
To: Linus Torvalds <[email protected]>
Cc: "Paul E. McKenney" <[email protected]>,
Linux Kernel Mailing List <[email protected]>,
Kernel Team <[email protected]>
Subject: Re: [GIT PULL] nolibc changes for v5.19
Date: Tue, 24 May 2022 00:01:20 +0200 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHk-=wiFJKNPqLw1LW2pbfWxY50AGqBPJRMk2_KfpODD=-z5ng@mail.gmail.com>
On Mon, May 23, 2022 at 02:13:20PM -0700, Linus Torvalds wrote:
(...)
> Does it work? No.
>
> > work the same on all commands but actually:
> >
> > make -C tools/ nolibc_headers
>
> Put another way: where did you find that "nolibc_headers"?
>
> THAT is what I'm talking about. You are mentioning all these magical
> things that don't match the documentation you yourself added.
OK thanks so now at least I have all the elements I was looking for,
I'm on it and will shortly provide fixes (in short, the main makefile's
variables not being set when doing make -C tools/ requires that some of
them are set as well under the target makefile).
For the second one I totally agree and as I said I think the problem
is wider, so I'll likely add a suggestion in tools/Makefile to also
try "make -C tools/ foo_help", which will allow different sub-projects
to provide a help target that enumerates their respective commands.
We'll start with nolibc and others could then follow, because clearly
for several other ones it's not obvious either and I think the lack
of standard way to display a tool's help doesn't help here.
thanks,
Willy
next prev parent reply other threads:[~2022-05-23 22:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 18:24 [GIT PULL] nolibc changes for v5.19 Paul E. McKenney
2022-05-23 18:42 ` Linus Torvalds
2022-05-23 19:56 ` Willy Tarreau
2022-05-23 20:23 ` Willy Tarreau
2022-05-23 20:30 ` Linus Torvalds
2022-05-23 20:50 ` Willy Tarreau
2022-05-23 21:04 ` Willy Tarreau
2022-05-23 21:13 ` Linus Torvalds
2022-05-23 22:01 ` Willy Tarreau [this message]
2022-05-23 19:20 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox