public inbox for [email protected]
 help / color / mirror / Atom feed
From: Stefan Roesch <[email protected]>
To: <[email protected]>, <[email protected]>,
	<[email protected]>, <[email protected]>,
	<[email protected]>
Cc: <[email protected]>, <[email protected]>, <[email protected]>, <[email protected]>
Subject: [PATCH v5 09/16] fs: Add async write file modification handling.
Date: Wed, 25 May 2022 15:34:25 -0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

This adds a file_modified_async() function to return -EAGAIN if the
request either requires to remove privileges or needs to update the file
modification time. This is required for async buffered writes, so the
request gets handled in the io worker of io-uring.

Signed-off-by: Stefan Roesch <[email protected]>
---
 fs/inode.c         | 43 +++++++++++++++++++++++++++++++++++++++++--
 include/linux/fs.h |  1 +
 2 files changed, 42 insertions(+), 2 deletions(-)

diff --git a/fs/inode.c b/fs/inode.c
index c44573a32c6a..4503bed063e7 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -2116,17 +2116,21 @@ int file_update_time(struct file *file)
 EXPORT_SYMBOL(file_update_time);
 
 /**
- * file_modified - handle mandated vfs changes when modifying a file
+ * file_modified_flags - handle mandated vfs changes when modifying a file
  * @file: file that was modified
+ * @flags: kiocb flags
  *
  * When file has been modified ensure that special
  * file privileges are removed and time settings are updated.
  *
+ * If IOCB_NOWAIT is set, special file privileges will not be removed and
+ * time settings will not be updated. It will return -EAGAIN.
+ *
  * Context: Caller must hold the file's inode lock.
  *
  * Return: 0 on success, negative errno on failure.
  */
-int file_modified(struct file *file)
+static int file_modified_flags(struct file *file, int flags)
 {
 	int ret;
 	struct inode *inode = file_inode(file);
@@ -2146,11 +2150,46 @@ int file_modified(struct file *file)
 	ret = inode_needs_update_time(inode, &now);
 	if (ret <= 0)
 		return ret;
+	if (flags & IOCB_NOWAIT)
+		return -EAGAIN;
 
 	return __file_update_time(file, &now, ret);
 }
+
+/**
+ * file_modified - handle mandated vfs changes when modifying a file
+ * @file: file that was modified
+ *
+ * When file has been modified ensure that special
+ * file privileges are removed and time settings are updated.
+ *
+ * Context: Caller must hold the file's inode lock.
+ *
+ * Return: 0 on success, negative errno on failure.
+ */
+int file_modified(struct file *file)
+{
+	return file_modified_flags(file, 0);
+}
 EXPORT_SYMBOL(file_modified);
 
+/**
+ * kiocb_modified - handle mandated vfs changes when modifying a file
+ * @iocb: iocb that was modified
+ *
+ * When file has been modified ensure that special
+ * file privileges are removed and time settings are updated.
+ *
+ * Context: Caller must hold the file's inode lock.
+ *
+ * Return: 0 on success, negative errno on failure.
+ */
+int kiocb_modified(struct kiocb *iocb)
+{
+	return file_modified_flags(iocb->ki_filp, iocb->ki_flags);
+}
+EXPORT_SYMBOL_GPL(kiocb_modified);
+
 int inode_needs_sync(struct inode *inode)
 {
 	if (IS_SYNC(inode))
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 407ad5004f54..2d9b3afcb4a5 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2384,6 +2384,7 @@ static inline void file_accessed(struct file *file)
 }
 
 extern int file_modified(struct file *file);
+int kiocb_modified(struct kiocb *iocb);
 
 int sync_inode_metadata(struct inode *inode, int wait);
 
-- 
2.30.2



  parent reply	other threads:[~2022-05-25 22:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 22:34 [PATCH v5 00/16] io-uring/xfs: support async buffered writes Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 01/16] mm: Move starting of background writeback into the main balancing loop Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 02/16] mm: Move updates of dirty_exceeded into one place Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 03/16] mm: Add balance_dirty_pages_ratelimited_flags() function Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 04/16] iomap: Add flags parameter to iomap_page_create() Stefan Roesch
2022-05-26 13:43   ` Jan Kara
2022-05-26 17:39     ` Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 05/16] iomap: Add async buffered write support Stefan Roesch
2022-05-26 13:39   ` Jan Kara
2022-05-25 22:34 ` [PATCH v5 06/16] fs: Add check for async buffered writes to generic_write_checks Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 07/16] fs: add __remove_file_privs() with flags parameter Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 08/16] fs: Split off inode_needs_update_time and __file_update_time Stefan Roesch
2022-05-25 22:34 ` Stefan Roesch [this message]
2022-05-25 22:34 ` [PATCH v5 10/16] fs: Optimization for concurrent file time updates Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 11/16] io_uring: Add support for async buffered writes Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 12/16] io_uring: Add tracepoint for short writes Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 13/16] xfs: Specify lockmode when calling xfs_ilock_for_iomap() Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 14/16] xfs: Change function signature of xfs_ilock_iocb() Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 15/16] xfs: Add async buffered write support Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 16/16] xfs: Enable " Stefan Roesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox