From: Ammar Faizi <[email protected]>
To: GNU/Weeb Mailing List <[email protected]>
Cc: Ammar Faizi <[email protected]>,
Nick Mathewson <[email protected]>
Subject: [PATCH tor v1 2/6] connection_or: Fix clang-15 complaint (unused variable)
Date: Thu, 26 May 2022 18:41:26 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
clang-15 throws the following complaints:
```
src/core/or/connection_or.c:1075:7: error: variable 'n_old' set but not used [-Werror,-Wunused-but-set-variable]
int n_old = 0, n_inprogress = 0, n_canonical = 0, n_other = 0;
^
src/core/or/connection_or.c:1075:53: error: variable 'n_other' set but not used [-Werror,-Wunused-but-set-variable]
int n_old = 0, n_inprogress = 0, n_canonical = 0, n_other = 0;
^
src/core/or/connection_or.c:1075:18: error: variable 'n_inprogress' set but not used [-Werror,-Wunused-but-set-variable]
int n_old = 0, n_inprogress = 0, n_canonical = 0, n_other = 0;
^
```
These variables firstly introduced in commit df608fef4522 ("Checkpoint
my big bug-891 patch."). Now they are no longer used. But I personally
think these variables may still be useful for counting purpose someday.
As such add `(void)` cast to them to suppress the clang complaints.
Cc: Nick Mathewson <[email protected]>
Signed-off-by: Ammar Faizi <[email protected]>
---
src/core/or/connection_or.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/core/or/connection_or.c b/src/core/or/connection_or.c
index 0018b1dfd8..5a387b54fe 100644
--- a/src/core/or/connection_or.c
+++ b/src/core/or/connection_or.c
@@ -1075,6 +1075,10 @@ connection_or_group_set_badness_(smartlist_t *group, int force)
int n_old = 0, n_inprogress = 0, n_canonical = 0, n_other = 0;
time_t now = time(NULL);
+ (void)n_old;
+ (void)n_inprogress;
+ (void)n_other;
+
/* Pass 1: expire everything that's old, and see what the status of
* everything else is. */
SMARTLIST_FOREACH_BEGIN(group, or_connection_t *, or_conn) {
--
Ammar Faizi
next prev parent reply other threads:[~2022-05-26 11:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 11:41 [GIT PULL tor v1 0/6] Build fixes for clang-15 Ammar Faizi
2022-05-26 11:41 ` [PATCH tor v1 1/6] channel: Fix clang-15 complaint (unused variable) Ammar Faizi
2022-05-26 11:41 ` Ammar Faizi [this message]
2022-05-26 11:41 ` [PATCH tor v1 3/6] routerlist: " Ammar Faizi
2022-05-26 11:41 ` [PATCH tor v1 4/6] compat_libevent: " Ammar Faizi
2022-05-26 11:41 ` [PATCH tor v1 5/6] test/bench: " Ammar Faizi
2022-05-26 11:41 ` [PATCH tor v1 6/6] test/test_hs_descriptor: Don't invoke GCC warning when compiling with clang Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox