From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gnuweeb.org (Postfix) with ESMTPS id 6B8AA7FE49 for ; Wed, 22 Jun 2022 13:10:50 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=dHKWRGc+; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655903450; x=1687439450; h=date:from:to:cc:subject:message-id:mime-version; bh=1kvT5kphf2ppWOofxuRUBPhw/d3m0dVFYfPTF8riA24=; b=dHKWRGc+6WnBqds+hL28+prkBR4eFajctx4NVghFrvW9W8aAM5WvXvJt mXsxm8RHUvcrqmQhdl8MFyKxR/czhG2oXERGzN37134TNqkQQR6okRHrd ck1XyS+yfFI8fCmmxo0TExoyopHg53EbjjZSZluDlpxniyaFZkf5ftoOz VM/eZiVgr1xl18mS7UVGdbS+lCRh8+qHXwsHDyhRMSmR+IdrdWlVdZU4i DUmoXrZB6LuUv/PVsEA3BHDWnJawU1MqD+cNGgEpnvsjdo5uvH34OxAbx RHZLk32iQNOShy0dMAqXycorrRd4nep1t4WavbTwV1pUvNhLcOr+yRQWl A==; X-IronPort-AV: E=McAfee;i="6400,9594,10385"; a="279179320" X-IronPort-AV: E=Sophos;i="5.92,212,1650956400"; d="scan'208";a="279179320" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 06:10:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,212,1650956400"; d="scan'208";a="538463843" Received: from lkp-server02.sh.intel.com (HELO a67cc04a5eeb) ([10.239.97.151]) by orsmga003.jf.intel.com with ESMTP; 22 Jun 2022 06:10:47 -0700 Received: from kbuild by a67cc04a5eeb with local (Exim 4.95) (envelope-from ) id 1o4086-0001IL-Vj; Wed, 22 Jun 2022 13:10:46 +0000 Date: Wed, 22 Jun 2022 21:10:30 +0800 From: kernel test robot To: Pavel Skripkin Cc: kbuild-all@lists.01.org, GNU/Weeb Mailing List , linux-kernel@vger.kernel.org, Kalle Valo Subject: [ammarfaizi2-block:kvalo/ath/pending 3/10] drivers/net/wireless/ath/ath9k/hif_usb.c:251:57: warning: suggest braces around empty body in an 'else' statement Message-ID: <202206222110.WLZh7cQf-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline List-Id: tree: https://github.com/ammarfaizi2/linux-block kvalo/ath/pending head: ff1c40050ac3ca6a55ccc7970e37503e75465977 commit: d7fc76039b74ad37b7056d5607b05d7cb31a5404 [3/10] ath9k: htc: clean up statistics macros config: xtensa-randconfig-r033-20220622 (https://download.01.org/0day-ci/archive/20220622/202206222110.WLZh7cQf-lkp@intel.com/config) compiler: xtensa-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/ammarfaizi2/linux-block/commit/d7fc76039b74ad37b7056d5607b05d7cb31a5404 git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block git fetch --no-tags ammarfaizi2-block kvalo/ath/pending git checkout d7fc76039b74ad37b7056d5607b05d7cb31a5404 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/net/wireless/ath/ath9k/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/wireless/ath/ath9k/hif_usb.c: In function 'ath9k_skb_queue_complete': >> drivers/net/wireless/ath/ath9k/hif_usb.c:251:57: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] 251 | TX_STAT_INC(hif_dev, skb_failed); | ^ vim +/else +251 drivers/net/wireless/ath/ath9k/hif_usb.c 233 234 static inline void ath9k_skb_queue_complete(struct hif_device_usb *hif_dev, 235 struct sk_buff_head *queue, 236 bool txok) 237 { 238 struct sk_buff *skb; 239 240 while ((skb = __skb_dequeue(queue)) != NULL) { 241 #ifdef CONFIG_ATH9K_HTC_DEBUGFS 242 int ln = skb->len; 243 #endif 244 ath9k_htc_txcompletion_cb(hif_dev->htc_handle, 245 skb, txok); 246 if (txok) { 247 TX_STAT_INC(hif_dev, skb_success); 248 TX_STAT_ADD(hif_dev, skb_success_bytes, ln); 249 } 250 else > 251 TX_STAT_INC(hif_dev, skb_failed); 252 } 253 } 254 -- 0-DAY CI Kernel Test Service https://01.org/lkp