From: Ammar Faizi <[email protected]>
To: GNU/Weeb Mailing List <[email protected]>
Cc: Ammar Faizi <[email protected]>,
Arthur Lapz <[email protected]>, Sprite <[email protected]>,
Yonle <[email protected]>
Subject: [PATCH gwhttpd 0/7] gwhttpd updates
Date: Sun, 26 Jun 2022 12:56:27 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
Hi,
This series contains gwhttpd refactoring and updates. I am going
to add directory traversing support feature, but before that,
several cleanups need to get done. And here it is...
Summary below...
## Patch 1
Don't continue executing the next line if we fail to parse the
HTTP header, that's the wrong path, we should stop the client
early.
## Patch 2
This mlock is just optional, don't bother showing error.
## Patch 3
Let the caller close the connection, we need to have more decisions
in the caller rather than closing it directly.
## Patch 4
Print a log message that we are interrupted, this makes the app user
friendly because the user can explicitly see from the output that the
app is interrupted.
## Patch 5
The HTTP header parser was prone and doesn't handle many edge cases.
This is a full refactor of HTTP header parser. While in there, add
more HTTP method supports.
## Patch 6
When we fail to send() due to EAGAIN, we retry the send(). However,
if we are spinning on this retry for so long, this will eat CPU cycle
and slow down the entire application. We should stop retrying at
some point. Add a loop counter and return -ENETDOWN if we are failing
too many times in the send() retry loop cycle.
## Patch 7
A patch for Makefile. Add a command to clean the binary file.
Signed-off-by: Ammar Faizi <[email protected]>
---
Ammar Faizi (7):
gwhttpd: Do an early return when parse_http_header fails
gwhttpd: Don't print any error when mlock fails
gwhttpd: Replace `send_error_and_close` with `send_http_error()`
gwhttpd: Add log in the interrupt handler
gwhttpd: Refactor HTTP header parser
gwhttpd: Avoid endless busy spinning on `send()`
Makefile: Add "make clean" command
Makefile | 3 +
gwhttpd.cpp | 220 +++++++++++++++++++++++++++++++++++++---------------
2 files changed, 161 insertions(+), 62 deletions(-)
base-commit: 944b77d9aaac4a88729da6ec2f76447a9c3562ab
--
Ammar Faizi
next reply other threads:[~2022-06-26 5:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-26 5:56 Ammar Faizi [this message]
2022-06-26 5:56 ` [PATCH gwhttpd 1/7] gwhttpd: Do an early return when parse_http_header fails Ammar Faizi
2022-06-26 5:56 ` [PATCH gwhttpd 2/7] gwhttpd: Don't print any error when mlock fails Ammar Faizi
2022-06-26 5:56 ` [PATCH gwhttpd 3/7] gwhttpd: Replace `send_error_and_close` with `send_http_error()` Ammar Faizi
2022-06-26 5:56 ` [PATCH gwhttpd 4/7] gwhttpd: Add log in the interrupt handler Ammar Faizi
2022-06-26 5:56 ` [PATCH gwhttpd 5/7] gwhttpd: Refactor HTTP header parser Ammar Faizi
2022-06-26 5:56 ` [PATCH gwhttpd 6/7] gwhttpd: Avoid endless busy spinning on `send()` Ammar Faizi
2022-06-26 5:56 ` [PATCH gwhttpd 7/7] Makefile: Add "make clean" command Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox