public inbox for [email protected]
 help / color / mirror / Atom feed
From: Ammar Faizi <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Ammar Faizi <[email protected]>,
	Alviro Iskandar Setiawan <[email protected]>,
	Fernanda Ma'rouf <[email protected]>,
	Pavel Begunkov <[email protected]>,
	Hao Xu <[email protected]>,
	io-uring Mailing List <[email protected]>,
	GNU/Weeb Mailing List <[email protected]>
Subject: [PATCH liburing v1 0/9] aarch64 nolibc support
Date: Wed, 29 Jun 2022 07:27:44 +0700	[thread overview]
Message-ID: <[email protected]> (raw)

From: Ammar Faizi <[email protected]>

Hi Jens,

This series contains nolibc support for aarch64 and one extra irrelevant
cleanup (patch #1). The missing bit from aarch64 is get_page_size()
which is a bit complicated to implement without libc.

aarch64 supports three values of page size: 4K, 16K, and 64K which are
selected at kernel compilation time. Therefore, we can't hard code the
page size for this arch. In this series we utilize open(), read() and
close() syscall to find the page size from /proc/self/auxv.

The auxiliary vector contains information about the page size, it is
located at `AT_PAGESZ` keyval pair.

For more details about the auxv data structure, check the link below.

Link: https://github.com/torvalds/linux/blob/v5.19-rc4/fs/binfmt_elf.c#L260
Link: https://lwn.net/Articles/631631/

There are 9 patches in this series.

- Patch 1 is just a trivial changelog fix.
- Patch 2 is to handle get_page_size() error that may happen in the
  later patches.
- Patch 3 and 4 are to add open() and read() syscall. We will need them
  to get the page size on aarch64.
- Patch 5 is to rename aarch64 directory to arm64.
- Patch 6 is to remove __INTERNAL__LIBURING_SYSCALL_H checks.
- Patch 7 is to add get_page_size() function.
- Patch 8 is to enable the nolibc support for aarch64.
- Patch 9 is for GitHub bot build.

I have built it with GitHub bot and it compiles just fine. But I don't
have an aarch64 machine to run the tests. Since you are using aarch64,
I can rely on you to test it.

How to test this?

  make clean;
  ./configure --nolibc;
  make -j8;
  make runtests;

Please give it a test...

Signed-off-by: Ammar Faizi <[email protected]>
---

Ammar Faizi (9):
  CHANGELOG: Fixup missing space
  setup: Handle `get_page_size()` failure (for aarch64 nolibc support)
  arch: syscall: Add `__sys_open()` syscall
  arch: syscall: Add `__sys_read()` syscall
  arch/arm64: Rename aarch64 directory to arm64
  arch: syscall: Remove `__INTERNAL__LIBURING_SYSCALL_H` checks
  arch/arm64: Add `get_page_size()` function
  arch: Enable nolibc support for arm64
  .github: Enable aarch64 nolibc build for GitHub bot

 .github/workflows/build.yml           |  2 +-
 CHANGELOG                             |  2 +-
 src/arch/arm64/lib.h                  | 44 +++++++++++++++++++++++++++
 src/arch/{aarch64 => arm64}/syscall.h | 14 ++++-----
 src/arch/generic/lib.h                |  4 ---
 src/arch/generic/syscall.h            | 20 +++++++++---
 src/arch/syscall-defs.h               | 12 ++++++++
 src/arch/x86/lib.h                    |  4 ---
 src/arch/x86/syscall.h                |  4 ---
 src/lib.h                             | 21 +++++++------
 src/setup.c                           |  3 ++
 src/syscall.h                         |  4 +--
 12 files changed, 97 insertions(+), 37 deletions(-)
 create mode 100644 src/arch/arm64/lib.h
 rename src/arch/{aarch64 => arm64}/syscall.h (91%)


base-commit: 68103b731c34a9f83c181cb33eb424f46f3dcb94
-- 
Ammar Faizi


             reply	other threads:[~2022-06-29  0:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29  0:27 Ammar Faizi [this message]
2022-06-29  0:27 ` [PATCH liburing v1 1/9] CHANGELOG: Fixup missing space Ammar Faizi
2022-06-29  0:27 ` [PATCH liburing v1 2/9] setup: Handle `get_page_size()` failure (for aarch64 nolibc support) Ammar Faizi
2022-06-29  0:50   ` Alviro Iskandar Setiawan
2022-06-29  1:00     ` Ammar Faizi
2022-06-29 15:00       ` Jens Axboe
2022-06-29 15:17         ` Ammar Faizi
2022-06-29  0:27 ` [PATCH liburing v1 3/9] arch: syscall: Add `__sys_open()` syscall Ammar Faizi
2022-06-29  0:27 ` [PATCH liburing v1 4/9] arch: syscall: Add `__sys_read()` syscall Ammar Faizi
2022-06-29  0:27 ` [PATCH liburing v1 5/9] arch/arm64: Rename aarch64 directory to arm64 Ammar Faizi
2022-06-29 14:48   ` Jens Axboe
2022-06-29 14:51     ` Ammar Faizi
2022-06-29  0:27 ` [PATCH liburing v1 6/9] arch: syscall: Remove `__INTERNAL__LIBURING_SYSCALL_H` checks Ammar Faizi
2022-06-29  0:27 ` [PATCH liburing v1 7/9] arch/arm64: Add `get_page_size()` function Ammar Faizi
2022-06-29  0:31   ` Ammar Faizi
2022-06-29 14:49   ` Jens Axboe
2022-06-29 14:52     ` Ammar Faizi
2022-06-29  0:27 ` [PATCH liburing v1 8/9] arch: Enable nolibc support for arm64 Ammar Faizi
2022-06-29  0:27 ` [PATCH liburing v1 9/9] .github: Enable aarch64 nolibc build for GitHub bot Ammar Faizi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox