public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH liburing v3 00/10] aarch64 support
@ 2022-07-04 17:54 Ammar Faizi
  2022-07-04 17:54 ` [PATCH liburing v3 01/10] CHANGELOG: Fixup missing space Ammar Faizi
                   ` (9 more replies)
  0 siblings, 10 replies; 16+ messages in thread
From: Ammar Faizi @ 2022-07-04 17:54 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Ammar Faizi, Alviro Iskandar Setiawan, Fernanda Ma'rouf,
	Hao Xu, Pavel Begunkov, io-uring Mailing List,
	GNU/Weeb Mailing List

From: Ammar Faizi <[email protected]>

Hi Jens,

This is v3 revision of aarch64 support.

This series contains nolibc support for aarch64 and one extra irrelevant
cleanup (patch #1). The missing bit from aarch64 is get_page_size()
which is a bit complicated to implement without libc.

aarch64 supports three values of page size: 4K, 16K, and 64K which are
selected at kernel compilation time. Therefore, we can't hard code the
page size for this arch. In this series we utilize open(), read() and
close() syscall to find the page size from /proc/self/auxv.

The auxiliary vector contains information about the page size, it is
located at `AT_PAGESZ` keyval pair.

For more details about the auxv data structure, check the link below.

Link: https://github.com/torvalds/linux/blob/v5.19-rc4/fs/binfmt_elf.c#L260
Link: https://lwn.net/Articles/631631/

There are 10 patches in this series. Summary:

- Patch 1 is just a trivial changelog fix.
- Patch 2 and 3 are to add open() and read() syscall.
- Patch 4 is to remove __INTERNAL__LIBURING_SYSCALL_H checks.
- Patch 5 is to add get_page_size() function.
- Patch 6 is just a trivial style fixup for #ifdef and friends.
- Patch 7 is to enable the nolibc support for aarch64.
- Patch 8 is to add nolibc test.
- Patch 9 is for GitHub bot build.
- Patch 10 is to update the CHANGELOG to note aarch64 nolibc support.

I have built it with GitHub bot and it compiles just fine. But I don't
have an aarch64 machine to run the tests. Since you are using aarch64,
I can rely on you to test it.

How to test this?

  make clean;
  ./configure --nolibc;
  make -j8;

  ldd src/liburing.so.2.3;
  # Make sure you don't see libc.so from the `ldd` command.

  make runtests;

Please give it a test, thanks!

## Changelog

v2 -> v3:
  - No need to init the static var to zero.
  - Split style fixup into a separate patch.
  - Add nolibc test to test get_page_size() function.
  - Use __NR_openat when __NR_open is not defined on the arch.
  - Split open/read/close in get_page_size() into a new function.
  - Cache the get_page_size() fallback value when we fail on the
    syscalls.

v1 -> v2:
  - Drop aarch64 renaming directory patch.
  - Fallback the page size to 4K if we fail to get it.
  - Cache the page size after we read it from /proc/self/auxv.
  - Massage commit messages.
  - Note aarch64 nolibc support in CHANGELOG.

Signed-off-by: Ammar Faizi <[email protected]>
---

Ammar Faizi (10):
  CHANGELOG: Fixup missing space
  arch: syscall: Add `__sys_open()` syscall
  arch: syscall: Add `__sys_read()` syscall
  arch: Remove `__INTERNAL__LIBURING_LIB_H` checks
  arch/aarch64: lib: Add `get_page_size()` function
  lib: Style fixup for #if / #elif / #else / #endif
  lib: Enable nolibc support for aarch64
  test: Add nolibc test
  .github: Enable aarch64 nolibc build for GitHub bot
  CHANGELOG: Note about aarch64 support

 .github/workflows/build.yml |  2 +-
 CHANGELOG                   |  7 ++++-
 src/arch/aarch64/lib.h      | 51 +++++++++++++++++++++++++++++++
 src/arch/aarch64/syscall.h  |  4 ---
 src/arch/generic/lib.h      |  4 ---
 src/arch/generic/syscall.h  | 20 ++++++++++---
 src/arch/syscall-defs.h     | 19 ++++++++++++
 src/arch/x86/lib.h          |  4 ---
 src/arch/x86/syscall.h      |  4 ---
 src/lib.h                   | 32 ++++++++++----------
 src/syscall.h               |  2 --
 test/Makefile               |  1 +
 test/nolibc.c               | 60 +++++++++++++++++++++++++++++++++++++
 13 files changed, 170 insertions(+), 40 deletions(-)
 create mode 100644 src/arch/aarch64/lib.h
 create mode 100644 test/nolibc.c


base-commit: f8eb5f804288e10ae7ef442ef482e4dd8b18fee7
-- 
Ammar Faizi


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2022-07-04 18:23 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-04 17:54 [PATCH liburing v3 00/10] aarch64 support Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 01/10] CHANGELOG: Fixup missing space Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 02/10] arch: syscall: Add `__sys_open()` syscall Ammar Faizi
2022-07-04 18:07   ` Alviro Iskandar Setiawan
2022-07-04 17:54 ` [PATCH liburing v3 03/10] arch: syscall: Add `__sys_read()` syscall Ammar Faizi
2022-07-04 18:12   ` Alviro Iskandar Setiawan
2022-07-04 18:16     ` Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 04/10] arch: Remove `__INTERNAL__LIBURING_LIB_H` checks Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 05/10] arch/aarch64: lib: Add `get_page_size()` function Ammar Faizi
2022-07-04 18:18   ` Alviro Iskandar Setiawan
2022-07-04 18:23     ` Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 06/10] lib: Style fixup for #if / #elif / #else / #endif Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 07/10] lib: Enable nolibc support for aarch64 Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 08/10] test: Add nolibc test Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 09/10] .github: Enable aarch64 nolibc build for GitHub bot Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 10/10] CHANGELOG: Note about aarch64 support Ammar Faizi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox