public inbox for [email protected]
 help / color / mirror / Atom feed
From: kernel test robot <[email protected]>
To: Christian Brauner <[email protected]>
Cc: [email protected],
	GNU/Weeb Mailing List <[email protected]>,
	[email protected]
Subject: [ammarfaizi2-block:brauner/linux/fs.idmapped.overlay.acl.fix 1/1] fs/overlayfs/overlayfs.h:273:65: warning: passing argument 4 of 'ovl_do_setxattr' discards 'const' qualifier from pointer target type
Date: Wed, 6 Jul 2022 01:16:36 +0800	[thread overview]
Message-ID: <[email protected]> (raw)

tree:   https://github.com/ammarfaizi2/linux-block brauner/linux/fs.idmapped.overlay.acl.fix
head:   05bde3ad56201ff691db6d95ea1316983ea82a9c
commit: 05bde3ad56201ff691db6d95ea1316983ea82a9c [1/1] acl: report correct ownership in some ovl use-cases
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220706/[email protected]/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/ammarfaizi2/linux-block/commit/05bde3ad56201ff691db6d95ea1316983ea82a9c
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block brauner/linux/fs.idmapped.overlay.acl.fix
        git checkout 05bde3ad56201ff691db6d95ea1316983ea82a9c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <[email protected]>

All warnings (new ones prefixed by >>):

   In file included from fs/overlayfs/super.c:18:
   fs/overlayfs/overlayfs.h: In function 'ovl_setxattr':
>> fs/overlayfs/overlayfs.h:273:65: warning: passing argument 4 of 'ovl_do_setxattr' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     273 |         return ovl_do_setxattr(ofs, dentry, ovl_xattr(ofs, ox), value, size, 0);
         |                                                                 ^~~~~
   fs/overlayfs/overlayfs.h:259:59: note: expected 'void *' but argument is of type 'const void *'
     259 |                                   const char *name, void *value,
         |                                                     ~~~~~~^~~~~
--
   In file included from fs/overlayfs/inode.c:17:
   fs/overlayfs/overlayfs.h: In function 'ovl_setxattr':
>> fs/overlayfs/overlayfs.h:273:65: warning: passing argument 4 of 'ovl_do_setxattr' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     273 |         return ovl_do_setxattr(ofs, dentry, ovl_xattr(ofs, ox), value, size, 0);
         |                                                                 ^~~~~
   fs/overlayfs/overlayfs.h:259:59: note: expected 'void *' but argument is of type 'const void *'
     259 |                                   const char *name, void *value,
         |                                                     ~~~~~~^~~~~
   fs/overlayfs/inode.c: In function 'ovl_xattr_set':
>> fs/overlayfs/inode.c:378:62: warning: passing argument 4 of 'ovl_do_setxattr' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     378 |                 err = ovl_do_setxattr(ofs, realdentry, name, value, size,
         |                                                              ^~~~~
   In file included from fs/overlayfs/inode.c:17:
   fs/overlayfs/overlayfs.h:259:59: note: expected 'void *' but argument is of type 'const void *'
     259 |                                   const char *name, void *value,
         |                                                     ~~~~~~^~~~~


vim +273 fs/overlayfs/overlayfs.h

c914c0e27eb084 Amir Goldstein 2022-04-04  268  
c914c0e27eb084 Amir Goldstein 2022-04-04  269  static inline int ovl_setxattr(struct ovl_fs *ofs, struct dentry *dentry,
43d193f8440d67 Miklos Szeredi 2020-09-02  270  			       enum ovl_xattr ox, const void *value,
610afc0bd40882 Miklos Szeredi 2020-09-02  271  			       size_t size)
e9be9d5e76e348 Miklos Szeredi 2014-10-24  272  {
c914c0e27eb084 Amir Goldstein 2022-04-04 @273  	return ovl_do_setxattr(ofs, dentry, ovl_xattr(ofs, ox), value, size, 0);
e9be9d5e76e348 Miklos Szeredi 2014-10-24  274  }
e9be9d5e76e348 Miklos Szeredi 2014-10-24  275  

:::::: The code at line 273 was first introduced by commit
:::::: c914c0e27eb0843b7cf3bec71d6f34d53a3a671e ovl: use wrappers to all vfs_*xattr() calls

:::::: TO: Amir Goldstein <[email protected]>
:::::: CC: Miklos Szeredi <[email protected]>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

             reply	other threads:[~2022-07-05 17:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05 17:16 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-07-05 21:20 [ammarfaizi2-block:brauner/linux/fs.idmapped.overlay.acl.fix 1/1] fs/overlayfs/overlayfs.h:273:65: warning: passing argument 4 of 'ovl_do_setxattr' discards 'const' qualifier from pointer target type kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox