public inbox for [email protected]
 help / color / mirror / Atom feed
From: kernel test robot <[email protected]>
To: Ammar Faizi <[email protected]>,
	GNU/Weeb Mailing List <[email protected]>
Cc: [email protected]
Subject: [ammarfaizi2-block:google/android/kernel/common/deprecated/android-4.4-p-release 7812/9922] fs/proc/uid.c:139:14: warning: comparison between signed and unsigned integer expressions
Date: Thu, 14 Jul 2022 18:41:57 +0800	[thread overview]
Message-ID: <[email protected]> (raw)

tree:   https://github.com/ammarfaizi2/linux-block google/android/kernel/common/deprecated/android-4.4-p-release
head:   c159ade87311501e4e4b40eb2f35aa5607732957
commit: 552095deb5650aa958cb29c6ae712728d38c4a5a [7812/9922] ANDROID: proc: Add /proc/uid directory
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220714/[email protected]/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
        # https://github.com/ammarfaizi2/linux-block/commit/552095deb5650aa958cb29c6ae712728d38c4a5a
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block google/android/kernel/common/deprecated/android-4.4-p-release
        git checkout 552095deb5650aa958cb29c6ae712728d38c4a5a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash fs/proc/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <[email protected]>

All warnings (new ones prefixed by >>):

   cc1: warning: arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs]
   cc1: warning: arch/x86/include/generated: No such file or directory [-Wmissing-include-dirs]
   cc1: warning: arch/x86/include/generated/uapi: No such file or directory [-Wmissing-include-dirs]
   fs/proc/uid.c:90:15: warning: no previous declaration for 'proc_uid_make_inode' [-Wmissing-declarations]
    struct inode *proc_uid_make_inode(struct super_block *sb, kuid_t kuid)
                  ^~~~~~~~~~~~~~~~~~~
   fs/proc/uid.c: In function 'proc_uid_base_lookup':
>> fs/proc/uid.c:139:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
      if (u->len != dentry->d_name.len)
                 ^~
   fs/proc/uid.c: In function 'proc_uid_base_readdir':
   fs/proc/uid.c:162:35: warning: array subscript is below array bounds [-Warray-bounds]
          u <= uid_base_stuff + nents - 1; u++) {
               ~~~~~~~~~~~~~~~~~~~~~~~^~~


vim +139 fs/proc/uid.c

   126	
   127	static struct dentry *proc_uid_base_lookup(struct inode *dir,
   128						   struct dentry *dentry,
   129						   unsigned int flags)
   130	{
   131		const struct uid_entry *u, *last;
   132		unsigned int nents = ARRAY_SIZE(uid_base_stuff);
   133	
   134		if (nents == 0)
   135			return ERR_PTR(-ENOENT);
   136	
   137		last = &uid_base_stuff[nents - 1];
   138		for (u = uid_base_stuff; u <= last; u++) {
 > 139			if (u->len != dentry->d_name.len)
   140				continue;
   141			if (!memcmp(dentry->d_name.name, u->name, u->len))
   142				break;
   143		}
   144		if (u > last)
   145			return ERR_PTR(-ENOENT);
   146	
   147		return ERR_PTR(proc_uident_instantiate(dir, dentry, NULL, u));
   148	}
   149	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

                 reply	other threads:[~2022-07-14 10:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox